From: David Kalnischkies <kalnischkies@gmail.com>
Date: Sun, 13 Oct 2013 17:33:09 +0000 (+0200)
Subject: fix progress-segfault in case of dpkg errors/prompts
X-Git-Tag: 0.9.12.1~3^2
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/7794a6880e74446075d9cae19525829ada5b0d91?hp=-c

fix progress-segfault in case of dpkg errors/prompts

Errors and conffile prompts have a fourth information piece,
which the "old" code access which isn't provided by the "new" one.

This isn't checking if the messages are really well-formed,
so it could still segfault on misformed messages, but this code
needs more work anyway, so one step at a time.

Closes: 726047
---

7794a6880e74446075d9cae19525829ada5b0d91
diff --git a/apt-pkg/deb/dpkgpm.cc b/apt-pkg/deb/dpkgpm.cc
index c29d21574..1fbeabbdc 100644
--- a/apt-pkg/deb/dpkgpm.cc
+++ b/apt-pkg/deb/dpkgpm.cc
@@ -546,8 +546,8 @@ void pkgDPkgPM::ProcessDpkgStatusLine(int OutStatusFd, char *line)
    // A dpkg error message may contain additional ":" (like
    //  "failed in buffer_write(fd) (10, ret=-1): backend dpkg-deb ..."
    // so we need to ensure to not split too much
-   std::vector<std::string> list = StringSplit(line, ": ", 3);
-   if(list.size() != 3)
+   std::vector<std::string> list = StringSplit(line, ": ", 4);
+   if(list.size() < 3)
    {
       if (Debug == true)
 	 std::clog << "ignoring line: not enough ':'" << std::endl;