From: David Kalnischkies <david@kalnischkies.de>
Date: Thu, 10 Sep 2015 20:44:01 +0000 (+0200)
Subject: fix 'Dead assignment' by dropping unneeded boolean
X-Git-Tag: 1.1.exp13~24
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/69b7654484c3f16d61f315275abb15cc062d190e

fix 'Dead assignment' by dropping unneeded boolean

Reported-By: scan-build
Git-Dch: Ignore
---

diff --git a/apt-pkg/acquire.cc b/apt-pkg/acquire.cc
index 433a2a6fa..6a800002e 100644
--- a/apt-pkg/acquire.cc
+++ b/apt-pkg/acquire.cc
@@ -467,9 +467,8 @@ static void CheckDropPrivsMustBeDisabled(pkgAcquire const &Fetcher)
    if (seteuid(pw->pw_uid) != 0)
       _error->Errno("seteuid", "seteuid %u failed", pw->pw_uid);
 
-   bool dropPrivs = true;
    for (pkgAcquire::ItemCIterator I = Fetcher.ItemsBegin();
-	I != Fetcher.ItemsEnd() && dropPrivs == true; ++I)
+	I != Fetcher.ItemsEnd(); ++I)
    {
       std::string filename = (*I)->DestFile;
       if (filename.empty())
@@ -496,7 +495,6 @@ static void CheckDropPrivsMustBeDisabled(pkgAcquire const &Fetcher)
 
       if (faccessat(-1, dirname.c_str(), R_OK | W_OK | X_OK, AT_EACCESS | AT_SYMLINK_NOFOLLOW) != 0)
       {
-	 dropPrivs = false;
 	 _error->WarningE("pkgAcquire::Run", _("Can't drop privileges for downloading as file '%s' couldn't be accessed by user '%s'."),
 	       filename.c_str(), SandboxUser.c_str());
 	 _config->Set("APT::Sandbox::User", "");