From: Michael Vogt <mvo@debian.org>
Date: Fri, 14 Feb 2014 18:58:56 +0000 (+0100)
Subject: disable fnmatch()
X-Git-Tag: 0.9.15.3~10
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/32611903e8dcd6599042552c6c576b70e3d6633a

disable fnmatch()

The current PackageContainerInterface::FromString() will do a
FromFnmatch() first and then FromRegEx(). This commit reverts
that change to restore the old behavior to only look for RegEx
and not glob-style pattern. The rational is that:
a) currently a fnmatch() is misleadingly reported as a regex match to
   the user (Bug#738880)
b) a fnmatch may match something different than a a RegEx so the
   change broke a published interface
---

diff --git a/apt-pkg/cacheset.cc b/apt-pkg/cacheset.cc
index 1b1e6d595..eab1e09f8 100644
--- a/apt-pkg/cacheset.cc
+++ b/apt-pkg/cacheset.cc
@@ -312,7 +312,6 @@ bool PackageContainerInterface::FromString(PackageContainerInterface * const pci
 
 	if (FromGroup(pci, Cache, str, helper) == false &&
 		 FromTask(pci, Cache, str, helper) == false &&
-		 FromFnmatch(pci, Cache, str, helper) == false &&
 		 FromRegEx(pci, Cache, str, helper) == false)
 	{
 		helper.canNotFindPackage(pci, Cache, str);