From: Edgar Fuß <ef@math.uni-bonn.de>
Date: Fri, 11 Nov 2016 09:20:23 +0000 (+0100)
Subject: http: clear content before reporting the failure
X-Git-Tag: 1.4_beta1~34
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/324bb34d77a43d1be411c402b2e11f588194439a

http: clear content before reporting the failure

[Comment from commiter:] I have the feeling that the issue itself is
fixed for a while already as nowadays we have testcases involving a
webserver closing the connection on error (look for "closeOnError") and
no even remotely recent reports about it, but moving the content
clearance above the failure report is a valid change and shouldn't hurt.

Closes: #465572
---

diff --git a/methods/server.cc b/methods/server.cc
index af7276bad..0408dddfd 100644
--- a/methods/server.cc
+++ b/methods/server.cc
@@ -770,8 +770,8 @@ int ServerMethod::Loop()
 	 // We need to flush the data, the header is like a 404 w/ error text
 	 case ERROR_WITH_CONTENT_PAGE:
 	 {
-	    Fail();
 	    Server->RunDataToDevNull();
+	    Fail();
 	    break;
 	 }