From: David Kalnischkies <david@kalnischkies.de>
Date: Sat, 28 Nov 2015 15:09:42 +0000 (+0100)
Subject: disable privilege dropping for rsh/ssh method by default
X-Git-Tag: 1.1.2~4
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/25ff0797da5bc59ad4c322c7f1ea25664be8a461

disable privilege dropping for rsh/ssh method by default

ssh expects various configuration bits to be usable like known hosts,
possibly keys and co. Setting this up needs some user work for probably
not a whole lot of benefits, so instead of forcing it upon users on
upgrade disable dropping for it by default.

Closes: 806511
---

diff --git a/methods/rsh.cc b/methods/rsh.cc
index 9d82a99e3..4d133951f 100644
--- a/methods/rsh.cc
+++ b/methods/rsh.cc
@@ -398,6 +398,10 @@ RSHMethod::RSHMethod(std::string const &pProg) : aptMethod(pProg.c_str(),"1.0",S
 // ---------------------------------------------------------------------
 bool RSHMethod::Configuration(std::string Message)
 {
+   // enabling privilege dropping for this method requires configuration…
+   // … which is otherwise lifted straight from root, so use it by default.
+   _config->Set(std::string("Binary::") + Prog + "::APT::Sandbox::User", "");
+
    if (aptMethod::Configuration(Message) == false)
       return false;