From: Arch Librarian <arch@canonical.com>
Date: Mon, 20 Sep 2004 16:59:02 +0000 (+0000)
Subject: Improved message for pre-depends/depend loops
X-Git-Tag: 0.7.24ubuntu1~930
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/1006601e63c83586ae7786b648cfeb3c8feb72c2

Improved message for pre-depends/depend loops
Author: jgg
Date: 2002-04-02 06:01:49 GMT
Improved message for pre-depends/depend loops
---

diff --git a/apt-pkg/packagemanager.cc b/apt-pkg/packagemanager.cc
index fc5f475a1..b0ebcdb59 100644
--- a/apt-pkg/packagemanager.cc
+++ b/apt-pkg/packagemanager.cc
@@ -1,6 +1,6 @@
 // -*- mode: cpp; mode: fold -*-
 // Description								/*{{{*/
-// $Id: packagemanager.cc,v 1.28 2001/05/27 05:36:04 jgg Exp $
+// $Id: packagemanager.cc,v 1.29 2002/04/02 06:01:49 jgg Exp $
 /* ######################################################################
 
    Package Manager - Abstacts the package manager
@@ -483,13 +483,16 @@ bool pkgPackageManager::SmartUnPack(PkgIterator Pkg)
 
 	    Bad = !SmartConfigure(Pkg);
 	 }
-	 
+
 	 /* If this or element did not match then continue on to the
-	    next or element until a matching element is found*/
+	    next or element until a matching element is found */
 	 if (Bad == true)
-	 {	    
+	 {
+	    // This triggers if someone make a pre-depends/depend loop.
 	    if (Start == End)
-	       return _error->Error("Internal Error, Couldn't configure a pre-depend");
+	       return _error->Error("Couldn't configure pre-depend %s for %s, "
+				    "probably a dependency cycle.",
+				    End.TargetPkg().Name(),Pkg.Name());
 	    Start++;
 	 }
 	 else