From: David Kalnischkies <kalnischkies@gmail.com>
Date: Sat, 16 Apr 2011 16:11:47 +0000 (+0200)
Subject: cppcheck: (style) Variable 'State' is assigned a value that is never used
X-Git-Tag: 0.8.15~14^2~30
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/0284eee4a02e9cad0932b1058eec9dde6cf8c682?ds=inline;hp=-c

cppcheck: (style) Variable 'State' is assigned a value that is never used
---

0284eee4a02e9cad0932b1058eec9dde6cf8c682
diff --git a/apt-pkg/algorithms.cc b/apt-pkg/algorithms.cc
index 0b4366e5e..e7703ca93 100644
--- a/apt-pkg/algorithms.cc
+++ b/apt-pkg/algorithms.cc
@@ -647,12 +647,10 @@ bool pkgProblemResolver::DoUpgrade(pkgCache::PkgIterator Pkg)
       // Compute a single dependency element (glob or)
       pkgCache::DepIterator Start = D;
       pkgCache::DepIterator End = D;
-      unsigned char State = 0;
       for (bool LastOR = true; D.end() == false && LastOR == true;)
       {
-	 State |= Cache[D];
 	 LastOR = (D->CompareOp & pkgCache::Dep::Or) == pkgCache::Dep::Or;
-	 D++;
+	 ++D;
 	 if (LastOR == true)
 	    End = D;
       }