X-Git-Url: https://git.saurik.com/apt.git/blobdiff_plain/678bc33eaf95356d1b63090d220b65162478b89a..9b78cda6873104b80ffdbc8b5d3965575ce0a31d:/methods/gzip.cc?ds=sidebyside diff --git a/methods/gzip.cc b/methods/gzip.cc index c0092c755..f1c76066e 100644 --- a/methods/gzip.cc +++ b/methods/gzip.cc @@ -1,6 +1,6 @@ // -*- mode: cpp; mode: fold -*- // Description /*{{{*/ -// $Id: gzip.cc,v 1.13 2001/03/11 05:30:20 jgg Exp $ +// $Id: gzip.cc,v 1.17.2.1 2004/01/16 18:58:50 mdz Exp $ /* ###################################################################### GZip method - Take a file URI in and decompress it into the target @@ -20,6 +20,7 @@ #include #include #include +#include /*}}}*/ class GzipMethod : public pkgAcqMethod @@ -34,8 +35,7 @@ class GzipMethod : public pkgAcqMethod // GzipMethod::Fetch - Decompress the passed URI /*{{{*/ // --------------------------------------------------------------------- -/* This forks gzip and hashes the resulting decompressed output as it - flows to the destination file */ +/* */ bool GzipMethod::Fetch(FetchItem *Itm) { URI Get = Itm->Uri; @@ -46,41 +46,18 @@ bool GzipMethod::Fetch(FetchItem *Itm) URIStart(Res); // Open the source and destination files - FileFd From(Path,FileFd::ReadOnly); + FileFd From(Path,FileFd::ReadOnlyGzip); - int GzOut[2]; - if (pipe(GzOut) < 0) - return _error->Errno("pipe","Couldn't open pipe for gzip"); + // FIXME add an error message saying that empty files can't be valid archives + if(From.FileSize() == 0) + return false; - // Fork gzip - int Process = ExecFork(); - if (Process == 0) - { - close(GzOut[0]); - dup2(From.Fd(),STDIN_FILENO); - dup2(GzOut[1],STDOUT_FILENO); - From.Close(); - close(GzOut[1]); - SetCloseExec(STDIN_FILENO,false); - SetCloseExec(STDOUT_FILENO,false); - - const char *Args[3]; - Args[0] = _config->Find("Dir::bin::gzip","gzip").c_str(); - Args[1] = "-d"; - Args[2] = 0; - execvp(Args[0],(char **)Args); - _exit(100); - } - From.Close(); - close(GzOut[1]); - - FileFd FromGz(GzOut[0]); // For autoclose - FileFd To(Itm->DestFile,FileFd::WriteEmpty); + FileFd To(Itm->DestFile,FileFd::WriteAtomic); To.EraseOnFailure(); if (_error->PendingError() == true) return false; - // Read data from gzip, generate checksums and write + // Read data from source, generate checksums and write Hashes Hash; bool Failed = false; while (1) @@ -88,35 +65,23 @@ bool GzipMethod::Fetch(FetchItem *Itm) unsigned char Buffer[4*1024]; unsigned long Count; - Count = read(GzOut[0],Buffer,sizeof(Buffer)); - if (Count < 0 && errno == EINTR) - continue; - - if (Count < 0) + if (!From.Read(Buffer,sizeof(Buffer),&Count)) { - _error->Errno("read", "Read error from gzip process"); - Failed = true; - break; + To.OpFail(); + return false; } - if (Count == 0) break; - + Hash.Add(Buffer,Count); if (To.Write(Buffer,Count) == false) - { + { Failed = true; break; - } + } } - // Wait for gzip to finish - if (ExecWait(Process,_config->Find("Dir::bin::gzip","gzip").c_str(),false) == false) - { - To.OpFail(); - return false; - } - + From.Close(); To.Close(); if (Failed == true) @@ -125,21 +90,21 @@ bool GzipMethod::Fetch(FetchItem *Itm) // Transfer the modification times struct stat Buf; if (stat(Path.c_str(),&Buf) != 0) - return _error->Errno("stat","Failed to stat"); + return _error->Errno("stat",_("Failed to stat")); struct utimbuf TimeBuf; TimeBuf.actime = Buf.st_atime; TimeBuf.modtime = Buf.st_mtime; if (utime(Itm->DestFile.c_str(),&TimeBuf) != 0) - return _error->Errno("utime","Failed to set modification time"); + return _error->Errno("utime",_("Failed to set modification time")); if (stat(Itm->DestFile.c_str(),&Buf) != 0) - return _error->Errno("stat","Failed to stat"); + return _error->Errno("stat",_("Failed to stat")); // Return a Done response Res.LastModified = Buf.st_mtime; Res.Size = Buf.st_size; - Res.MD5Sum = Hash.MD5.Result(); + Res.TakeHashes(Hash); URIDone(Res); @@ -147,8 +112,10 @@ bool GzipMethod::Fetch(FetchItem *Itm) } /*}}}*/ -int main() +int main(int argc, char *argv[]) { + setlocale(LC_ALL, ""); + GzipMethod Mth; return Mth.Run(); }