X-Git-Url: https://git.saurik.com/apple/xnu.git/blobdiff_plain/b226f5e54a60dc81db17b1260381d7dbfea3cdf1..0a7de7458d150b5d4dffc935ba399be265ef0a1a:/bsd/netinet/in_pcb.c diff --git a/bsd/netinet/in_pcb.c b/bsd/netinet/in_pcb.c index 3d2e8c91d..6f2754373 100644 --- a/bsd/netinet/in_pcb.c +++ b/bsd/netinet/in_pcb.c @@ -120,27 +120,27 @@ #include #include -static lck_grp_t *inpcb_lock_grp; -static lck_attr_t *inpcb_lock_attr; -static lck_grp_attr_t *inpcb_lock_grp_attr; -decl_lck_mtx_data(static, inpcb_lock); /* global INPCB lock */ +static lck_grp_t *inpcb_lock_grp; +static lck_attr_t *inpcb_lock_attr; +static lck_grp_attr_t *inpcb_lock_grp_attr; +decl_lck_mtx_data(static, inpcb_lock); /* global INPCB lock */ decl_lck_mtx_data(static, inpcb_timeout_lock); static TAILQ_HEAD(, inpcbinfo) inpcb_head = TAILQ_HEAD_INITIALIZER(inpcb_head); -static u_int16_t inpcb_timeout_run = 0; /* INPCB timer is scheduled to run */ +static u_int16_t inpcb_timeout_run = 0; /* INPCB timer is scheduled to run */ static boolean_t inpcb_garbage_collecting = FALSE; /* gc timer is scheduled */ -static boolean_t inpcb_ticking = FALSE; /* "slow" timer is scheduled */ +static boolean_t inpcb_ticking = FALSE; /* "slow" timer is scheduled */ static boolean_t inpcb_fast_timer_on = FALSE; -#define INPCB_GCREQ_THRESHOLD 50000 +#define INPCB_GCREQ_THRESHOLD 50000 static thread_call_t inpcb_thread_call, inpcb_fast_thread_call; static void inpcb_sched_timeout(void); static void inpcb_sched_lazy_timeout(void); static void _inpcb_sched_timeout(unsigned int); static void inpcb_timeout(void *, void *); -const int inpcb_timeout_lazy = 10; /* 10 seconds leeway for lazy timers */ +const int inpcb_timeout_lazy = 10; /* 10 seconds leeway for lazy timers */ extern int tvtohz(struct timeval *); #if CONFIG_PROC_UUID_POLICY @@ -150,21 +150,21 @@ static void inp_update_necp_want_app_policy(struct inpcb *, boolean_t); #endif /* NECP */ #endif /* !CONFIG_PROC_UUID_POLICY */ -#define DBG_FNC_PCB_LOOKUP NETDBG_CODE(DBG_NETTCP, (6 << 8)) -#define DBG_FNC_PCB_HLOOKUP NETDBG_CODE(DBG_NETTCP, ((6 << 8) | 1)) +#define DBG_FNC_PCB_LOOKUP NETDBG_CODE(DBG_NETTCP, (6 << 8)) +#define DBG_FNC_PCB_HLOOKUP NETDBG_CODE(DBG_NETTCP, ((6 << 8) | 1)) /* * These configure the range of local port addresses assigned to * "unspecified" outgoing connections/packets/whatever. */ -int ipport_lowfirstauto = IPPORT_RESERVED - 1; /* 1023 */ -int ipport_lowlastauto = IPPORT_RESERVEDSTART; /* 600 */ -int ipport_firstauto = IPPORT_HIFIRSTAUTO; /* 49152 */ -int ipport_lastauto = IPPORT_HILASTAUTO; /* 65535 */ -int ipport_hifirstauto = IPPORT_HIFIRSTAUTO; /* 49152 */ -int ipport_hilastauto = IPPORT_HILASTAUTO; /* 65535 */ - -#define RANGECHK(var, min, max) \ +int ipport_lowfirstauto = IPPORT_RESERVED - 1; /* 1023 */ +int ipport_lowlastauto = IPPORT_RESERVEDSTART; /* 600 */ +int ipport_firstauto = IPPORT_HIFIRSTAUTO; /* 49152 */ +int ipport_lastauto = IPPORT_HILASTAUTO; /* 65535 */ +int ipport_hifirstauto = IPPORT_HIFIRSTAUTO; /* 49152 */ +int ipport_hilastauto = IPPORT_HILASTAUTO; /* 65535 */ + +#define RANGECHK(var, min, max) \ if ((var) < (min)) { (var) = (min); } \ else if ((var) > (max)) { (var) = (max); } @@ -183,32 +183,32 @@ sysctl_net_ipport_check SYSCTL_HANDLER_ARGS RANGECHK(ipport_hifirstauto, IPPORT_RESERVED, USHRT_MAX); RANGECHK(ipport_hilastauto, IPPORT_RESERVED, USHRT_MAX); } - return (error); + return error; } #undef RANGECHK SYSCTL_NODE(_net_inet_ip, IPPROTO_IP, portrange, - CTLFLAG_RW|CTLFLAG_LOCKED, 0, "IP Ports"); + CTLFLAG_RW | CTLFLAG_LOCKED, 0, "IP Ports"); SYSCTL_PROC(_net_inet_ip_portrange, OID_AUTO, lowfirst, - CTLTYPE_INT|CTLFLAG_RW | CTLFLAG_LOCKED, - &ipport_lowfirstauto, 0, &sysctl_net_ipport_check, "I", ""); + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_LOCKED, + &ipport_lowfirstauto, 0, &sysctl_net_ipport_check, "I", ""); SYSCTL_PROC(_net_inet_ip_portrange, OID_AUTO, lowlast, - CTLTYPE_INT|CTLFLAG_RW | CTLFLAG_LOCKED, - &ipport_lowlastauto, 0, &sysctl_net_ipport_check, "I", ""); + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_LOCKED, + &ipport_lowlastauto, 0, &sysctl_net_ipport_check, "I", ""); SYSCTL_PROC(_net_inet_ip_portrange, OID_AUTO, first, - CTLTYPE_INT|CTLFLAG_RW | CTLFLAG_LOCKED, - &ipport_firstauto, 0, &sysctl_net_ipport_check, "I", ""); + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_LOCKED, + &ipport_firstauto, 0, &sysctl_net_ipport_check, "I", ""); SYSCTL_PROC(_net_inet_ip_portrange, OID_AUTO, last, - CTLTYPE_INT|CTLFLAG_RW | CTLFLAG_LOCKED, - &ipport_lastauto, 0, &sysctl_net_ipport_check, "I", ""); + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_LOCKED, + &ipport_lastauto, 0, &sysctl_net_ipport_check, "I", ""); SYSCTL_PROC(_net_inet_ip_portrange, OID_AUTO, hifirst, - CTLTYPE_INT|CTLFLAG_RW | CTLFLAG_LOCKED, - &ipport_hifirstauto, 0, &sysctl_net_ipport_check, "I", ""); + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_LOCKED, + &ipport_hifirstauto, 0, &sysctl_net_ipport_check, "I", ""); SYSCTL_PROC(_net_inet_ip_portrange, OID_AUTO, hilast, - CTLTYPE_INT|CTLFLAG_RW | CTLFLAG_LOCKED, - &ipport_hilastauto, 0, &sysctl_net_ipport_check, "I", ""); + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_LOCKED, + &ipport_hilastauto, 0, &sysctl_net_ipport_check, "I", ""); static uint32_t apn_fallbk_debug = 0; #define apn_fallbk_log(x) do { if (apn_fallbk_debug >= 1) log x; } while (0) @@ -217,7 +217,7 @@ static uint32_t apn_fallbk_debug = 0; static boolean_t apn_fallbk_enabled = TRUE; SYSCTL_DECL(_net_inet); -SYSCTL_NODE(_net_inet, OID_AUTO, apn_fallback, CTLFLAG_RW|CTLFLAG_LOCKED, 0, "APN Fallback"); +SYSCTL_NODE(_net_inet, OID_AUTO, apn_fallback, CTLFLAG_RW | CTLFLAG_LOCKED, 0, "APN Fallback"); SYSCTL_UINT(_net_inet_apn_fallback, OID_AUTO, enable, CTLFLAG_RW | CTLFLAG_LOCKED, &apn_fallbk_enabled, 0, "APN fallback enable"); SYSCTL_UINT(_net_inet_apn_fallback, OID_AUTO, debug, CTLFLAG_RW | CTLFLAG_LOCKED, @@ -226,29 +226,29 @@ SYSCTL_UINT(_net_inet_apn_fallback, OID_AUTO, debug, CTLFLAG_RW | CTLFLAG_LOCKED static boolean_t apn_fallbk_enabled = FALSE; #endif -extern int udp_use_randomport; -extern int tcp_use_randomport; +extern int udp_use_randomport; +extern int tcp_use_randomport; /* Structs used for flowhash computation */ struct inp_flowhash_key_addr { union { - struct in_addr v4; + struct in_addr v4; struct in6_addr v6; - u_int8_t addr8[16]; - u_int16_t addr16[8]; - u_int32_t addr32[4]; + u_int8_t addr8[16]; + u_int16_t addr16[8]; + u_int32_t addr32[4]; } infha; }; struct inp_flowhash_key { - struct inp_flowhash_key_addr infh_laddr; - struct inp_flowhash_key_addr infh_faddr; - u_int32_t infh_lport; - u_int32_t infh_fport; - u_int32_t infh_af; - u_int32_t infh_proto; - u_int32_t infh_rand1; - u_int32_t infh_rand2; + struct inp_flowhash_key_addr infh_laddr; + struct inp_flowhash_key_addr infh_faddr; + u_int32_t infh_lport; + u_int32_t infh_fport; + u_int32_t infh_af; + u_int32_t infh_proto; + u_int32_t infh_rand1; + u_int32_t infh_rand2; }; static u_int32_t inp_hash_seed = 0; @@ -256,8 +256,8 @@ static u_int32_t inp_hash_seed = 0; static int infc_cmp(const struct inpcb *, const struct inpcb *); /* Flags used by inp_fc_getinp */ -#define INPFC_SOLOCKED 0x1 -#define INPFC_REMOVE 0x2 +#define INPFC_SOLOCKED 0x1 +#define INPFC_REMOVE 0x2 static struct inpcb *inp_fc_getinp(u_int32_t, u_int32_t); static void inp_fc_feedback(struct inpcb *); @@ -295,9 +295,10 @@ in_pcbinit(void) inpcb_thread_call = thread_call_allocate_with_priority(inpcb_timeout, NULL, THREAD_CALL_PRIORITY_KERNEL); inpcb_fast_thread_call = thread_call_allocate_with_priority( - inpcb_timeout, NULL, THREAD_CALL_PRIORITY_KERNEL); - if (inpcb_thread_call == NULL || inpcb_fast_thread_call == NULL) + inpcb_timeout, NULL, THREAD_CALL_PRIORITY_KERNEL); + if (inpcb_thread_call == NULL || inpcb_fast_thread_call == NULL) { panic("unable to alloc the inpcb thread call"); + } /* * Initialize data structures required to deliver @@ -310,7 +311,7 @@ in_pcbinit(void) lck_mtx_unlock(&inp_fc_lck); } -#define INPCB_HAVE_TIMER_REQ(req) (((req).intimer_lazy > 0) || \ +#define INPCB_HAVE_TIMER_REQ(req) (((req).intimer_lazy > 0) || \ ((req).intimer_fast > 0) || ((req).intimer_nodelay > 0)) static void inpcb_timeout(void *arg0, void *arg1) @@ -344,7 +345,7 @@ inpcb_timeout(void *arg0, void *arg1) TAILQ_FOREACH(ipi, &inpcb_head, ipi_entry) { if (INPCB_HAVE_TIMER_REQ(ipi->ipi_gc_req)) { bzero(&ipi->ipi_gc_req, - sizeof(ipi->ipi_gc_req)); + sizeof(ipi->ipi_gc_req)); if (gc && ipi->ipi_gc != NULL) { ipi->ipi_gc(ipi); gccnt.intimer_lazy += @@ -357,7 +358,7 @@ inpcb_timeout(void *arg0, void *arg1) } if (INPCB_HAVE_TIMER_REQ(ipi->ipi_timer_req)) { bzero(&ipi->ipi_timer_req, - sizeof(ipi->ipi_timer_req)); + sizeof(ipi->ipi_timer_req)); if (t && ipi->ipi_timer != NULL) { ipi->ipi_timer(ipi); tmcnt.intimer_lazy += @@ -374,22 +375,25 @@ inpcb_timeout(void *arg0, void *arg1) } /* lock was dropped above, so check first before overriding */ - if (!inpcb_garbage_collecting) + if (!inpcb_garbage_collecting) { inpcb_garbage_collecting = INPCB_HAVE_TIMER_REQ(gccnt); - if (!inpcb_ticking) + } + if (!inpcb_ticking) { inpcb_ticking = INPCB_HAVE_TIMER_REQ(tmcnt); + } /* re-arm the timer if there's work to do */ inpcb_timeout_run--; VERIFY(inpcb_timeout_run >= 0 && inpcb_timeout_run < 2); - if (gccnt.intimer_nodelay > 0 || tmcnt.intimer_nodelay > 0) + if (gccnt.intimer_nodelay > 0 || tmcnt.intimer_nodelay > 0) { inpcb_sched_timeout(); - else if ((gccnt.intimer_fast + tmcnt.intimer_fast) <= 5) + } else if ((gccnt.intimer_fast + tmcnt.intimer_fast) <= 5) { /* be lazy when idle with little activity */ inpcb_sched_lazy_timeout(); - else + } else { inpcb_sched_timeout(); + } lck_mtx_unlock(&inpcb_timeout_lock); } @@ -426,8 +430,8 @@ _inpcb_sched_timeout(unsigned int offset) clock_interval_to_absolutetime_interval(offset, NSEC_PER_SEC, &leeway); thread_call_enter_delayed_with_leeway( - inpcb_thread_call, NULL, deadline, leeway, - THREAD_CALL_DELAY_LEEWAY); + inpcb_thread_call, NULL, deadline, leeway, + THREAD_CALL_DELAY_LEEWAY); } } else if (inpcb_timeout_run == 1 && offset == 0 && !inpcb_fast_timer_on) { @@ -451,7 +455,7 @@ inpcb_gc_sched(struct inpcbinfo *ipi, u_int32_t type) lck_mtx_lock_spin(&inpcb_timeout_lock); inpcb_garbage_collecting = TRUE; gccnt = ipi->ipi_gc_req.intimer_nodelay + - ipi->ipi_gc_req.intimer_fast; + ipi->ipi_gc_req.intimer_fast; if (gccnt > INPCB_GCREQ_THRESHOLD) { type = INPCB_TIMER_FAST; @@ -477,7 +481,6 @@ inpcb_gc_sched(struct inpcbinfo *ipi, u_int32_t type) void inpcb_timer_sched(struct inpcbinfo *ipi, u_int32_t type) { - lck_mtx_lock_spin(&inpcb_timeout_lock); inpcb_ticking = TRUE; switch (type) { @@ -522,16 +525,18 @@ in_pcbinfo_detach(struct inpcbinfo *ipi) lck_mtx_lock(&inpcb_lock); TAILQ_FOREACH(ipi0, &inpcb_head, ipi_entry) { - if (ipi0 == ipi) + if (ipi0 == ipi) { break; + } } - if (ipi0 != NULL) + if (ipi0 != NULL) { TAILQ_REMOVE(&inpcb_head, ipi0, ipi_entry); - else + } else { error = ENXIO; + } lck_mtx_unlock(&inpcb_lock); - return (error); + return error; } /* @@ -546,20 +551,21 @@ in_pcballoc(struct socket *so, struct inpcbinfo *pcbinfo, struct proc *p) { #pragma unused(p) struct inpcb *inp; - caddr_t temp; + caddr_t temp; #if CONFIG_MACF_NET int mac_error; #endif /* CONFIG_MACF_NET */ if ((so->so_flags1 & SOF1_CACHED_IN_SOCK_LAYER) == 0) { inp = (struct inpcb *)zalloc(pcbinfo->ipi_zone); - if (inp == NULL) - return (ENOBUFS); - bzero((caddr_t)inp, sizeof (*inp)); + if (inp == NULL) { + return ENOBUFS; + } + bzero((caddr_t)inp, sizeof(*inp)); } else { inp = (struct inpcb *)(void *)so->so_saved_pcb; temp = inp->inp_saved_ppcb; - bzero((caddr_t)inp, sizeof (*inp)); + bzero((caddr_t)inp, sizeof(*inp)); inp->inp_saved_ppcb = temp; } @@ -569,44 +575,45 @@ in_pcballoc(struct socket *so, struct inpcbinfo *pcbinfo, struct proc *p) #if CONFIG_MACF_NET mac_error = mac_inpcb_label_init(inp, M_WAITOK); if (mac_error != 0) { - if ((so->so_flags1 & SOF1_CACHED_IN_SOCK_LAYER) == 0) + if ((so->so_flags1 & SOF1_CACHED_IN_SOCK_LAYER) == 0) { zfree(pcbinfo->ipi_zone, inp); - return (mac_error); + } + return mac_error; } mac_inpcb_label_associate(so, inp); #endif /* CONFIG_MACF_NET */ /* make sure inp_stat is always 64-bit aligned */ inp->inp_stat = (struct inp_stat *)P2ROUNDUP(inp->inp_stat_store, - sizeof (u_int64_t)); + sizeof(u_int64_t)); if (((uintptr_t)inp->inp_stat - (uintptr_t)inp->inp_stat_store) + - sizeof (*inp->inp_stat) > sizeof (inp->inp_stat_store)) { + sizeof(*inp->inp_stat) > sizeof(inp->inp_stat_store)) { panic("%s: insufficient space to align inp_stat", __func__); /* NOTREACHED */ } /* make sure inp_cstat is always 64-bit aligned */ inp->inp_cstat = (struct inp_stat *)P2ROUNDUP(inp->inp_cstat_store, - sizeof (u_int64_t)); + sizeof(u_int64_t)); if (((uintptr_t)inp->inp_cstat - (uintptr_t)inp->inp_cstat_store) + - sizeof (*inp->inp_cstat) > sizeof (inp->inp_cstat_store)) { + sizeof(*inp->inp_cstat) > sizeof(inp->inp_cstat_store)) { panic("%s: insufficient space to align inp_cstat", __func__); /* NOTREACHED */ } /* make sure inp_wstat is always 64-bit aligned */ inp->inp_wstat = (struct inp_stat *)P2ROUNDUP(inp->inp_wstat_store, - sizeof (u_int64_t)); + sizeof(u_int64_t)); if (((uintptr_t)inp->inp_wstat - (uintptr_t)inp->inp_wstat_store) + - sizeof (*inp->inp_wstat) > sizeof (inp->inp_wstat_store)) { + sizeof(*inp->inp_wstat) > sizeof(inp->inp_wstat_store)) { panic("%s: insufficient space to align inp_wstat", __func__); /* NOTREACHED */ } /* make sure inp_Wstat is always 64-bit aligned */ inp->inp_Wstat = (struct inp_stat *)P2ROUNDUP(inp->inp_Wstat_store, - sizeof (u_int64_t)); + sizeof(u_int64_t)); if (((uintptr_t)inp->inp_Wstat - (uintptr_t)inp->inp_Wstat_store) + - sizeof (*inp->inp_Wstat) > sizeof (inp->inp_Wstat_store)) { + sizeof(*inp->inp_Wstat) > sizeof(inp->inp_Wstat_store)) { panic("%s: insufficient space to align inp_Wstat", __func__); /* NOTREACHED */ } @@ -619,14 +626,17 @@ in_pcballoc(struct socket *so, struct inpcbinfo *pcbinfo, struct proc *p) } #if INET6 - if (SOCK_DOM(so) == PF_INET6 && !ip6_mapped_addr_on) + if (SOCK_DOM(so) == PF_INET6 && !ip6_mapped_addr_on) { inp->inp_flags |= IN6P_IPV6_V6ONLY; + } - if (ip6_auto_flowlabel) + if (ip6_auto_flowlabel) { inp->inp_flags |= IN6P_AUTOFLOWLABEL; + } #endif /* INET6 */ - if (intcoproc_unrestricted) + if (intcoproc_unrestricted) { inp->inp_flags2 |= INP2_INTCOPROC_ALLOWED; + } (void) inp_update_policy(inp); @@ -635,7 +645,7 @@ in_pcballoc(struct socket *so, struct inpcbinfo *pcbinfo, struct proc *p) LIST_INSERT_HEAD(pcbinfo->ipi_listhead, inp, inp_list); pcbinfo->ipi_count++; lck_rw_done(pcbinfo->ipi_lock); - return (0); + return 0; } /* @@ -663,16 +673,17 @@ in_pcblookup_local_and_cleanup(struct inpcbinfo *pcbinfo, struct in_addr laddr, socket_lock(so, 0); if (so->so_usecount == 0) { - if (inp->inp_state != INPCB_STATE_DEAD) + if (inp->inp_state != INPCB_STATE_DEAD) { in_pcbdetach(inp); - in_pcbdispose(inp); /* will unlock & destroy */ + } + in_pcbdispose(inp); /* will unlock & destroy */ inp = NULL; } else { socket_unlock(so, 0); } } - return (inp); + return inp; } static void @@ -684,18 +695,18 @@ in_pcb_conflict_post_msg(u_int16_t port) * who has set SOF_NOTIFYCONFLICT owns. */ struct kev_msg ev_msg; - struct kev_in_portinuse in_portinuse; + struct kev_in_portinuse in_portinuse; - bzero(&in_portinuse, sizeof (struct kev_in_portinuse)); - bzero(&ev_msg, sizeof (struct kev_msg)); - in_portinuse.port = ntohs(port); /* port in host order */ + bzero(&in_portinuse, sizeof(struct kev_in_portinuse)); + bzero(&ev_msg, sizeof(struct kev_msg)); + in_portinuse.port = ntohs(port); /* port in host order */ in_portinuse.req_pid = proc_selfpid(); ev_msg.vendor_code = KEV_VENDOR_APPLE; ev_msg.kev_class = KEV_NETWORK_CLASS; ev_msg.kev_subclass = KEV_INET_SUBCLASS; ev_msg.event_code = KEV_INET_PORTINUSE; ev_msg.dv[0].data_ptr = &in_portinuse; - ev_msg.dv[0].data_length = sizeof (struct kev_in_portinuse); + ev_msg.dv[0].data_length = sizeof(struct kev_in_portinuse); ev_msg.dv[1].data_length = 0; dlil_post_complete_msg(NULL, &ev_msg); } @@ -727,10 +738,12 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) struct in_addr laddr; struct ifnet *outif = NULL; - if (TAILQ_EMPTY(&in_ifaddrhead)) /* XXX broken! */ - return (EADDRNOTAVAIL); - if (!(so->so_options & (SO_REUSEADDR|SO_REUSEPORT))) + if (TAILQ_EMPTY(&in_ifaddrhead)) { /* XXX broken! */ + return EADDRNOTAVAIL; + } + if (!(so->so_options & (SO_REUSEADDR | SO_REUSEPORT))) { wild = 1; + } bzero(&laddr, sizeof(laddr)); @@ -740,14 +753,14 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) /* another thread completed the bind */ lck_rw_done(pcbinfo->ipi_lock); socket_lock(so, 0); - return (EINVAL); + return EINVAL; } if (nam != NULL) { - if (nam->sa_len != sizeof (struct sockaddr_in)) { + if (nam->sa_len != sizeof(struct sockaddr_in)) { lck_rw_done(pcbinfo->ipi_lock); socket_lock(so, 0); - return (EINVAL); + return EINVAL; } #if 0 /* @@ -757,7 +770,7 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) if (nam->sa_family != AF_INET) { lck_rw_done(pcbinfo->ipi_lock); socket_lock(so, 0); - return (EAFNOSUPPORT); + return EAFNOSUPPORT; } #endif /* 0 */ lport = SIN(nam)->sin_port; @@ -770,23 +783,24 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) * and a multicast address is bound on both * new and duplicated sockets. */ - if (so->so_options & SO_REUSEADDR) - reuseport = SO_REUSEADDR|SO_REUSEPORT; + if (so->so_options & SO_REUSEADDR) { + reuseport = SO_REUSEADDR | SO_REUSEPORT; + } } else if (SIN(nam)->sin_addr.s_addr != INADDR_ANY) { struct sockaddr_in sin; struct ifaddr *ifa; /* Sanitized for interface address searches */ - bzero(&sin, sizeof (sin)); + bzero(&sin, sizeof(sin)); sin.sin_family = AF_INET; - sin.sin_len = sizeof (struct sockaddr_in); + sin.sin_len = sizeof(struct sockaddr_in); sin.sin_addr.s_addr = SIN(nam)->sin_addr.s_addr; ifa = ifa_ifwithaddr(SA(&sin)); if (ifa == NULL) { lck_rw_done(pcbinfo->ipi_lock); socket_lock(so, 0); - return (EADDRNOTAVAIL); + return EADDRNOTAVAIL; } else { /* * Opportunistically determine the outbound @@ -808,7 +822,7 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) #if !CONFIG_EMBEDDED if (ntohs(lport) < IPPORT_RESERVED && - SIN(nam)->sin_addr.s_addr != 0) { + SIN(nam)->sin_addr.s_addr != 0) { cred = kauth_cred_proc_ref(p); error = priv_check_cred(cred, PRIV_NETINET_RESERVEDPORT, 0); @@ -816,15 +830,15 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) if (error != 0) { lck_rw_done(pcbinfo->ipi_lock); socket_lock(so, 0); - return (EACCES); + return EACCES; } } #endif /* !CONFIG_EMBEDDED */ if (!IN_MULTICAST(ntohl(SIN(nam)->sin_addr.s_addr)) && (u = kauth_cred_getuid(so->so_cred)) != 0 && (t = in_pcblookup_local_and_cleanup( - inp->inp_pcbinfo, SIN(nam)->sin_addr, lport, - INPLOOKUP_WILDCARD)) != NULL && + inp->inp_pcbinfo, SIN(nam)->sin_addr, lport, + INPLOOKUP_WILDCARD)) != NULL && (SIN(nam)->sin_addr.s_addr != INADDR_ANY || t->inp_laddr.s_addr != INADDR_ANY || !(t->inp_socket->so_options & SO_REUSEPORT)) && @@ -834,16 +848,18 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) t->inp_laddr.s_addr != INADDR_ANY)) { if ((t->inp_socket->so_flags & SOF_NOTIFYCONFLICT) && - !(so->so_flags & SOF_NOTIFYCONFLICT)) + !(so->so_flags & SOF_NOTIFYCONFLICT)) { conflict = 1; + } lck_rw_done(pcbinfo->ipi_lock); - if (conflict) + if (conflict) { in_pcb_conflict_post_msg(lport); + } socket_lock(so, 0); - return (EADDRINUSE); + return EADDRINUSE; } t = in_pcblookup_local_and_cleanup(pcbinfo, SIN(nam)->sin_addr, lport, wild); @@ -856,18 +872,19 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) SOCK_DOM(t->inp_socket) != PF_INET6) #endif /* INET6 */ { - if ((t->inp_socket->so_flags & SOF_NOTIFYCONFLICT) && - !(so->so_flags & SOF_NOTIFYCONFLICT)) + !(so->so_flags & SOF_NOTIFYCONFLICT)) { conflict = 1; + } lck_rw_done(pcbinfo->ipi_lock); - if (conflict) + if (conflict) { in_pcb_conflict_post_msg(lport); + } socket_lock(so, 0); - return (EADDRINUSE); + return EADDRINUSE; } } } @@ -888,7 +905,7 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) */ anonport = TRUE; if (inp->inp_flags & INP_HIGHPORT) { - first = ipport_hifirstauto; /* sysctl */ + first = ipport_hifirstauto; /* sysctl */ last = ipport_hilastauto; lastport = &pcbinfo->ipi_lasthi; } else if (inp->inp_flags & INP_LOWPORT) { @@ -899,20 +916,21 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) if (error != 0) { lck_rw_done(pcbinfo->ipi_lock); socket_lock(so, 0); - return (error); + return error; } - first = ipport_lowfirstauto; /* 1023 */ - last = ipport_lowlastauto; /* 600 */ + first = ipport_lowfirstauto; /* 1023 */ + last = ipport_lowlastauto; /* 600 */ lastport = &pcbinfo->ipi_lastlow; } else { - first = ipport_firstauto; /* sysctl */ + first = ipport_firstauto; /* sysctl */ last = ipport_lastauto; lastport = &pcbinfo->ipi_lastport; } /* No point in randomizing if only one port is available */ - if (first == last) + if (first == last) { randomport = 0; + } /* * Simple check to ensure all ports are not used up causing * a deadlock here. @@ -927,7 +945,7 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) * counting down */ if (randomport) { - read_frandom(&rand_port, sizeof (rand_port)); + read_frandom(&rand_port, sizeof(rand_port)); *lastport = first - (rand_port % (first - last)); } @@ -938,14 +956,15 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) found = false; do { - if (count-- < 0) { /* completely used? */ + if (count-- < 0) { /* completely used? */ lck_rw_done(pcbinfo->ipi_lock); socket_lock(so, 0); - return (EADDRNOTAVAIL); + return EADDRNOTAVAIL; } --*lastport; - if (*lastport > first || *lastport < last) + if (*lastport > first || *lastport < last) { *lastport = first; + } lport = htons(*lastport); found = in_pcblookup_local_and_cleanup(pcbinfo, @@ -958,7 +977,7 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) * counting up */ if (randomport) { - read_frandom(&rand_port, sizeof (rand_port)); + read_frandom(&rand_port, sizeof(rand_port)); *lastport = first + (rand_port % (first - last)); } @@ -969,14 +988,15 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) found = false; do { - if (count-- < 0) { /* completely used? */ + if (count-- < 0) { /* completely used? */ lck_rw_done(pcbinfo->ipi_lock); socket_lock(so, 0); - return (EADDRNOTAVAIL); + return EADDRNOTAVAIL; } ++*lastport; - if (*lastport < first || *lastport > last) + if (*lastport < first || *lastport > last) { *lastport = first; + } lport = htons(*lastport); found = in_pcblookup_local_and_cleanup(pcbinfo, @@ -993,12 +1013,12 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) */ if (inp->inp_state == INPCB_STATE_DEAD) { lck_rw_done(pcbinfo->ipi_lock); - return (ECONNABORTED); + return ECONNABORTED; } if (inp->inp_lport != 0 || inp->inp_laddr.s_addr != INADDR_ANY) { lck_rw_done(pcbinfo->ipi_lock); - return (EINVAL); + return EINVAL; } if (laddr.s_addr != INADDR_ANY) { @@ -1006,36 +1026,38 @@ in_pcbbind(struct inpcb *inp, struct sockaddr *nam, struct proc *p) inp->inp_last_outifp = outif; } inp->inp_lport = lport; - if (anonport) + if (anonport) { inp->inp_flags |= INP_ANONPORT; + } if (in_pcbinshash(inp, 1) != 0) { inp->inp_laddr.s_addr = INADDR_ANY; inp->inp_last_outifp = NULL; inp->inp_lport = 0; - if (anonport) + if (anonport) { inp->inp_flags &= ~INP_ANONPORT; + } lck_rw_done(pcbinfo->ipi_lock); - return (EAGAIN); + return EAGAIN; } lck_rw_done(pcbinfo->ipi_lock); sflt_notify(so, sock_evt_bound, NULL); - return (0); + return 0; } -#define APN_FALLBACK_IP_FILTER(a) \ +#define APN_FALLBACK_IP_FILTER(a) \ (IN_LINKLOCAL(ntohl((a)->sin_addr.s_addr)) || \ IN_LOOPBACK(ntohl((a)->sin_addr.s_addr)) || \ IN_ZERONET(ntohl((a)->sin_addr.s_addr)) || \ IN_MULTICAST(ntohl((a)->sin_addr.s_addr)) || \ IN_PRIVATE(ntohl((a)->sin_addr.s_addr))) -#define APN_FALLBACK_NOTIF_INTERVAL 2 /* Magic Number */ +#define APN_FALLBACK_NOTIF_INTERVAL 2 /* Magic Number */ static uint64_t last_apn_fallback = 0; static boolean_t -apn_fallback_required (proc_t proc, struct socket *so, struct sockaddr_in *p_dstv4) +apn_fallback_required(proc_t proc, struct socket *so, struct sockaddr_in *p_dstv4) { uint64_t timenow; struct sockaddr_storage lookup_default_addr; @@ -1043,14 +1065,17 @@ apn_fallback_required (proc_t proc, struct socket *so, struct sockaddr_in *p_dst VERIFY(proc != NULL); - if (apn_fallbk_enabled == FALSE) + if (apn_fallbk_enabled == FALSE) { return FALSE; + } - if (proc == kernproc) + if (proc == kernproc) { return FALSE; + } - if (so && (so->so_options & SO_NOAPNFALLBK)) + if (so && (so->so_options & SO_NOAPNFALLBK)) { return FALSE; + } timenow = net_uptime(); if ((timenow - last_apn_fallback) < APN_FALLBACK_NOTIF_INTERVAL) { @@ -1058,8 +1083,9 @@ apn_fallback_required (proc_t proc, struct socket *so, struct sockaddr_in *p_dst return FALSE; } - if (p_dstv4 && APN_FALLBACK_IP_FILTER(p_dstv4)) + if (p_dstv4 && APN_FALLBACK_IP_FILTER(p_dstv4)) { return FALSE; + } /* Check if we have unscoped IPv6 default route through cellular */ bzero(&lookup_default_addr, sizeof(lookup_default_addr)); @@ -1163,7 +1189,7 @@ apn_fallback_trigger(proc_t proc, struct socket *so) proc_getexecutableuuid(proc, application_uuid, sizeof(application_uuid)); - bzero(&ev_msg, sizeof (struct kev_msg)); + bzero(&ev_msg, sizeof(struct kev_msg)); ev_msg.vendor_code = KEV_VENDOR_APPLE; ev_msg.kev_class = KEV_NETWORK_CLASS; ev_msg.kev_subclass = KEV_NETEVENT_SUBCLASS; @@ -1215,14 +1241,18 @@ in_pcbladdr(struct inpcb *inp, struct sockaddr *nam, struct in_addr *laddr, int error = 0; boolean_t restricted = FALSE; - if (outif != NULL) + if (outif != NULL) { *outif = NULL; - if (nam->sa_len != sizeof (struct sockaddr_in)) - return (EINVAL); - if (SIN(nam)->sin_family != AF_INET) - return (EAFNOSUPPORT); - if (raw == 0 && SIN(nam)->sin_port == 0) - return (EADDRNOTAVAIL); + } + if (nam->sa_len != sizeof(struct sockaddr_in)) { + return EINVAL; + } + if (SIN(nam)->sin_family != AF_INET) { + return EAFNOSUPPORT; + } + if (raw == 0 && SIN(nam)->sin_port == 0) { + return EADDRNOTAVAIL; + } /* * If the destination address is INADDR_ANY, @@ -1254,15 +1284,16 @@ in_pcbladdr(struct inpcb *inp, struct sockaddr *nam, struct in_addr *laddr, if (inp->inp_laddr.s_addr != INADDR_ANY) { VERIFY(ia == NULL); *laddr = inp->inp_laddr; - return (0); + return 0; } /* * If the ifscope is specified by the caller (e.g. IP_PKTINFO) * then it overrides the sticky ifscope set for the socket. */ - if (ifscope == IFSCOPE_NONE && (inp->inp_flags & INP_BOUND_IF)) + if (ifscope == IFSCOPE_NONE && (inp->inp_flags & INP_BOUND_IF)) { ifscope = inp->inp_boundifp->if_index; + } /* * If route is known or can be allocated now, @@ -1270,33 +1301,37 @@ in_pcbladdr(struct inpcb *inp, struct sockaddr *nam, struct in_addr *laddr, * Note that we should check the address family of the cached * destination, in case of sharing the cache with IPv6. */ - if (ro->ro_rt != NULL) + if (ro->ro_rt != NULL) { RT_LOCK_SPIN(ro->ro_rt); + } if (ROUTE_UNUSABLE(ro) || ro->ro_dst.sa_family != AF_INET || SIN(&ro->ro_dst)->sin_addr.s_addr != SIN(nam)->sin_addr.s_addr || (inp->inp_socket->so_options & SO_DONTROUTE)) { - if (ro->ro_rt != NULL) + if (ro->ro_rt != NULL) { RT_UNLOCK(ro->ro_rt); + } ROUTE_RELEASE(ro); } if (!(inp->inp_socket->so_options & SO_DONTROUTE) && (ro->ro_rt == NULL || ro->ro_rt->rt_ifp == NULL)) { - if (ro->ro_rt != NULL) + if (ro->ro_rt != NULL) { RT_UNLOCK(ro->ro_rt); + } ROUTE_RELEASE(ro); /* No route yet, so try to acquire one */ - bzero(&ro->ro_dst, sizeof (struct sockaddr_in)); + bzero(&ro->ro_dst, sizeof(struct sockaddr_in)); ro->ro_dst.sa_family = AF_INET; - ro->ro_dst.sa_len = sizeof (struct sockaddr_in); + ro->ro_dst.sa_len = sizeof(struct sockaddr_in); SIN(&ro->ro_dst)->sin_addr = SIN(nam)->sin_addr; rtalloc_scoped(ro, ifscope); - if (ro->ro_rt != NULL) + if (ro->ro_rt != NULL) { RT_LOCK_SPIN(ro->ro_rt); + } } /* Sanitized local copy for interface address searches */ - bzero(&sin, sizeof (sin)); + bzero(&sin, sizeof(sin)); sin.sin_family = AF_INET; - sin.sin_len = sizeof (struct sockaddr_in); + sin.sin_len = sizeof(struct sockaddr_in); sin.sin_addr.s_addr = SIN(nam)->sin_addr.s_addr; /* * If we did not find (or use) a route, assume dest is reachable @@ -1308,13 +1343,15 @@ in_pcbladdr(struct inpcb *inp, struct sockaddr *nam, struct in_addr *laddr, VERIFY(ia == NULL); ia = ifatoia(ifa_ifwithdstaddr(SA(&sin))); - if (ia == NULL) + if (ia == NULL) { ia = ifatoia(ifa_ifwithnet_scoped(SA(&sin), ifscope)); + } error = ((ia == NULL) ? ENETUNREACH : 0); if (apn_fallback_required(proc, inp->inp_socket, - (void *)nam)) + (void *)nam)) { apn_fallback_trigger(proc, inp->inp_socket); + } goto done; } @@ -1352,8 +1389,9 @@ in_pcbladdr(struct inpcb *inp, struct sockaddr *nam, struct in_addr *laddr, * The reason is that we only want to send notification * if the flow was ever used to send data. */ - if (IS_INTF_CLAT46(ro->ro_rt->rt_ifp)) + if (IS_INTF_CLAT46(ro->ro_rt->rt_ifp)) { inp->inp_flags2 |= INP2_CLAT46_FLOW; + } RT_UNLOCK(ro->ro_rt); error = 0; @@ -1371,15 +1409,18 @@ in_pcbladdr(struct inpcb *inp, struct sockaddr *nam, struct in_addr *laddr, */ VERIFY(ia == NULL); ia = ifatoia(ifa_ifwithdstaddr(SA(&sin))); - if (ia == NULL) + if (ia == NULL) { ia = ifatoia(ifa_ifwithaddr_scoped(SA(&sin), ifscope)); - if (ia == NULL) + } + if (ia == NULL) { ia = ifatoia(ifa_ifwithnet_scoped(SA(&sin), ifscope)); + } if (ia == NULL) { RT_LOCK(ro->ro_rt); ia = ifatoia(ro->ro_rt->rt_ifa); - if (ia != NULL) + if (ia != NULL) { IFA_ADDREF(&ia->ia_ifa); + } RT_UNLOCK(ro->ro_rt); } error = ((ia == NULL) ? ENETUNREACH : 0); @@ -1400,20 +1441,24 @@ done: if (imo->imo_multicast_ifp != NULL && (ia == NULL || ia->ia_ifp != imo->imo_multicast_ifp)) { ifp = imo->imo_multicast_ifp; - if (ia != NULL) + if (ia != NULL) { IFA_REMREF(&ia->ia_ifa); + } lck_rw_lock_shared(in_ifaddr_rwlock); TAILQ_FOREACH(ia, &in_ifaddrhead, ia_link) { - if (ia->ia_ifp == ifp) + if (ia->ia_ifp == ifp) { break; + } } - if (ia != NULL) + if (ia != NULL) { IFA_ADDREF(&ia->ia_ifa); + } lck_rw_done(in_ifaddr_rwlock); - if (ia == NULL) + if (ia == NULL) { error = EADDRNOTAVAIL; - else + } else { error = 0; + } } IMO_UNLOCK(imo); } @@ -1438,16 +1483,18 @@ done: if (outif != NULL) { struct ifnet *ifp; - if (ro->ro_rt != NULL) + if (ro->ro_rt != NULL) { ifp = ro->ro_rt->rt_ifp; - else + } else { ifp = ia->ia_ifp; + } VERIFY(ifp != NULL); IFA_CONVERT_LOCK(&ia->ia_ifa); - ifnet_reference(ifp); /* for caller */ - if (*outif != NULL) + ifnet_reference(ifp); /* for caller */ + if (*outif != NULL) { ifnet_release(*outif); + } *outif = ifp; } IFA_UNLOCK(&ia->ia_ifa); @@ -1463,7 +1510,7 @@ done: SO_FILT_HINT_IFDENIED)); } - return (error); + return error; } /* @@ -1487,15 +1534,17 @@ in_pcbconnect(struct inpcb *inp, struct sockaddr *nam, struct proc *p, struct socket *so = inp->inp_socket; #if CONTENT_FILTER - if (so) + if (so) { so->so_state_change_cnt++; + } #endif /* * Call inner routine, to assign local interface address. */ - if ((error = in_pcbladdr(inp, nam, &laddr, ifscope, outif, 0)) != 0) - return (error); + if ((error = in_pcbladdr(inp, nam, &laddr, ifscope, outif, 0)) != 0) { + return error; + } socket_unlock(so, 0); pcb = in_pcblookup_hash(inp->inp_pcbinfo, sin->sin_addr, sin->sin_port, @@ -1508,18 +1557,20 @@ in_pcbconnect(struct inpcb *inp, struct sockaddr *nam, struct proc *p, * embryonic socket, it can get aborted if another thread is closing * the listener (radar 7947600). */ - if ((so->so_flags & SOF_ABORTED) != 0) - return (ECONNREFUSED); + if ((so->so_flags & SOF_ABORTED) != 0) { + return ECONNREFUSED; + } if (pcb != NULL) { in_pcb_checkstate(pcb, WNT_RELEASE, pcb == inp ? 1 : 0); - return (EADDRINUSE); + return EADDRINUSE; } if (inp->inp_laddr.s_addr == INADDR_ANY) { if (inp->inp_lport == 0) { error = in_pcbbind(inp, NULL, p); - if (error) - return (error); + if (error) { + return error; + } } if (!lck_rw_try_lock_exclusive(inp->inp_pcbinfo->ipi_lock)) { /* @@ -1543,8 +1594,9 @@ in_pcbconnect(struct inpcb *inp, struct sockaddr *nam, struct proc *p, * This routines can be refactored and handle this better * in future. */ - if (inp->inp_lport == 0) - return (EINVAL); + if (inp->inp_lport == 0) { + return EINVAL; + } if (!lck_rw_try_lock_exclusive(inp->inp_pcbinfo->ipi_lock)) { /* * Lock inversion issue, mostly with udp @@ -1557,11 +1609,12 @@ in_pcbconnect(struct inpcb *inp, struct sockaddr *nam, struct proc *p, } inp->inp_faddr = sin->sin_addr; inp->inp_fport = sin->sin_port; - if (nstat_collect && SOCK_PROTO(so) == IPPROTO_UDP) + if (nstat_collect && SOCK_PROTO(so) == IPPROTO_UDP) { nstat_pcb_invalidate_cache(inp); + } in_pcbrehash(inp); lck_rw_done(inp->inp_pcbinfo->ipi_lock); - return (0); + return 0; } void @@ -1569,15 +1622,17 @@ in_pcbdisconnect(struct inpcb *inp) { struct socket *so = inp->inp_socket; - if (nstat_collect && SOCK_PROTO(so) == IPPROTO_UDP) + if (nstat_collect && SOCK_PROTO(so) == IPPROTO_UDP) { nstat_pcb_cache(inp); + } inp->inp_faddr.s_addr = INADDR_ANY; inp->inp_fport = 0; #if CONTENT_FILTER - if (so) + if (so) { so->so_state_change_cnt++; + } #endif if (!lck_rw_try_lock_exclusive(inp->inp_pcbinfo->ipi_lock)) { @@ -1594,8 +1649,9 @@ in_pcbdisconnect(struct inpcb *inp) * so check for SOF_MP_SUBFLOW socket flag before detaching the PCB; * when the socket is closed for real, SOF_MP_SUBFLOW would be cleared. */ - if (!(so->so_flags & SOF_MP_SUBFLOW) && (so->so_state & SS_NOFDREF)) + if (!(so->so_flags & SOF_MP_SUBFLOW) && (so->so_state & SS_NOFDREF)) { in_pcbdetach(inp); + } } void @@ -1627,8 +1683,9 @@ in_pcbdetach(struct inpcb *inp) * before we detach it. */ if (nstat_collect && - (SOCK_PROTO(so) == IPPROTO_TCP || SOCK_PROTO(so) == IPPROTO_UDP)) + (SOCK_PROTO(so) == IPPROTO_TCP || SOCK_PROTO(so) == IPPROTO_UDP)) { nstat_pcb_detach(inp); + } /* Free memory buffer held for generating keep alives */ if (inp->inp_keepalive_data != NULL) { @@ -1670,17 +1727,17 @@ in_pcbdetach(struct inpcb *inp) */ if (inp->inp_stat != NULL && (inp->inp_stat->txbytes != 0 || - inp->inp_stat->rxbytes !=0)) { + inp->inp_stat->rxbytes != 0)) { if (so->so_flags & SOF_DELEGATED) { in6_clat46_event_enqueue_nwk_wq_entry( - IN6_CLAT46_EVENT_V4_FLOW, - so->e_pid, - so->e_uuid); + IN6_CLAT46_EVENT_V4_FLOW, + so->e_pid, + so->e_uuid); } else { in6_clat46_event_enqueue_nwk_wq_entry( - IN6_CLAT46_EVENT_V4_FLOW, - so->last_pid, - so->last_uuid); + IN6_CLAT46_EVENT_V4_FLOW, + so->last_pid, + so->last_uuid); } } } @@ -1798,22 +1855,23 @@ in_getsockaddr(struct socket *so, struct sockaddr **nam) /* * Do the malloc first in case it blocks. */ - MALLOC(sin, struct sockaddr_in *, sizeof (*sin), M_SONAME, M_WAITOK); - if (sin == NULL) - return (ENOBUFS); - bzero(sin, sizeof (*sin)); + MALLOC(sin, struct sockaddr_in *, sizeof(*sin), M_SONAME, M_WAITOK); + if (sin == NULL) { + return ENOBUFS; + } + bzero(sin, sizeof(*sin)); sin->sin_family = AF_INET; - sin->sin_len = sizeof (*sin); + sin->sin_len = sizeof(*sin); if ((inp = sotoinpcb(so)) == NULL) { FREE(sin, M_SONAME); - return (EINVAL); + return EINVAL; } sin->sin_port = inp->inp_lport; sin->sin_addr = inp->inp_laddr; *nam = (struct sockaddr *)sin; - return (0); + return 0; } int @@ -1823,17 +1881,18 @@ in_getsockaddr_s(struct socket *so, struct sockaddr_in *ss) struct inpcb *inp; VERIFY(ss != NULL); - bzero(ss, sizeof (*ss)); + bzero(ss, sizeof(*ss)); sin->sin_family = AF_INET; - sin->sin_len = sizeof (*sin); + sin->sin_len = sizeof(*sin); - if ((inp = sotoinpcb(so)) == NULL) - return (EINVAL); + if ((inp = sotoinpcb(so)) == NULL) { + return EINVAL; + } sin->sin_port = inp->inp_lport; sin->sin_addr = inp->inp_laddr; - return (0); + return 0; } int @@ -1845,22 +1904,23 @@ in_getpeeraddr(struct socket *so, struct sockaddr **nam) /* * Do the malloc first in case it blocks. */ - MALLOC(sin, struct sockaddr_in *, sizeof (*sin), M_SONAME, M_WAITOK); - if (sin == NULL) - return (ENOBUFS); - bzero((caddr_t)sin, sizeof (*sin)); + MALLOC(sin, struct sockaddr_in *, sizeof(*sin), M_SONAME, M_WAITOK); + if (sin == NULL) { + return ENOBUFS; + } + bzero((caddr_t)sin, sizeof(*sin)); sin->sin_family = AF_INET; - sin->sin_len = sizeof (*sin); + sin->sin_len = sizeof(*sin); if ((inp = sotoinpcb(so)) == NULL) { FREE(sin, M_SONAME); - return (EINVAL); + return EINVAL; } sin->sin_port = inp->inp_fport; sin->sin_addr = inp->inp_faddr; *nam = (struct sockaddr *)sin; - return (0); + return 0; } void @@ -1873,14 +1933,17 @@ in_pcbnotifyall(struct inpcbinfo *pcbinfo, struct in_addr faddr, LIST_FOREACH(inp, pcbinfo->ipi_listhead, inp_list) { #if INET6 - if (!(inp->inp_vflag & INP_IPV4)) + if (!(inp->inp_vflag & INP_IPV4)) { continue; + } #endif /* INET6 */ if (inp->inp_faddr.s_addr != faddr.s_addr || - inp->inp_socket == NULL) + inp->inp_socket == NULL) { continue; - if (in_pcb_checkstate(inp, WNT_ACQUIRE, 0) == WNT_STOPUSING) + } + if (in_pcb_checkstate(inp, WNT_ACQUIRE, 0) == WNT_STOPUSING) { continue; + } socket_lock(inp->inp_socket, 1); (*notify)(inp, errno); (void) in_pcb_checkstate(inp, WNT_RELEASE, 1); @@ -1927,11 +1990,13 @@ in_losing(struct inpcb *inp) */ release = TRUE; } - if (ia != NULL) + if (ia != NULL) { IFA_REMREF(&ia->ia_ifa); + } } - if (rt == NULL || release) + if (rt == NULL || release) { ROUTE_RELEASE(&inp->inp_route); + } } /* @@ -1957,11 +2022,13 @@ in_rtchange(struct inpcb *inp, int errno) */ release = TRUE; } - if (ia != NULL) + if (ia != NULL) { IFA_REMREF(&ia->ia_ifa); + } } - if (rt == NULL || release) + if (rt == NULL || release) { ROUTE_RELEASE(&inp->inp_route); + } } /* @@ -1987,8 +2054,9 @@ in_pcblookup_local(struct inpcbinfo *pcbinfo, struct in_addr laddr, pcbinfo->ipi_hashmask)]; LIST_FOREACH(inp, head, inp_hash) { #if INET6 - if (!(inp->inp_vflag & INP_IPV4)) + if (!(inp->inp_vflag & INP_IPV4)) { continue; + } #endif /* INET6 */ if (inp->inp_faddr.s_addr == INADDR_ANY && inp->inp_laddr.s_addr == laddr.s_addr && @@ -1996,14 +2064,14 @@ in_pcblookup_local(struct inpcbinfo *pcbinfo, struct in_addr laddr, /* * Found. */ - return (inp); + return inp; } } /* * Not found. */ KERNEL_DEBUG(DBG_FNC_PCB_LOOKUP | DBG_FUNC_END, 0, 0, 0, 0, 0); - return (NULL); + return NULL; } else { struct inpcbporthead *porthash; struct inpcbport *phd; @@ -2017,8 +2085,9 @@ in_pcblookup_local(struct inpcbinfo *pcbinfo, struct in_addr laddr, porthash = &pcbinfo->ipi_porthashbase[INP_PCBPORTHASH(lport, pcbinfo->ipi_porthashmask)]; LIST_FOREACH(phd, porthash, phd_hash) { - if (phd->phd_port == lport) + if (phd->phd_port == lport) { break; + } } if (phd != NULL) { /* @@ -2028,20 +2097,24 @@ in_pcblookup_local(struct inpcbinfo *pcbinfo, struct in_addr laddr, LIST_FOREACH(inp, &phd->phd_pcblist, inp_portlist) { wildcard = 0; #if INET6 - if (!(inp->inp_vflag & INP_IPV4)) + if (!(inp->inp_vflag & INP_IPV4)) { continue; + } #endif /* INET6 */ - if (inp->inp_faddr.s_addr != INADDR_ANY) + if (inp->inp_faddr.s_addr != INADDR_ANY) { wildcard++; + } if (inp->inp_laddr.s_addr != INADDR_ANY) { - if (laddr.s_addr == INADDR_ANY) + if (laddr.s_addr == INADDR_ANY) { wildcard++; - else if (inp->inp_laddr.s_addr != - laddr.s_addr) + } else if (inp->inp_laddr.s_addr != + laddr.s_addr) { continue; + } } else { - if (laddr.s_addr != INADDR_ANY) + if (laddr.s_addr != INADDR_ANY) { wildcard++; + } } if (wildcard < matchwild) { match = inp; @@ -2054,7 +2127,7 @@ in_pcblookup_local(struct inpcbinfo *pcbinfo, struct in_addr laddr, } KERNEL_DEBUG(DBG_FNC_PCB_LOOKUP | DBG_FUNC_END, match, 0, 0, 0, 0); - return (match); + return match; } } @@ -2091,11 +2164,13 @@ in_pcblookup_hash_exists(struct inpcbinfo *pcbinfo, struct in_addr faddr, pcbinfo->ipi_hashmask)]; LIST_FOREACH(inp, head, inp_hash) { #if INET6 - if (!(inp->inp_vflag & INP_IPV4)) + if (!(inp->inp_vflag & INP_IPV4)) { continue; + } #endif /* INET6 */ - if (inp_restricted_recv(inp, ifp)) + if (inp_restricted_recv(inp, ifp)) { continue; + } if (inp->inp_faddr.s_addr == faddr.s_addr && inp->inp_laddr.s_addr == laddr.s_addr && @@ -2106,12 +2181,12 @@ in_pcblookup_hash_exists(struct inpcbinfo *pcbinfo, struct in_addr faddr, * Found. */ *uid = kauth_cred_getuid( - inp->inp_socket->so_cred); + inp->inp_socket->so_cred); *gid = kauth_cred_getgid( - inp->inp_socket->so_cred); + inp->inp_socket->so_cred); } lck_rw_done(pcbinfo->ipi_lock); - return (found); + return found; } } @@ -2120,38 +2195,40 @@ in_pcblookup_hash_exists(struct inpcbinfo *pcbinfo, struct in_addr faddr, * Not found. */ lck_rw_done(pcbinfo->ipi_lock); - return (0); + return 0; } head = &pcbinfo->ipi_hashbase[INP_PCBHASH(INADDR_ANY, lport, 0, pcbinfo->ipi_hashmask)]; LIST_FOREACH(inp, head, inp_hash) { #if INET6 - if (!(inp->inp_vflag & INP_IPV4)) + if (!(inp->inp_vflag & INP_IPV4)) { continue; + } #endif /* INET6 */ - if (inp_restricted_recv(inp, ifp)) + if (inp_restricted_recv(inp, ifp)) { continue; + } if (inp->inp_faddr.s_addr == INADDR_ANY && inp->inp_lport == lport) { if (inp->inp_laddr.s_addr == laddr.s_addr) { if ((found = (inp->inp_socket != NULL))) { *uid = kauth_cred_getuid( - inp->inp_socket->so_cred); + inp->inp_socket->so_cred); *gid = kauth_cred_getgid( - inp->inp_socket->so_cred); + inp->inp_socket->so_cred); } lck_rw_done(pcbinfo->ipi_lock); - return (found); + return found; } else if (inp->inp_laddr.s_addr == INADDR_ANY) { #if INET6 if (inp->inp_socket && - SOCK_CHECK_DOM(inp->inp_socket, PF_INET6)) + SOCK_CHECK_DOM(inp->inp_socket, PF_INET6)) { local_wild_mapped = inp; - else + } else #endif /* INET6 */ - local_wild = inp; + local_wild = inp; } } } @@ -2160,25 +2237,25 @@ in_pcblookup_hash_exists(struct inpcbinfo *pcbinfo, struct in_addr faddr, if (local_wild_mapped != NULL) { if ((found = (local_wild_mapped->inp_socket != NULL))) { *uid = kauth_cred_getuid( - local_wild_mapped->inp_socket->so_cred); + local_wild_mapped->inp_socket->so_cred); *gid = kauth_cred_getgid( - local_wild_mapped->inp_socket->so_cred); + local_wild_mapped->inp_socket->so_cred); } lck_rw_done(pcbinfo->ipi_lock); - return (found); + return found; } #endif /* INET6 */ lck_rw_done(pcbinfo->ipi_lock); - return (0); + return 0; } if ((found = (local_wild->inp_socket != NULL))) { *uid = kauth_cred_getuid( - local_wild->inp_socket->so_cred); + local_wild->inp_socket->so_cred); *gid = kauth_cred_getgid( - local_wild->inp_socket->so_cred); + local_wild->inp_socket->so_cred); } lck_rw_done(pcbinfo->ipi_lock); - return (found); + return found; } /* @@ -2210,11 +2287,13 @@ in_pcblookup_hash(struct inpcbinfo *pcbinfo, struct in_addr faddr, pcbinfo->ipi_hashmask)]; LIST_FOREACH(inp, head, inp_hash) { #if INET6 - if (!(inp->inp_vflag & INP_IPV4)) + if (!(inp->inp_vflag & INP_IPV4)) { continue; + } #endif /* INET6 */ - if (inp_restricted_recv(inp, ifp)) + if (inp_restricted_recv(inp, ifp)) { continue; + } if (inp->inp_faddr.s_addr == faddr.s_addr && inp->inp_laddr.s_addr == laddr.s_addr && @@ -2226,11 +2305,11 @@ in_pcblookup_hash(struct inpcbinfo *pcbinfo, struct in_addr faddr, if (in_pcb_checkstate(inp, WNT_ACQUIRE, 0) != WNT_STOPUSING) { lck_rw_done(pcbinfo->ipi_lock); - return (inp); + return inp; } else { /* it's there but dead, say it isn't found */ lck_rw_done(pcbinfo->ipi_lock); - return (NULL); + return NULL; } } } @@ -2240,18 +2319,20 @@ in_pcblookup_hash(struct inpcbinfo *pcbinfo, struct in_addr faddr, * Not found. */ lck_rw_done(pcbinfo->ipi_lock); - return (NULL); + return NULL; } head = &pcbinfo->ipi_hashbase[INP_PCBHASH(INADDR_ANY, lport, 0, pcbinfo->ipi_hashmask)]; LIST_FOREACH(inp, head, inp_hash) { #if INET6 - if (!(inp->inp_vflag & INP_IPV4)) + if (!(inp->inp_vflag & INP_IPV4)) { continue; + } #endif /* INET6 */ - if (inp_restricted_recv(inp, ifp)) + if (inp_restricted_recv(inp, ifp)) { continue; + } if (inp->inp_faddr.s_addr == INADDR_ANY && inp->inp_lport == lport) { @@ -2259,19 +2340,19 @@ in_pcblookup_hash(struct inpcbinfo *pcbinfo, struct in_addr faddr, if (in_pcb_checkstate(inp, WNT_ACQUIRE, 0) != WNT_STOPUSING) { lck_rw_done(pcbinfo->ipi_lock); - return (inp); + return inp; } else { /* it's dead; say it isn't found */ lck_rw_done(pcbinfo->ipi_lock); - return (NULL); + return NULL; } } else if (inp->inp_laddr.s_addr == INADDR_ANY) { #if INET6 - if (SOCK_CHECK_DOM(inp->inp_socket, PF_INET6)) + if (SOCK_CHECK_DOM(inp->inp_socket, PF_INET6)) { local_wild_mapped = inp; - else + } else #endif /* INET6 */ - local_wild = inp; + local_wild = inp; } } } @@ -2281,26 +2362,26 @@ in_pcblookup_hash(struct inpcbinfo *pcbinfo, struct in_addr faddr, if (in_pcb_checkstate(local_wild_mapped, WNT_ACQUIRE, 0) != WNT_STOPUSING) { lck_rw_done(pcbinfo->ipi_lock); - return (local_wild_mapped); + return local_wild_mapped; } else { /* it's dead; say it isn't found */ lck_rw_done(pcbinfo->ipi_lock); - return (NULL); + return NULL; } } #endif /* INET6 */ lck_rw_done(pcbinfo->ipi_lock); - return (NULL); + return NULL; } if (in_pcb_checkstate(local_wild, WNT_ACQUIRE, 0) != WNT_STOPUSING) { lck_rw_done(pcbinfo->ipi_lock); - return (local_wild); + return local_wild; } /* * It's either not found or is already dead. */ lck_rw_done(pcbinfo->ipi_lock); - return (NULL); + return NULL; } /* @@ -2308,7 +2389,7 @@ in_pcblookup_hash(struct inpcbinfo *pcbinfo, struct in_addr faddr, * * @param inp Pointer to internet protocol control block * @param locked Implies if ipi_lock (protecting pcb list) - * is already locked or not. + * is already locked or not. * * @return int error on failure and 0 on success */ @@ -2343,16 +2424,16 @@ in_pcbinshash(struct inpcb *inp, int locked) if (!locked) { lck_rw_done(pcbinfo->ipi_lock); } - return (ECONNABORTED); + return ECONNABORTED; } #if INET6 - if (inp->inp_vflag & INP_IPV6) + if (inp->inp_vflag & INP_IPV6) { hashkey_faddr = inp->in6p_faddr.s6_addr32[3] /* XXX */; - else + } else #endif /* INET6 */ - hashkey_faddr = inp->inp_faddr.s_addr; + hashkey_faddr = inp->inp_faddr.s_addr; inp->inp_hash_element = INP_PCBHASH(hashkey_faddr, inp->inp_lport, inp->inp_fport, pcbinfo->ipi_hashmask); @@ -2366,20 +2447,22 @@ in_pcbinshash(struct inpcb *inp, int locked) * Go through port list and look for a head for this lport. */ LIST_FOREACH(phd, pcbporthash, phd_hash) { - if (phd->phd_port == inp->inp_lport) + if (phd->phd_port == inp->inp_lport) { break; + } } /* * If none exists, malloc one and tack it on. */ if (phd == NULL) { - MALLOC(phd, struct inpcbport *, sizeof (struct inpcbport), + MALLOC(phd, struct inpcbport *, sizeof(struct inpcbport), M_PCB, M_WAITOK); if (phd == NULL) { - if (!locked) + if (!locked) { lck_rw_done(pcbinfo->ipi_lock); - return (ENOBUFS); /* XXX */ + } + return ENOBUFS; /* XXX */ } phd->phd_port = inp->inp_lport; LIST_INIT(&phd->phd_pcblist); @@ -2394,15 +2477,16 @@ in_pcbinshash(struct inpcb *inp, int locked) LIST_INSERT_HEAD(pcbhash, inp, inp_hash); inp->inp_flags2 |= INP2_INHASHLIST; - if (!locked) + if (!locked) { lck_rw_done(pcbinfo->ipi_lock); + } #if NECP // This call catches the original setting of the local address inp_update_necp_policy(inp, NULL, NULL, 0); #endif /* NECP */ - return (0); + return 0; } /* @@ -2418,11 +2502,11 @@ in_pcbrehash(struct inpcb *inp) u_int32_t hashkey_faddr; #if INET6 - if (inp->inp_vflag & INP_IPV6) + if (inp->inp_vflag & INP_IPV6) { hashkey_faddr = inp->in6p_faddr.s6_addr32[3] /* XXX */; - else + } else #endif /* INET6 */ - hashkey_faddr = inp->inp_faddr.s_addr; + hashkey_faddr = inp->inp_faddr.s_addr; inp->inp_hash_element = INP_PCBHASH(hashkey_faddr, inp->inp_lport, inp->inp_fport, inp->inp_pcbinfo->ipi_hashmask); @@ -2490,7 +2574,7 @@ in_pcbremlists(struct inpcb *inp) } if (inp->inp_flags2 & INP2_IN_FCTREE) { - inp_fc_getinp(inp->inp_flowhash, (INPFC_SOLOCKED|INPFC_REMOVE)); + inp_fc_getinp(inp->inp_flowhash, (INPFC_SOLOCKED | INPFC_REMOVE)); VERIFY(!(inp->inp_flags2 & INP2_IN_FCTREE)); } @@ -2520,8 +2604,9 @@ in_pcb_checkstate(struct inpcb *pcb, int mode, int locked) * STOPUSING, if success we're good, if it's in use, will * be marked later */ - if (locked == 0) + if (locked == 0) { socket_lock(pcb->inp_socket, 1); + } pcb->inp_state = INPCB_STATE_DEAD; stopusing: @@ -2530,20 +2615,22 @@ stopusing: __func__, pcb, pcb->inp_socket); /* NOTREACHED */ } - if (locked == 0) + if (locked == 0) { socket_unlock(pcb->inp_socket, 1); + } inpcb_gc_sched(pcb->inp_pcbinfo, INPCB_TIMER_FAST); origwant = *wantcnt; - if ((UInt16) origwant == 0xffff) /* should stop using */ - return (WNT_STOPUSING); + if ((UInt16) origwant == 0xffff) { /* should stop using */ + return WNT_STOPUSING; + } newwant = 0xffff; if ((UInt16) origwant == 0) { /* try to mark it as unsuable now */ OSCompareAndSwap(origwant, newwant, wantcnt); } - return (WNT_STOPUSING); + return WNT_STOPUSING; case WNT_ACQUIRE: /* @@ -2555,19 +2642,20 @@ stopusing: origwant = *wantcnt; if ((UInt16) origwant == 0xffff) { /* should stop using */ - return (WNT_STOPUSING); + return WNT_STOPUSING; } newwant = origwant + 1; } while (!OSCompareAndSwap(origwant, newwant, wantcnt)); - return (WNT_ACQUIRE); + return WNT_ACQUIRE; case WNT_RELEASE: /* * Release reference. If result is null and pcb state * is DEAD, set wanted bit to STOPUSING */ - if (locked == 0) + if (locked == 0) { socket_lock(pcb->inp_socket, 1); + } do { origwant = *wantcnt; @@ -2578,24 +2666,27 @@ stopusing: } if ((UInt16) origwant == 0xffff) { /* should stop using */ - if (locked == 0) + if (locked == 0) { socket_unlock(pcb->inp_socket, 1); - return (WNT_STOPUSING); + } + return WNT_STOPUSING; } newwant = origwant - 1; } while (!OSCompareAndSwap(origwant, newwant, wantcnt)); - if (pcb->inp_state == INPCB_STATE_DEAD) + if (pcb->inp_state == INPCB_STATE_DEAD) { goto stopusing; + } if (pcb->inp_socket->so_usecount < 0) { panic("%s: RELEASE pcb=%p so=%p usecount is negative\n", __func__, pcb, pcb->inp_socket); /* NOTREACHED */ } - if (locked == 0) + if (locked == 0) { socket_unlock(pcb->inp_socket, 1); - return (WNT_RELEASE); + } + return WNT_RELEASE; default: panic("%s: so=%p not a valid state =%x\n", __func__, @@ -2604,7 +2695,7 @@ stopusing: } /* NOTREACHED */ - return (mode); + return mode; } /* @@ -2615,7 +2706,7 @@ stopusing: void inpcb_to_compat(struct inpcb *inp, struct inpcb_compat *inp_compat) { - bzero(inp_compat, sizeof (*inp_compat)); + bzero(inp_compat, sizeof(*inp_compat)); inp_compat->inp_fport = inp->inp_fport; inp_compat->inp_lport = inp->inp_lport; inp_compat->nat_owner = 0; @@ -2696,10 +2787,11 @@ inp_route_copyout(struct inpcb *inp, struct route *dst) * If the route in the PCB is stale or not for IPv4, blow it away; * this is possible in the case of IPv4-mapped address case. */ - if (ROUTE_UNUSABLE(src) || rt_key(src->ro_rt)->sa_family != AF_INET) + if (ROUTE_UNUSABLE(src) || rt_key(src->ro_rt)->sa_family != AF_INET) { ROUTE_RELEASE(src); + } - route_copyout(dst, src, sizeof (*dst)); + route_copyout(dst, src, sizeof(*dst)); } void @@ -2710,10 +2802,11 @@ inp_route_copyin(struct inpcb *inp, struct route *src) socket_lock_assert_owned(inp->inp_socket); /* Minor sanity check */ - if (src->ro_rt != NULL && rt_key(src->ro_rt)->sa_family != AF_INET) + if (src->ro_rt != NULL && rt_key(src->ro_rt)->sa_family != AF_INET) { panic("%s: wrong or corrupted route: %p", __func__, src); + } - route_copyin(src, dst, sizeof (*src)); + route_copyin(src, dst, sizeof(*src)); } /* @@ -2728,7 +2821,7 @@ inp_bindif(struct inpcb *inp, unsigned int ifscope, struct ifnet **pifp) if ((ifscope > (unsigned)if_index) || (ifscope != IFSCOPE_NONE && (ifp = ifindex2ifnet[ifscope]) == NULL)) { ifnet_head_done(); - return (ENXIO); + return ENXIO; } ifnet_head_done(); @@ -2744,18 +2837,20 @@ inp_bindif(struct inpcb *inp, unsigned int ifscope, struct ifnet **pifp) * exact match for the embedded interface scope. */ inp->inp_boundifp = ifp; - if (inp->inp_boundifp == NULL) + if (inp->inp_boundifp == NULL) { inp->inp_flags &= ~INP_BOUND_IF; - else + } else { inp->inp_flags |= INP_BOUND_IF; + } /* Blow away any cached route in the PCB */ ROUTE_RELEASE(&inp->inp_route); - if (pifp != NULL) + if (pifp != NULL) { *pifp = ifp; + } - return (0); + return 0; } /* @@ -2882,13 +2977,14 @@ inp_calc_flowhash(struct inpcb *inp) u_int32_t flowhash = 0; struct inpcb *tmp_inp = NULL; - if (inp_hash_seed == 0) + if (inp_hash_seed == 0) { inp_hash_seed = RandomULong(); + } - bzero(&fh, sizeof (fh)); + bzero(&fh, sizeof(fh)); - bcopy(&inp->inp_dependladdr, &fh.infh_laddr, sizeof (fh.infh_laddr)); - bcopy(&inp->inp_dependfaddr, &fh.infh_faddr, sizeof (fh.infh_faddr)); + bcopy(&inp->inp_dependladdr, &fh.infh_laddr, sizeof(fh.infh_laddr)); + bcopy(&inp->inp_dependfaddr, &fh.infh_faddr, sizeof(fh.infh_faddr)); fh.infh_lport = inp->inp_lport; fh.infh_fport = inp->inp_fport; @@ -2898,7 +2994,7 @@ inp_calc_flowhash(struct inpcb *inp) fh.infh_rand2 = RandomULong(); try_again: - flowhash = net_flowhash(&fh, sizeof (fh), inp_hash_seed); + flowhash = net_flowhash(&fh, sizeof(fh), inp_hash_seed); if (flowhash == 0) { /* try to get a non-zero flowhash */ inp_hash_seed = RandomULong(); @@ -2927,7 +3023,7 @@ try_again: inp->inp_flags2 |= INP2_IN_FCTREE; lck_mtx_unlock(&inp_fc_lck); - return (flowhash); + return flowhash; } void @@ -2937,8 +3033,9 @@ inp_flowadv(uint32_t flowhash) inp = inp_fc_getinp(flowhash, 0); - if (inp == NULL) + if (inp == NULL) { return; + } inp_fc_feedback(inp); } @@ -2948,8 +3045,8 @@ inp_flowadv(uint32_t flowhash) static inline int infc_cmp(const struct inpcb *inp1, const struct inpcb *inp2) { - return (memcmp(&(inp1->inp_flowhash), &(inp2->inp_flowhash), - sizeof(inp1->inp_flowhash))); + return memcmp(&(inp1->inp_flowhash), &(inp2->inp_flowhash), + sizeof(inp1->inp_flowhash)); } static struct inpcb * @@ -2964,23 +3061,24 @@ inp_fc_getinp(u_int32_t flowhash, u_int32_t flags) if (inp == NULL) { /* inp is not present, return */ lck_mtx_unlock(&inp_fc_lck); - return (NULL); + return NULL; } if (flags & INPFC_REMOVE) { RB_REMOVE(inp_fc_tree, &inp_fc_tree, inp); lck_mtx_unlock(&inp_fc_lck); - bzero(&(inp->infc_link), sizeof (inp->infc_link)); + bzero(&(inp->infc_link), sizeof(inp->infc_link)); inp->inp_flags2 &= ~INP2_IN_FCTREE; - return (NULL); + return NULL; } - if (in_pcb_checkstate(inp, WNT_ACQUIRE, locked) == WNT_STOPUSING) + if (in_pcb_checkstate(inp, WNT_ACQUIRE, locked) == WNT_STOPUSING) { inp = NULL; + } lck_mtx_unlock(&inp_fc_lck); - return (inp); + return inp; } static void @@ -2997,8 +3095,9 @@ inp_fc_feedback(struct inpcb *inp) return; } - if (inp->inp_sndinprog_cnt > 0) + if (inp->inp_sndinprog_cnt > 0) { inp->inp_flags |= INP_FC_FEEDBACK; + } /* * Return if the connection is not in flow-controlled state. @@ -3011,8 +3110,9 @@ inp_fc_feedback(struct inpcb *inp) } inp_reset_fc_state(inp); - if (SOCK_TYPE(so) == SOCK_STREAM) + if (SOCK_TYPE(so) == SOCK_STREAM) { inp_fc_unthrottle_tcp(inp); + } socket_unlock(so, 1); } @@ -3032,8 +3132,9 @@ inp_reset_fc_state(struct inpcb *inp) } /* Give a write wakeup to unblock the socket */ - if (needwakeup) + if (needwakeup) { sowwakeup(so); + } } int @@ -3047,14 +3148,16 @@ inp_set_fc_state(struct inpcb *inp, int advcode) * flow controlled state and receiving feedback from * the interface */ - if (inp->inp_flags & INP_FC_FEEDBACK) - return (0); + if (inp->inp_flags & INP_FC_FEEDBACK) { + return 0; + } inp->inp_flags &= ~(INP_FLOW_CONTROLLED | INP_FLOW_SUSPENDED); if ((tmp_inp = inp_fc_getinp(inp->inp_flowhash, INPFC_SOLOCKED)) != NULL) { - if (in_pcb_checkstate(tmp_inp, WNT_RELEASE, 1) == WNT_STOPUSING) - return (0); + if (in_pcb_checkstate(tmp_inp, WNT_RELEASE, 1) == WNT_STOPUSING) { + return 0; + } VERIFY(tmp_inp == inp); switch (advcode) { case FADV_FLOW_CONTROLLED: @@ -3069,9 +3172,9 @@ inp_set_fc_state(struct inpcb *inp, int advcode) inp->inp_socket->so_flags |= SOF_SUSPENDED; break; } - return (1); + return 1; } - return (0); + return 0; } /* @@ -3084,24 +3187,28 @@ inp_flush(struct inpcb *inp, int optval) struct ifnet *rtifp, *oifp; /* Either all classes or one of the valid ones */ - if (optval != SO_TC_ALL && !SO_VALID_TC(optval)) - return (EINVAL); + if (optval != SO_TC_ALL && !SO_VALID_TC(optval)) { + return EINVAL; + } /* We need a flow hash for identification */ - if (flowhash == 0) - return (0); + if (flowhash == 0) { + return 0; + } /* Grab the interfaces from the route and pcb */ rtifp = ((inp->inp_route.ro_rt != NULL) ? inp->inp_route.ro_rt->rt_ifp : NULL); oifp = inp->inp_last_outifp; - if (rtifp != NULL) + if (rtifp != NULL) { if_qflush_sc(rtifp, so_tc2msc(optval), flowhash, NULL, NULL, 0); - if (oifp != NULL && oifp != rtifp) + } + if (oifp != NULL && oifp != rtifp) { if_qflush_sc(oifp, so_tc2msc(optval), flowhash, NULL, NULL, 0); + } - return (0); + return 0; } /* @@ -3126,8 +3233,9 @@ inp_get_soprocinfo(struct inpcb *inp, struct so_procinfo *soprocinfo) struct socket *so = inp->inp_socket; soprocinfo->spi_pid = so->last_pid; - if (so->last_pid != 0) + if (so->last_pid != 0) { uuid_copy(soprocinfo->spi_uuid, so->last_uuid); + } /* * When not delegated, the effective pid is the same as the real pid */ @@ -3148,10 +3256,11 @@ inp_findinpcb_procinfo(struct inpcbinfo *pcbinfo, uint32_t flowhash, struct inpcb *inp = NULL; int found = 0; - bzero(soprocinfo, sizeof (struct so_procinfo)); + bzero(soprocinfo, sizeof(struct so_procinfo)); - if (!flowhash) - return (-1); + if (!flowhash) { + return -1; + } lck_rw_lock_shared(pcbinfo->ipi_lock); LIST_FOREACH(inp, pcbinfo->ipi_listhead, inp_list) { @@ -3165,7 +3274,7 @@ inp_findinpcb_procinfo(struct inpcbinfo *pcbinfo, uint32_t flowhash, } lck_rw_done(pcbinfo->ipi_lock); - return (found); + return found; } #if CONFIG_PROC_UUID_POLICY @@ -3263,9 +3372,9 @@ inp_update_necp_policy(struct inpcb *inp, struct sockaddr *override_local_addr, { necp_socket_find_policy_match(inp, override_local_addr, override_remote_addr, override_bound_interface); if (necp_socket_should_rescope(inp) && - inp->inp_lport == 0 && - inp->inp_laddr.s_addr == INADDR_ANY && - IN6_IS_ADDR_UNSPECIFIED(&inp->in6p_laddr)) { + inp->inp_lport == 0 && + inp->inp_laddr.s_addr == INADDR_ANY && + IN6_IS_ADDR_UNSPECIFIED(&inp->in6p_laddr)) { // If we should rescope, and the socket is not yet bound inp_bindif(inp, necp_socket_get_rescope_if_index(inp), NULL); } @@ -3282,15 +3391,17 @@ inp_update_policy(struct inpcb *inp) int err = 0; if (!net_io_policy_uuid || - so == NULL || inp->inp_state == INPCB_STATE_DEAD) - return (0); + so == NULL || inp->inp_state == INPCB_STATE_DEAD) { + return 0; + } /* * Kernel-created sockets that aren't delegating other sockets * are currently exempted from UUID policy checks. */ - if (so->last_pid == 0 && !(so->so_flags & SOF_DELEGATED)) - return (0); + if (so->last_pid == 0 && !(so->so_flags & SOF_DELEGATED)) { + return 0; + } ogencnt = so->so_policy_gencnt; err = proc_uuid_policy_lookup(((so->so_flags & SOF_DELEGATED) ? @@ -3300,8 +3411,9 @@ inp_update_policy(struct inpcb *inp) * Discard cached generation count if the entry is gone (ENOENT), * so that we go thru the checks below. */ - if (err == ENOENT && ogencnt != 0) + if (err == ENOENT && ogencnt != 0) { so->so_policy_gencnt = 0; + } /* * If the generation count has changed, inspect the policy flags @@ -3326,10 +3438,10 @@ inp_update_policy(struct inpcb *inp) #endif /* NECP */ } - return ((err == ENOENT) ? 0 : err); + return (err == ENOENT) ? 0 : err; #else /* !CONFIG_PROC_UUID_POLICY */ #pragma unused(inp) - return (0); + return 0; #endif /* !CONFIG_PROC_UUID_POLICY */ } @@ -3351,34 +3463,43 @@ _inp_restricted_recv(struct inpcb *inp, struct ifnet *ifp) /* * Inbound restrictions. */ - if (!sorestrictrecv) - return (FALSE); + if (!sorestrictrecv) { + return FALSE; + } - if (ifp == NULL) - return (FALSE); + if (ifp == NULL) { + return FALSE; + } - if (IFNET_IS_CELLULAR(ifp) && INP_NO_CELLULAR(inp)) - return (TRUE); + if (IFNET_IS_CELLULAR(ifp) && INP_NO_CELLULAR(inp)) { + return TRUE; + } - if (IFNET_IS_EXPENSIVE(ifp) && INP_NO_EXPENSIVE(inp)) - return (TRUE); + if (IFNET_IS_EXPENSIVE(ifp) && INP_NO_EXPENSIVE(inp)) { + return TRUE; + } - if (IFNET_IS_AWDL_RESTRICTED(ifp) && !INP_AWDL_UNRESTRICTED(inp)) - return (TRUE); + if (IFNET_IS_AWDL_RESTRICTED(ifp) && !INP_AWDL_UNRESTRICTED(inp)) { + return TRUE; + } - if (!(ifp->if_eflags & IFEF_RESTRICTED_RECV)) - return (FALSE); + if (!(ifp->if_eflags & IFEF_RESTRICTED_RECV)) { + return FALSE; + } - if (inp->inp_flags & INP_RECV_ANYIF) - return (FALSE); + if (inp->inp_flags & INP_RECV_ANYIF) { + return FALSE; + } - if ((inp->inp_flags & INP_BOUND_IF) && inp->inp_boundifp == ifp) - return (FALSE); + if ((inp->inp_flags & INP_BOUND_IF) && inp->inp_boundifp == ifp) { + return FALSE; + } - if (IFNET_IS_INTCOPROC(ifp) && !INP_INTCOPROC_ALLOWED(inp)) - return (TRUE); + if (IFNET_IS_INTCOPROC(ifp) && !INP_INTCOPROC_ALLOWED(inp)) { + return TRUE; + } - return (TRUE); + return TRUE; } boolean_t @@ -3392,7 +3513,7 @@ inp_restricted_recv(struct inpcb *inp, struct ifnet *ifp) current_proc()->p_pid, proc_best_name(current_proc()), ifp->if_xname); } - return (ret); + return ret; } /* @@ -3408,25 +3529,31 @@ _inp_restricted_send(struct inpcb *inp, struct ifnet *ifp) /* * Outbound restrictions. */ - if (!sorestrictsend) - return (FALSE); + if (!sorestrictsend) { + return FALSE; + } - if (ifp == NULL) - return (FALSE); + if (ifp == NULL) { + return FALSE; + } - if (IFNET_IS_CELLULAR(ifp) && INP_NO_CELLULAR(inp)) - return (TRUE); + if (IFNET_IS_CELLULAR(ifp) && INP_NO_CELLULAR(inp)) { + return TRUE; + } - if (IFNET_IS_EXPENSIVE(ifp) && INP_NO_EXPENSIVE(inp)) - return (TRUE); + if (IFNET_IS_EXPENSIVE(ifp) && INP_NO_EXPENSIVE(inp)) { + return TRUE; + } - if (IFNET_IS_AWDL_RESTRICTED(ifp) && !INP_AWDL_UNRESTRICTED(inp)) - return (TRUE); + if (IFNET_IS_AWDL_RESTRICTED(ifp) && !INP_AWDL_UNRESTRICTED(inp)) { + return TRUE; + } - if (IFNET_IS_INTCOPROC(ifp) && !INP_INTCOPROC_ALLOWED(inp)) - return (TRUE); + if (IFNET_IS_INTCOPROC(ifp) && !INP_INTCOPROC_ALLOWED(inp)) { + return TRUE; + } - return (FALSE); + return FALSE; } boolean_t @@ -3440,7 +3567,7 @@ inp_restricted_send(struct inpcb *inp, struct ifnet *ifp) current_proc()->p_pid, proc_best_name(current_proc()), ifp->if_xname); } - return (ret); + return ret; } inline void @@ -3459,12 +3586,14 @@ inp_count_sndbytes(struct inpcb *inp, u_int32_t th_ack) * There can be data outstanding before the connection * becomes established -- TFO case */ - if (so->so_snd.sb_cc > 0) + if (so->so_snd.sb_cc > 0) { inp_incr_sndbytes_total(so, so->so_snd.sb_cc); + } unsent = inp_get_sndbytes_allunsent(so, th_ack); - if (unsent > 0) + if (unsent > 0) { inp_incr_sndbytes_unsent(so, unsent); + } } } @@ -3510,14 +3639,16 @@ inp_decr_sndbytes_unsent(struct socket *so, int32_t len) struct inpcb *inp = (struct inpcb *)so->so_pcb; struct ifnet *ifp = inp->inp_last_outifp; - if (so == NULL || !(so->so_snd.sb_flags & SB_SNDBYTE_CNT)) + if (so == NULL || !(so->so_snd.sb_flags & SB_SNDBYTE_CNT)) { return; + } if (ifp != NULL) { - if (ifp->if_sndbyte_unsent >= len) + if (ifp->if_sndbyte_unsent >= len) { OSAddAtomic64(-len, &ifp->if_sndbyte_unsent); - else + } else { ifp->if_sndbyte_unsent = 0; + } } } @@ -3526,8 +3657,9 @@ inp_decr_sndbytes_allunsent(struct socket *so, u_int32_t th_ack) { int32_t len; - if (so == NULL || !(so->so_snd.sb_flags & SB_SNDBYTE_CNT)) + if (so == NULL || !(so->so_snd.sb_flags & SB_SNDBYTE_CNT)) { return; + } len = inp_get_sndbytes_allunsent(so, th_ack); inp_decr_sndbytes_unsent(so, len); @@ -3543,5 +3675,5 @@ inp_set_activity_bitmap(struct inpcb *inp) inline void inp_get_activity_bitmap(struct inpcb *inp, activity_bitmap_t *ab) { - bcopy(&inp->inp_nw_activity, ab, sizeof (*ab)); + bcopy(&inp->inp_nw_activity, ab, sizeof(*ab)); }