X-Git-Url: https://git.saurik.com/apple/xnu.git/blobdiff_plain/89b3af67bb32e691275bf6fa803d1834b2284115..HEAD:/bsd/vfs/vfs_quota.c diff --git a/bsd/vfs/vfs_quota.c b/bsd/vfs/vfs_quota.c index 4e95edaa0..6fd297c9d 100644 --- a/bsd/vfs/vfs_quota.c +++ b/bsd/vfs/vfs_quota.c @@ -1,8 +1,8 @@ /* - * Copyright (c) 2002-2005 Apple Computer, Inc. All rights reserved. + * Copyright (c) 2002-2006 Apple Computer, Inc. All rights reserved. * * @APPLE_OSREFERENCE_LICENSE_HEADER_START@ - * + * * This file contains Original Code and/or Modifications of Original Code * as defined in and that are subject to the Apple Public Source License * Version 2.0 (the 'License'). You may not use this file except in @@ -11,10 +11,10 @@ * unlawful or unlicensed copies of an Apple operating system, or to * circumvent, violate, or enable the circumvention or violation of, any * terms of an Apple operating system software license agreement. - * + * * Please obtain a copy of the License at * http://www.opensource.apple.com/apsl/ and read it before using this file. - * + * * The Original Code and all software distributed under the License are * distributed on an 'AS IS' basis, WITHOUT WARRANTY OF ANY KIND, EITHER * EXPRESS OR IMPLIED, AND APPLE HEREBY DISCLAIMS ALL SUCH WARRANTIES, @@ -22,7 +22,7 @@ * FITNESS FOR A PARTICULAR PURPOSE, QUIET ENJOYMENT OR NON-INFRINGEMENT. * Please see the License for the specific language governing rights and * limitations under the License. - * + * * @APPLE_OSREFERENCE_LICENSE_HEADER_END@ */ /* @@ -67,7 +67,7 @@ #include #include #include -#include +#include #include #include #include @@ -79,15 +79,11 @@ /* vars for quota file lock */ -lck_grp_t * qf_lck_grp; -lck_grp_attr_t * qf_lck_grp_attr; -lck_attr_t * qf_lck_attr; +static LCK_GRP_DECLARE(qf_lck_grp, "quota file"); /* vars for quota list lock */ -lck_grp_t * quota_list_lck_grp; -lck_grp_attr_t * quota_list_lck_grp_attr; -lck_attr_t * quota_list_lck_attr; -lck_mtx_t * quota_list_mtx_lock; +static LCK_GRP_DECLARE(quota_list_lck_grp, "quuota list"); +static LCK_MTX_DECLARE(quota_list_mtx_lock, "a_list_lck_grp); /* Routines to lock and unlock the quota global data */ static int dq_list_lock(void); @@ -103,11 +99,11 @@ static u_int32_t quotamagic[MAXQUOTAS] = INITQMAGICS; * Code pertaining to management of the in-core dquot data structures. */ #define DQHASH(dqvp, id) \ - (&dqhashtbl[((((int)(dqvp)) >> 8) + id) & dqhash]) -LIST_HEAD(dqhash, dquot) *dqhashtbl; + (&dqhashtbl[((((intptr_t)(dqvp)) >> 8) + id) & dqhash]) +LIST_HEAD(dqhash, dquot) * dqhashtbl; u_long dqhash; -#define DQUOTINC 5 /* minimum free dquots desired */ +#define DQUOTINC 5 /* minimum free dquots desired */ long numdquot, desireddquot = DQUOTINC; /* @@ -119,8 +115,10 @@ TAILQ_HEAD(dqfreelist, dquot) dqfreelist; */ TAILQ_HEAD(dqdirtylist, dquot) dqdirtylist; +ZONE_VIEW_DEFINE(ZV_DQUOT, "FS quota entries", KHEAP_ID_DEFAULT, + sizeof(struct dquot)); -static int dqlookup(struct quotafile *, u_long, struct dqblk *, u_int32_t *); +static int dqlookup(struct quotafile *, u_int32_t, struct dqblk *, u_int32_t *); static int dqsync_locked(struct dquot *dq); static void qf_lock(struct quotafile *); @@ -130,43 +128,30 @@ static void qf_rele(struct quotafile *); /* - * Initialize the quota system. + * Report whether dqhashinit has been run. + */ +int +dqisinitialized(void) +{ + return dqhashtbl != NULL; +} + +/* + * Initialize hash table for dquot structures. */ void -dqinit() +dqhashinit(void) { + dq_list_lock(); + if (dqisinitialized()) { + goto out; + } - dqhashtbl = hashinit(desiredvnodes, M_DQUOT, &dqhash); TAILQ_INIT(&dqfreelist); TAILQ_INIT(&dqdirtylist); - - /* - * Allocate quota list lock group attribute and group - */ - quota_list_lck_grp_attr= lck_grp_attr_alloc_init(); - quota_list_lck_grp = lck_grp_alloc_init("quota list", quota_list_lck_grp_attr); - - /* - * Allocate qouta list lock attribute - */ - quota_list_lck_attr = lck_attr_alloc_init(); - - /* - * Allocate quota list lock - */ - quota_list_mtx_lock = lck_mtx_alloc_init(quota_list_lck_grp, quota_list_lck_attr); - - - /* - * allocate quota file lock group attribute and group - */ - qf_lck_grp_attr= lck_grp_attr_alloc_init(); - qf_lck_grp = lck_grp_alloc_init("quota file", qf_lck_grp_attr); - - /* - * Allocate quota file lock attribute - */ - qf_lck_attr = lck_attr_alloc_init(); + dqhashtbl = hashinit(desiredvnodes, M_DQUOT, &dqhash); +out: + dq_list_unlock(); } @@ -175,24 +160,26 @@ static volatile int dq_list_lock_cnt = 0; static int dq_list_lock(void) { - lck_mtx_lock(quota_list_mtx_lock); + lck_mtx_lock("a_list_mtx_lock); return ++dq_list_lock_cnt; } static int -dq_list_lock_changed(int oldval) { - return (dq_list_lock_cnt != oldval); +dq_list_lock_changed(int oldval) +{ + return dq_list_lock_cnt != oldval; } static int -dq_list_lock_val(void) { +dq_list_lock_val(void) +{ return dq_list_lock_cnt; } void dq_list_unlock(void) { - lck_mtx_unlock(quota_list_mtx_lock); + lck_mtx_unlock("a_list_mtx_lock); } @@ -202,9 +189,9 @@ dq_list_unlock(void) void dq_lock_internal(struct dquot *dq) { - while (dq->dq_lflags & DQ_LLOCK) { - dq->dq_lflags |= DQ_LWANT; - msleep(&dq->dq_lflags, quota_list_mtx_lock, PVFS, "dq_lock_internal", 0); + while (dq->dq_lflags & DQ_LLOCK) { + dq->dq_lflags |= DQ_LWANT; + msleep(&dq->dq_lflags, "a_list_mtx_lock, PVFS, "dq_lock_internal", NULL); } dq->dq_lflags |= DQ_LLOCK; } @@ -215,32 +202,33 @@ dq_lock_internal(struct dquot *dq) void dq_unlock_internal(struct dquot *dq) { - int wanted = dq->dq_lflags & DQ_LWANT; + int wanted = dq->dq_lflags & DQ_LWANT; dq->dq_lflags &= ~(DQ_LLOCK | DQ_LWANT); - if (wanted) - wakeup(&dq->dq_lflags); + if (wanted) { + wakeup(&dq->dq_lflags); + } } void -dqlock(struct dquot *dq) { - - lck_mtx_lock(quota_list_mtx_lock); +dqlock(struct dquot *dq) +{ + lck_mtx_lock("a_list_mtx_lock); dq_lock_internal(dq); - lck_mtx_unlock(quota_list_mtx_lock); + lck_mtx_unlock("a_list_mtx_lock); } void -dqunlock(struct dquot *dq) { - - lck_mtx_lock(quota_list_mtx_lock); +dqunlock(struct dquot *dq) +{ + lck_mtx_lock("a_list_mtx_lock); dq_unlock_internal(dq); - lck_mtx_unlock(quota_list_mtx_lock); + lck_mtx_unlock("a_list_mtx_lock); } @@ -248,66 +236,65 @@ dqunlock(struct dquot *dq) { int qf_get(struct quotafile *qfp, int type) { - int error = 0; + int error = 0; - dq_list_lock(); - - switch (type) { + dq_list_lock(); + switch (type) { case QTF_OPENING: - while ( (qfp->qf_qflags & (QTF_OPENING | QTF_CLOSING)) ) { - if ( (qfp->qf_qflags & QTF_OPENING) ) { - error = EBUSY; + while ((qfp->qf_qflags & (QTF_OPENING | QTF_CLOSING))) { + if ((qfp->qf_qflags & QTF_OPENING)) { + error = EBUSY; break; } - if ( (qfp->qf_qflags & QTF_CLOSING) ) { - qfp->qf_qflags |= QTF_WANTED; - msleep(&qfp->qf_qflags, quota_list_mtx_lock, PVFS, "qf_get", 0); + if ((qfp->qf_qflags & QTF_CLOSING)) { + qfp->qf_qflags |= QTF_WANTED; + msleep(&qfp->qf_qflags, "a_list_mtx_lock, PVFS, "qf_get", NULL); } } - if (qfp->qf_vp != NULLVP) - error = EBUSY; - if (error == 0) - qfp->qf_qflags |= QTF_OPENING; + if (qfp->qf_vp != NULLVP) { + error = EBUSY; + } + if (error == 0) { + qfp->qf_qflags |= QTF_OPENING; + } break; case QTF_CLOSING: - if ( (qfp->qf_qflags & QTF_CLOSING) ) { - error = EBUSY; + if ((qfp->qf_qflags & QTF_CLOSING)) { + error = EBUSY; break; } qfp->qf_qflags |= QTF_CLOSING; - while ( (qfp->qf_qflags & QTF_OPENING) || qfp->qf_refcnt ) { - qfp->qf_qflags |= QTF_WANTED; - msleep(&qfp->qf_qflags, quota_list_mtx_lock, PVFS, "qf_get", 0); + while ((qfp->qf_qflags & QTF_OPENING) || qfp->qf_refcnt) { + qfp->qf_qflags |= QTF_WANTED; + msleep(&qfp->qf_qflags, "a_list_mtx_lock, PVFS, "qf_get", NULL); } if (qfp->qf_vp == NULLVP) { - qfp->qf_qflags &= ~QTF_CLOSING; + qfp->qf_qflags &= ~QTF_CLOSING; error = EBUSY; } break; } dq_list_unlock(); - return (error); + return error; } void qf_put(struct quotafile *qfp, int type) { + dq_list_lock(); - dq_list_lock(); - - switch (type) { - + switch (type) { case QTF_OPENING: case QTF_CLOSING: - qfp->qf_qflags &= ~type; + qfp->qf_qflags &= ~type; break; } - if ( (qfp->qf_qflags & QTF_WANTED) ) { - qfp->qf_qflags &= ~QTF_WANTED; + if ((qfp->qf_qflags & QTF_WANTED)) { + qfp->qf_qflags &= ~QTF_WANTED; wakeup(&qfp->qf_qflags); } dq_list_unlock(); @@ -344,18 +331,19 @@ qf_unlock(struct quotafile *qfp) static int qf_ref(struct quotafile *qfp) { - int error = 0; + int error = 0; - if ( (qfp->qf_qflags & (QTF_OPENING | QTF_CLOSING)) || (qfp->qf_vp == NULLVP) ) - error = EINVAL; - else - qfp->qf_refcnt++; + if ((qfp->qf_qflags & (QTF_OPENING | QTF_CLOSING)) || (qfp->qf_vp == NULLVP)) { + error = EINVAL; + } else { + qfp->qf_refcnt++; + } - return (error); + return error; } /* - * drop our reference and wakeup any waiters if + * drop our reference and wakeup any waiters if * we were the last one holding a ref * * quota list lock must be held on entry @@ -365,9 +353,9 @@ qf_rele(struct quotafile *qfp) { qfp->qf_refcnt--; - if ( (qfp->qf_qflags & QTF_WANTED) && qfp->qf_refcnt == 0) { - qfp->qf_qflags &= ~QTF_WANTED; - wakeup(&qfp->qf_qflags); + if ((qfp->qf_qflags & QTF_WANTED) && qfp->qf_refcnt == 0) { + qfp->qf_qflags &= ~QTF_WANTED; + wakeup(&qfp->qf_qflags); } } @@ -375,10 +363,10 @@ qf_rele(struct quotafile *qfp) void dqfileinit(struct quotafile *qfp) { - qfp->qf_vp = NULLVP; + qfp->qf_vp = NULLVP; qfp->qf_qflags = 0; - lck_mtx_init(&qfp->qf_lock, qf_lck_grp, qf_lck_attr); + lck_mtx_init(&qfp->qf_lock, &qf_lck_grp, LCK_ATTR_NULL); } @@ -388,32 +376,31 @@ dqfileinit(struct quotafile *qfp) * must be called with the quota file lock held */ int -dqfileopen(qfp, type) - struct quotafile *qfp; - int type; +dqfileopen(struct quotafile *qfp, int type) { struct dqfilehdr header; struct vfs_context context; off_t file_size; uio_t auio; int error = 0; - char uio_buf[ UIO_SIZEOF(1) ]; + char uio_buf[UIO_SIZEOF(1)]; - context.vc_proc = current_proc(); + context.vc_thread = current_thread(); context.vc_ucred = qfp->qf_cred; - + /* Obtain the file size */ - if ((error = vnode_size(qfp->qf_vp, &file_size, &context)) != 0) - goto out; + if ((error = vnode_size(qfp->qf_vp, &file_size, &context)) != 0) { + goto out; + } /* Read the file header */ - auio = uio_createwithbuffer(1, 0, UIO_SYSSPACE, UIO_READ, - &uio_buf[0], sizeof(uio_buf)); - uio_addiov(auio, CAST_USER_ADDR_T(&header), sizeof (header)); + auio = uio_createwithbuffer(1, 0, UIO_SYSSPACE, UIO_READ, + &uio_buf[0], sizeof(uio_buf)); + uio_addiov(auio, CAST_USER_ADDR_T(&header), sizeof(header)); error = VNOP_READ(qfp->qf_vp, auio, 0, &context); - if (error) - goto out; - else if (uio_resid(auio)) { + if (error) { + goto out; + } else if (uio_resid(auio)) { error = EINVAL; goto out; } @@ -426,21 +413,23 @@ dqfileopen(qfp, type) goto out; } /* Set up the time limits for this quota. */ - if (header.dqh_btime != 0) + if (header.dqh_btime != 0) { qfp->qf_btime = OSSwapBigToHostInt32(header.dqh_btime); - else + } else { qfp->qf_btime = MAX_DQ_TIME; - if (header.dqh_itime != 0) + } + if (header.dqh_itime != 0) { qfp->qf_itime = OSSwapBigToHostInt32(header.dqh_itime); - else + } else { qfp->qf_itime = MAX_IQ_TIME; + } /* Calculate the hash table constants. */ qfp->qf_maxentries = OSSwapBigToHostInt32(header.dqh_maxentries); qfp->qf_entrycnt = OSSwapBigToHostInt32(header.dqh_entrycnt); qfp->qf_shift = dqhashshift(qfp->qf_maxentries); out: - return (error); + return error; } /* @@ -452,19 +441,19 @@ dqfileclose(struct quotafile *qfp, __unused int type) struct dqfilehdr header; struct vfs_context context; uio_t auio; - char uio_buf[ UIO_SIZEOF(1) ]; + char uio_buf[UIO_SIZEOF(1)]; - auio = uio_createwithbuffer(1, 0, UIO_SYSSPACE, UIO_READ, - &uio_buf[0], sizeof(uio_buf)); - uio_addiov(auio, CAST_USER_ADDR_T(&header), sizeof (header)); + auio = uio_createwithbuffer(1, 0, UIO_SYSSPACE, UIO_READ, + &uio_buf[0], sizeof(uio_buf)); + uio_addiov(auio, CAST_USER_ADDR_T(&header), sizeof(header)); - context.vc_proc = current_proc(); + context.vc_thread = current_thread(); context.vc_ucred = qfp->qf_cred; - + if (VNOP_READ(qfp->qf_vp, auio, 0, &context) == 0) { header.dqh_entrycnt = OSSwapHostToBigInt32(qfp->qf_entrycnt); uio_reset(auio, 0, UIO_SYSSPACE, UIO_WRITE); - uio_addiov(auio, CAST_USER_ADDR_T(&header), sizeof (header)); + uio_addiov(auio, CAST_USER_ADDR_T(&header), sizeof(header)); (void) VNOP_WRITE(qfp->qf_vp, auio, 0, &context); } } @@ -475,11 +464,7 @@ dqfileclose(struct quotafile *qfp, __unused int type) * reading the information from the file if necessary. */ int -dqget(id, qfp, type, dqp) - u_long id; - struct quotafile *qfp; - register int type; - struct dquot **dqp; +dqget(u_int32_t id, struct quotafile *qfp, int type, struct dquot **dqp) { struct dquot *dq; struct dquot *ndq = NULL; @@ -489,24 +474,29 @@ dqget(id, qfp, type, dqp) int error = 0; int listlockval = 0; - if ( id == 0 || qfp->qf_vp == NULLVP ) { + if (!dqisinitialized()) { *dqp = NODQUOT; - return (EINVAL); + return EINVAL; + } + + if (id == 0 || qfp->qf_vp == NULLVP) { + *dqp = NODQUOT; + return EINVAL; } dq_list_lock(); - if ( (qf_ref(qfp)) ) { - dq_list_unlock(); + if ((qf_ref(qfp))) { + dq_list_unlock(); *dqp = NODQUOT; - return (EINVAL); + return EINVAL; } - if ( (dqvp = qfp->qf_vp) == NULLVP ) { - qf_rele(qfp); + if ((dqvp = qfp->qf_vp) == NULLVP) { + qf_rele(qfp); dq_list_unlock(); *dqp = NODQUOT; - return (EINVAL); + return EINVAL; } dqh = DQHASH(dqvp, id); @@ -518,8 +508,9 @@ relookup: */ for (dq = dqh->lh_first; dq; dq = dq->dq_hash.le_next) { if (dq->dq_id != id || - dq->dq_qfile->qf_vp != dqvp) + dq->dq_qfile->qf_vp != dqvp) { continue; + } dq_lock_internal(dq); if (dq_list_lock_changed(listlockval)) { @@ -533,7 +524,7 @@ relookup: */ if (dq->dq_id != id || dq->dq_qfile == NULL || dq->dq_qfile->qf_vp != dqvp) { - dq_unlock_internal(dq); + dq_unlock_internal(dq); goto relookup; } /* @@ -541,70 +532,65 @@ relookup: * the structure off the free list. */ if (dq->dq_cnt++ == 0) { - if (dq->dq_flags & DQ_MOD) + if (dq->dq_flags & DQ_MOD) { TAILQ_REMOVE(&dqdirtylist, dq, dq_freelist); - else + } else { TAILQ_REMOVE(&dqfreelist, dq, dq_freelist); - } else if (dq->dq_cnt == 0) { - /* We've overflowed */ - --dq->dq_cnt; - dq_unlock_internal(dq); - dq_list_unlock(); - *dqp = NODQUOT; - return (EINVAL); + } } dq_unlock_internal(dq); if (fdq != NULL) { - /* + /* * we grabbed this from the free list in the first pass * but we found the dq we were looking for in * the cache the 2nd time through * so stick it back on the free list and return the cached entry */ - TAILQ_INSERT_HEAD(&dqfreelist, fdq, dq_freelist); + TAILQ_INSERT_HEAD(&dqfreelist, fdq, dq_freelist); } qf_rele(qfp); - dq_list_unlock(); - + dq_list_unlock(); + if (ndq != NULL) { - /* + /* * we allocated this in the first pass * but we found the dq we were looking for in * the cache the 2nd time through so free it */ - _FREE(ndq, M_DQUOT); + zfree(ZV_DQUOT, ndq); } *dqp = dq; - return (0); + return 0; } /* * Not in cache, allocate a new one. */ if (TAILQ_EMPTY(&dqfreelist) && - numdquot < MAXQUOTAS * desiredvnodes) + numdquot < MAXQUOTAS * desiredvnodes) { desireddquot += DQUOTINC; + } if (fdq != NULL) { - /* + /* * we captured this from the free list * in the first pass through, so go * ahead and use it */ - dq = fdq; + dq = fdq; fdq = NULL; } else if (numdquot < desireddquot) { - if (ndq == NULL) { - /* - * drop the quota list lock since MALLOC may block + if (ndq == NULL) { + /* + * drop the quota list lock since zalloc may block */ - dq_list_unlock(); + dq_list_unlock(); - ndq = (struct dquot *)_MALLOC(sizeof *dq, M_DQUOT, M_WAITOK); - bzero((char *)ndq, sizeof *dq); + ndq = (struct dquot *)zalloc_flags(ZV_DQUOT, + Z_WAITOK | Z_ZERO); - listlockval = dq_list_lock(); + listlockval = dq_list_lock(); /* * need to look for the entry again in the cache * since we dropped the quota list lock and @@ -612,44 +598,44 @@ relookup: */ goto relookup; } else { - /* + /* * we allocated this in the first pass through * and we're still under out target, so go * ahead and use it */ - dq = ndq; + dq = ndq; ndq = NULL; numdquot++; } } else { - if (TAILQ_EMPTY(&dqfreelist)) { - qf_rele(qfp); - dq_list_unlock(); + if (TAILQ_EMPTY(&dqfreelist)) { + qf_rele(qfp); + dq_list_unlock(); if (ndq) { - /* + /* * we allocated this in the first pass through * but we're now at the limit of our cache size * so free it */ - _FREE(ndq, M_DQUOT); + zfree(ZV_DQUOT, ndq); } tablefull("dquot"); *dqp = NODQUOT; - return (EUSERS); + return EUSERS; } dq = TAILQ_FIRST(&dqfreelist); dq_lock_internal(dq); if (dq_list_lock_changed(listlockval) || dq->dq_cnt || (dq->dq_flags & DQ_MOD)) { - /* + /* * we lost the race while we weren't holding * the quota list lock... dq_lock_internal * will drop it to msleep... this dq has been * reclaimed... go find another */ - dq_unlock_internal(dq); + dq_unlock_internal(dq); /* * need to look for the entry again in the cache @@ -661,7 +647,7 @@ relookup: TAILQ_REMOVE(&dqfreelist, dq, dq_freelist); if (dq->dq_qfile != NULL) { - LIST_REMOVE(dq, dq_hash); + LIST_REMOVE(dq, dq_hash); dq->dq_qfile = NULL; dq->dq_id = 0; } @@ -669,7 +655,7 @@ relookup: /* * because we may have dropped the quota list lock - * in the call to dq_lock_internal, we need to + * in the call to dq_lock_internal, we need to * relookup in the hash in case someone else * caused a dq with this identity to be created... * if we don't find it, we'll use this one @@ -710,12 +696,12 @@ relookup: dq_list_unlock(); if (ndq) { - /* + /* * we allocated this in the first pass through * but we didn't need it, so free it after * we've droped the quota list lock */ - _FREE(ndq, M_DQUOT); + zfree(ZV_DQUOT, ndq); } error = dqlookup(qfp, id, &dq->dq_dqb, &dq->dq_index); @@ -725,7 +711,7 @@ relookup: * quota structure and reflect problem to caller. */ if (error) { - dq_list_lock(); + dq_list_lock(); dq->dq_id = 0; dq->dq_qfile = NULL; @@ -733,28 +719,31 @@ relookup: dq_unlock_internal(dq); qf_rele(qfp); - dq_list_unlock(); + dq_list_unlock(); dqrele(dq); *dqp = NODQUOT; - return (error); + return error; } /* * Check for no limit to enforce. * Initialize time values if necessary. */ if (dq->dq_isoftlimit == 0 && dq->dq_bsoftlimit == 0 && - dq->dq_ihardlimit == 0 && dq->dq_bhardlimit == 0) + dq->dq_ihardlimit == 0 && dq->dq_bhardlimit == 0) { dq->dq_flags |= DQ_FAKE; + } if (dq->dq_id != 0) { struct timeval tv; microtime(&tv); - if (dq->dq_btime == 0) + if (dq->dq_btime == 0) { dq->dq_btime = tv.tv_sec + qfp->qf_btime; - if (dq->dq_itime == 0) + } + if (dq->dq_itime == 0) { dq->dq_itime = tv.tv_sec + qfp->qf_itime; + } } dq_list_lock(); dq_unlock_internal(dq); @@ -762,7 +751,7 @@ relookup: dq_list_unlock(); *dqp = dq; - return (0); + return 0; } /* @@ -771,45 +760,41 @@ relookup: * one is inserted. The actual hash table index is returned. */ static int -dqlookup(qfp, id, dqb, index) - struct quotafile *qfp; - u_long id; - struct dqblk *dqb; - u_int32_t *index; +dqlookup(struct quotafile *qfp, u_int32_t id, struct dqblk *dqb, uint32_t *index) { struct vnode *dqvp; struct vfs_context context; uio_t auio; int i, skip, last; - u_long mask; + u_int32_t mask; int error = 0; - char uio_buf[ UIO_SIZEOF(1) ]; + char uio_buf[UIO_SIZEOF(1)]; qf_lock(qfp); dqvp = qfp->qf_vp; - context.vc_proc = current_proc(); + context.vc_thread = current_thread(); context.vc_ucred = qfp->qf_cred; mask = qfp->qf_maxentries - 1; i = dqhash1(id, qfp->qf_shift, mask); skip = dqhash2(id, mask); - for (last = (i + (qfp->qf_maxentries-1) * skip) & mask; - i != last; - i = (i + skip) & mask) { - auio = uio_createwithbuffer(1, dqoffset(i), UIO_SYSSPACE, UIO_READ, - &uio_buf[0], sizeof(uio_buf)); - uio_addiov(auio, CAST_USER_ADDR_T(dqb), sizeof (struct dqblk)); + for (last = (i + (qfp->qf_maxentries - 1) * skip) & mask; + i != last; + i = (i + skip) & mask) { + auio = uio_createwithbuffer(1, dqoffset(i), UIO_SYSSPACE, UIO_READ, + &uio_buf[0], sizeof(uio_buf)); + uio_addiov(auio, CAST_USER_ADDR_T(dqb), sizeof(struct dqblk)); error = VNOP_READ(dqvp, auio, 0, &context); if (error) { - printf("dqlookup: error %d looking up id %d at index %d\n", error, id, i); + printf("dqlookup: error %d looking up id %u at index %d\n", error, id, i); break; } else if (uio_resid(auio)) { error = EIO; - printf("dqlookup: error looking up id %d at index %d\n", id, i); + printf("dqlookup: error looking up id %u at index %d\n", id, i); break; } /* @@ -824,12 +809,14 @@ dqlookup(qfp, id, dqb, index) * Write back to reserve entry for this id */ uio_reset(auio, dqoffset(i), UIO_SYSSPACE, UIO_WRITE); - uio_addiov(auio, CAST_USER_ADDR_T(dqb), sizeof (struct dqblk)); + uio_addiov(auio, CAST_USER_ADDR_T(dqb), sizeof(struct dqblk)); error = VNOP_WRITE(dqvp, auio, 0, &context); - if (uio_resid(auio) && error == 0) + if (uio_resid(auio) && error == 0) { error = EIO; - if (error == 0) + } + if (error == 0) { ++qfp->qf_entrycnt; + } dqb->dqb_id = id; break; } @@ -851,7 +838,7 @@ dqlookup(qfp, id, dqb, index) *index = i; /* remember index so we don't have to recompute it later */ - return (error); + return error; } @@ -861,9 +848,9 @@ dqlookup(qfp, id, dqb, index) void dqrele(struct dquot *dq) { - - if (dq == NODQUOT) + if (dq == NODQUOT) { return; + } dqlock(dq); if (dq->dq_cnt > 1) { @@ -872,13 +859,14 @@ dqrele(struct dquot *dq) dqunlock(dq); return; } - if (dq->dq_flags & DQ_MOD) + if (dq->dq_flags & DQ_MOD) { (void) dqsync_locked(dq); + } dq->dq_cnt--; dq_list_lock(); TAILQ_INSERT_TAIL(&dqfreelist, dq, dq_freelist); - dq_unlock_internal(dq); + dq_unlock_internal(dq); dq_list_unlock(); } @@ -886,24 +874,25 @@ dqrele(struct dquot *dq) * Release a reference to a dquot but don't do any I/O. */ void -dqreclaim(register struct dquot *dq) +dqreclaim(struct dquot *dq) { - - if (dq == NODQUOT) + if (dq == NODQUOT) { return; + } dq_list_lock(); dq_lock_internal(dq); if (--dq->dq_cnt > 0) { - dq_unlock_internal(dq); + dq_unlock_internal(dq); dq_list_unlock(); return; } - if (dq->dq_flags & DQ_MOD) + if (dq->dq_flags & DQ_MOD) { TAILQ_INSERT_TAIL(&dqdirtylist, dq, dq_freelist); - else + } else { TAILQ_INSERT_TAIL(&dqfreelist, dq, dq_freelist); + } dq_unlock_internal(dq); dq_list_unlock(); @@ -913,46 +902,40 @@ dqreclaim(register struct dquot *dq) * Update a quota file's orphaned disk quotas. */ void -dqsync_orphans(qfp) - struct quotafile *qfp; +dqsync_orphans(struct quotafile *qfp) { struct dquot *dq; - int listlockval = 0; dq_list_lock(); - loop: - listlockval = dq_list_lock_val(); - +loop: TAILQ_FOREACH(dq, &dqdirtylist, dq_freelist) { - if (dq->dq_qfile != qfp) - continue; + if (dq->dq_qfile != qfp) { + continue; + } dq_lock_internal(dq); - if (dq_list_lock_changed(listlockval)) { - dq_unlock_internal(dq); - goto loop; - } if (dq->dq_qfile != qfp) { - /* + /* * the identity of this dq changed while * the quota_list_lock was dropped * dq_lock_internal can drop it to msleep */ - dq_unlock_internal(dq); + dq_unlock_internal(dq); goto loop; } if ((dq->dq_flags & DQ_MOD) == 0) { - /* + /* * someone cleaned and removed this from * the dq from the dirty list while the * quota_list_lock was dropped */ - dq_unlock_internal(dq); + dq_unlock_internal(dq); goto loop; } - if (dq->dq_cnt != 0) + if (dq->dq_cnt != 0) { panic("dqsync_orphans: dquot in use"); + } TAILQ_REMOVE(&dqdirtylist, dq, dq_freelist); @@ -964,7 +947,7 @@ dqsync_orphans(qfp) * to pick up another one since we hold dqlock */ (void) dqsync_locked(dq); - + dq_list_lock(); TAILQ_INSERT_TAIL(&dqfreelist, dq, dq_freelist); @@ -978,17 +961,18 @@ dqsync_orphans(qfp) int dqsync(struct dquot *dq) { - int error = 0; + int error = 0; if (dq != NODQUOT) { - dqlock(dq); + dqlock(dq); - if ( (dq->dq_flags & DQ_MOD) ) - error = dqsync_locked(dq); + if ((dq->dq_flags & DQ_MOD)) { + error = dqsync_locked(dq); + } dqunlock(dq); } - return (error); + return error; } @@ -998,28 +982,29 @@ dqsync(struct dquot *dq) int dqsync_locked(struct dquot *dq) { - struct proc *p = current_proc(); /* XXX */ struct vfs_context context; struct vnode *dqvp; struct dqblk dqb, *dqblkp; uio_t auio; int error; - char uio_buf[ UIO_SIZEOF(1) ]; + char uio_buf[UIO_SIZEOF(1)]; if (dq->dq_id == 0) { - dq->dq_flags &= ~DQ_MOD; - return (0); + dq->dq_flags &= ~DQ_MOD; + return 0; } - if (dq->dq_qfile == NULL) + if (dq->dq_qfile == NULL) { panic("dqsync: NULL dq_qfile"); - if ((dqvp = dq->dq_qfile->qf_vp) == NULLVP) + } + if ((dqvp = dq->dq_qfile->qf_vp) == NULLVP) { panic("dqsync: NULL qf_vp"); + } - auio = uio_createwithbuffer(1, dqoffset(dq->dq_index), UIO_SYSSPACE, - UIO_WRITE, &uio_buf[0], sizeof(uio_buf)); - uio_addiov(auio, CAST_USER_ADDR_T(&dqb), sizeof (struct dqblk)); + auio = uio_createwithbuffer(1, dqoffset(dq->dq_index), UIO_SYSSPACE, + UIO_WRITE, &uio_buf[0], sizeof(uio_buf)); + uio_addiov(auio, CAST_USER_ADDR_T(&dqb), sizeof(struct dqblk)); - context.vc_proc = p; + context.vc_thread = current_thread(); /* XXX */ context.vc_ucred = dq->dq_qfile->qf_cred; dqblkp = &dq->dq_dqb; @@ -1038,23 +1023,27 @@ dqsync_locked(struct dquot *dq) dqb.dqb_spare[3] = 0; error = VNOP_WRITE(dqvp, auio, 0, &context); - if (uio_resid(auio) && error == 0) + if (uio_resid(auio) && error == 0) { error = EIO; + } dq->dq_flags &= ~DQ_MOD; - return (error); + return error; } /* * Flush all entries from the cache for a particular vnode. */ void -dqflush(vp) - register struct vnode *vp; +dqflush(struct vnode *vp) { - register struct dquot *dq, *nextdq; + struct dquot *dq, *nextdq; struct dqhash *dqh; + if (!dqisinitialized()) { + return; + } + /* * Move all dquot's that used to refer to this quota * file off their hash chains (they will eventually @@ -1065,10 +1054,12 @@ dqflush(vp) for (dqh = &dqhashtbl[dqhash]; dqh >= dqhashtbl; dqh--) { for (dq = dqh->lh_first; dq; dq = nextdq) { nextdq = dq->dq_hash.le_next; - if (dq->dq_qfile->qf_vp != vp) + if (dq->dq_qfile->qf_vp != vp) { continue; - if (dq->dq_cnt) + } + if (dq->dq_cnt) { panic("dqflush: stray dquot"); + } LIST_REMOVE(dq, dq_hash); dq->dq_qfile = NULL; } @@ -1078,10 +1069,10 @@ dqflush(vp) /* * LP64 support for munging dqblk structure. - * XXX conversion of user_time_t to time_t loses precision; not an issue for + * XXX conversion of user_time_t to time_t loses precision; not an issue for * XXX us now, since we are only ever setting 32 bits worth of time into it. */ -__private_extern__ void +__private_extern__ void munge_dqblk(struct dqblk *dqblkp, struct user_dqblk *user_dqblkp, boolean_t to64) { if (to64) { @@ -1090,12 +1081,11 @@ munge_dqblk(struct dqblk *dqblkp, struct user_dqblk *user_dqblkp, boolean_t to64 user_dqblkp->dqb_id = dqblkp->dqb_id; user_dqblkp->dqb_itime = dqblkp->dqb_itime; user_dqblkp->dqb_btime = dqblkp->dqb_btime; - } - else { + } else { /* munge user (64 bit) dqblk into kernel (32 bit) dqblk */ bcopy((caddr_t)user_dqblkp, (caddr_t)dqblkp, offsetof(struct dqblk, dqb_btime)); dqblkp->dqb_id = user_dqblkp->dqb_id; - dqblkp->dqb_itime = user_dqblkp->dqb_itime; /* XXX - lose precision */ - dqblkp->dqb_btime = user_dqblkp->dqb_btime; /* XXX - lose precision */ + dqblkp->dqb_itime = user_dqblkp->dqb_itime; /* XXX - lose precision */ + dqblkp->dqb_btime = user_dqblkp->dqb_btime; /* XXX - lose precision */ } }