X-Git-Url: https://git.saurik.com/apple/security.git/blobdiff_plain/fa7225c82381bac4432a6edf16f53b5370238d85..07691282a056c4efea71e1e505527601e8cc166b:/OSX/libsecurity_keychain/regressions/kc-26-key-import-public.m

diff --git a/OSX/libsecurity_keychain/regressions/kc-26-key-import-public.m b/OSX/libsecurity_keychain/regressions/kc-26-key-import-public.m
index 49b3c6c8..00ba7f7d 100644
--- a/OSX/libsecurity_keychain/regressions/kc-26-key-import-public.m
+++ b/OSX/libsecurity_keychain/regressions/kc-26-key-import-public.m
@@ -21,6 +21,13 @@
  * @APPLE_LICENSE_HEADER_END@
  */
 
+#include <libDER/asn1Types.h>
+#include <libDER/DER_Encode.h>
+#include <libDER/DER_Decode.h>
+#include <libDER/DER_Keys.h>
+
+#import <Foundation/Foundation.h>
+
 #import <Security/Security.h>
 #import <Security/SecCertificatePriv.h>
 
@@ -36,15 +43,6 @@
 //  <rdar://problem/10473567>
 //
 
-#import <Foundation/Foundation.h>
-#import <Security/Security.h>
-
-#include <libDER/asn1Types.h>
-#include <libDER/DER_Encode.h>
-#include <libDER/DER_Decode.h>
-#include <libDER/DER_Keys.h>
-
-
 /* test RSA public key to import */
 static const uint8_t kPublicKey[] =
 {
@@ -100,7 +98,7 @@ static void
 testPubKeyImport(void)
 {
 	OSStatus status = errSecSuccess;
-	NSArray* outputItems = nil;
+	CFArrayRef outputItems = nil;
     SecKeychainRef keychain = NULL;
 	NSData* keyData = [NSData dataWithBytes:kPublicKey length:sizeof(kPublicKey)];
 	SecExternalFormat format = kSecFormatUnknown;
@@ -111,7 +109,7 @@ testPubKeyImport(void)
 
 	status = SecItemImport((CFDataRef)keyData,
 		NULL, &format, &keyType, 0, NULL,
-        keychain, (CFArrayRef *)&outputItems);
+        keychain, &outputItems);
 
 	NSLog(@"SecItemImport result = %d", (int)status);
 
@@ -189,6 +187,7 @@ testPubKeyImportWithModulusAndExponent(SecKeychainRef keychain)
     CFArrayRef outArray = NULL;
 
     status = SecItemImport(pkcs1, NULL, &externalFormat, &externalItemType, 0, NULL, keychain, &outArray);
+    CFReleaseNull(pkcs1);
     ok_status(status, "%s: SecItemImport", testName);
     if (status != errSecSuccess) {
     	NSLog(@"SecItemImport result = %d", (int)status);
@@ -207,10 +206,8 @@ int kc_26_key_import_public(int argc, char *const *argv)
 
     SecKeychainRef kc = getPopulatedTestKeychain();
 
-    NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
 //    testPubKeyImport();
     testPubKeyImportWithModulusAndExponent(kc);
-    [pool drain];
 
     ok_status(SecKeychainDelete(kc), "%s: SecKeychainDelete", testName);
     CFReleaseNull(kc);