X-Git-Url: https://git.saurik.com/apple/security.git/blobdiff_plain/0e1db9d189370fed9f1993183ec38d748a8812f7..0d4552ce43ff8bf2e8666a9c5c44c3590eb117a8:/OSX/libsecurity_utilities/lib/machserver.cpp diff --git a/OSX/libsecurity_utilities/lib/machserver.cpp b/OSX/libsecurity_utilities/lib/machserver.cpp index 29ffa83a..4fca0b64 100644 --- a/OSX/libsecurity_utilities/lib/machserver.cpp +++ b/OSX/libsecurity_utilities/lib/machserver.cpp @@ -30,7 +30,7 @@ #include #include #include -#include "mach_notify.h" +#include "mach_notifyServer.h" #include #include @@ -300,21 +300,25 @@ void MachServer::runServerThread(bool doTimeout) * To avoid falling off the kernel's fast RPC path unnecessarily, * we only supply MACH_SEND_TIMEOUT when absolutely necessary. */ - mr = mach_msg_overwrite(bufReply, + mr = mach_msg_overwrite(bufReply, (MACH_MSGH_BITS_REMOTE(bufReply.bits()) == MACH_MSG_TYPE_MOVE_SEND_ONCE) ? MACH_SEND_MSG | mMsgOptions : MACH_SEND_MSG | MACH_SEND_TIMEOUT | mMsgOptions, bufReply.length(), 0, MACH_PORT_NULL, 0, MACH_PORT_NULL, NULL, 0); - switch (mr) { - case MACH_MSG_SUCCESS: - break; - default: + switch (mr) { + case MACH_MSG_SUCCESS: + break; + case MACH_SEND_INVALID_DEST: + case MACH_SEND_TIMED_OUT: secinfo("machserver", "send error: %d %d", mr, bufReply.remotePort().port()); - bufReply.destroy(); - break; - } + bufReply.destroy(); + break; + default: + secinfo("machserver", "send error: %d %d", mr, bufReply.remotePort().port()); + break; + } // clean up after the transaction @@ -562,6 +566,9 @@ kern_return_t cdsa_mach_notify_dead_name(mach_port_t, mach_port_name_t port) MachServer::active().notifyDeadName(port); } catch (...) { } + // the act of receiving a dead name notification allocates a dead-name + // right that must be deallocated + mach_port_deallocate(mach_task_self(), port); return KERN_SUCCESS; }