X-Git-Url: https://git.saurik.com/apple/javascriptcore.git/blobdiff_plain/ba379fdc102753d6be2c4d937058fe40257329fe..1981f5dfe8d77d97469d20652f712a09400c48ed:/runtime/Lookup.cpp diff --git a/runtime/Lookup.cpp b/runtime/Lookup.cpp index 8359ff7..b935eb2 100644 --- a/runtime/Lookup.cpp +++ b/runtime/Lookup.cpp @@ -20,8 +20,8 @@ #include "config.h" #include "Lookup.h" +#include "Executable.h" #include "JSFunction.h" -#include "PrototypeFunction.h" namespace JSC { @@ -33,8 +33,8 @@ void HashTable::createTable(JSGlobalData* globalData) const for (int i = 0; i < compactSize; ++i) entries[i].setKey(0); for (int i = 0; values[i].key; ++i) { - UString::Rep* identifier = Identifier::add(globalData, values[i].key).releaseRef(); - int hashIndex = identifier->computedHash() & compactHashSizeMask; + StringImpl* identifier = Identifier::add(globalData, values[i].key).leakRef(); + int hashIndex = identifier->existingHash() & compactHashSizeMask; HashEntry* entry = &entries[hashIndex]; if (entry->key()) { @@ -46,7 +46,7 @@ void HashTable::createTable(JSGlobalData* globalData) const entry = entry->next(); } - entry->initialize(identifier, values[i].attributes, values[i].value1, values[i].value2); + entry->initialize(identifier, values[i].attributes, values[i].value1, values[i].value2, values[i].intrinsic); } table = entries; } @@ -56,7 +56,7 @@ void HashTable::deleteTable() const if (table) { int max = compactSize; for (int i = 0; i != max; ++i) { - if (UString::Rep* key = table[i].key()) + if (StringImpl* key = table[i].key()) key->deref(); } delete [] table; @@ -64,19 +64,25 @@ void HashTable::deleteTable() const } } -void setUpStaticFunctionSlot(ExecState* exec, const HashEntry* entry, JSObject* thisObj, const Identifier& propertyName, PropertySlot& slot) +bool setUpStaticFunctionSlot(ExecState* exec, const HashEntry* entry, JSObject* thisObj, const Identifier& propertyName, PropertySlot& slot) { + ASSERT(thisObj->globalObject()); ASSERT(entry->attributes() & Function); - JSValue* location = thisObj->getDirectLocation(propertyName); + WriteBarrierBase* location = thisObj->getDirectLocation(exec->globalData(), propertyName); if (!location) { - InternalFunction* function = new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), entry->functionLength(), propertyName, entry->function()); - - thisObj->putDirectFunction(propertyName, function, entry->attributes()); - location = thisObj->getDirectLocation(propertyName); + // If a property is ever deleted from an object with a static table, then we reify + // all static functions at that time - after this we shouldn't be re-adding anything. + if (thisObj->staticFunctionsReified()) + return false; + + JSFunction* function = JSFunction::create(exec, thisObj->globalObject(), entry->functionLength(), propertyName, entry->function(), entry->intrinsic()); + thisObj->putDirect(exec->globalData(), propertyName, function, entry->attributes()); + location = thisObj->getDirectLocation(exec->globalData(), propertyName); } - slot.setValueSlot(thisObj, location, thisObj->offsetForLocation(location)); + slot.setValue(thisObj, location->get(), thisObj->offsetForLocation(location)); + return true; } } // namespace JSC