X-Git-Url: https://git.saurik.com/apple/javascriptcore.git/blobdiff_plain/b37bf2e156556c589aea3e1f58a377f2b1189665..a253471d7f8e4d91bf6ebabab00155c3b387d3d0:/API/JSStringRefCF.cpp diff --git a/API/JSStringRefCF.cpp b/API/JSStringRefCF.cpp index 70a5aa7..0877a13 100644 --- a/API/JSStringRefCF.cpp +++ b/API/JSStringRefCF.cpp @@ -1,4 +1,3 @@ -// -*- mode: c++; c-basic-offset: 4 -*- /* * Copyright (C) 2006, 2007 Apple Computer, Inc. All rights reserved. * @@ -28,30 +27,31 @@ #include "JSStringRefCF.h" #include "APICast.h" +#include "InitializeThreading.h" #include "JSStringRef.h" -#include -#include -#include - -using namespace KJS; +#include "OpaqueJSString.h" +#include +#include +#include JSStringRef JSStringCreateWithCFString(CFStringRef string) { - JSLock lock; - CFIndex length = CFStringGetLength(string); - UString::Rep* rep; - if (!length) - rep = UString("").rep()->ref(); - else { - UniChar* buffer = static_cast(fastMalloc(sizeof(UniChar) * length)); - CFStringGetCharacters(string, CFRangeMake(0, length), buffer); - rep = UString(reinterpret_cast(buffer), length, false).rep()->ref(); + JSC::initializeThreading(); + + // We cannot use CFIndex here since CFStringGetLength can return values larger than + // it can hold. () + size_t length = CFStringGetLength(string); + if (length) { + OwnArrayPtr buffer = adoptArrayPtr(new UniChar[length]); + CFStringGetCharacters(string, CFRangeMake(0, length), buffer.get()); + COMPILE_ASSERT(sizeof(UniChar) == sizeof(UChar), unichar_and_uchar_must_be_same_size); + return OpaqueJSString::create(reinterpret_cast(buffer.get()), length).leakRef(); + } else { + return OpaqueJSString::create(0, 0).leakRef(); } - return toRef(rep); } CFStringRef JSStringCopyCFString(CFAllocatorRef alloc, JSStringRef string) { - UString::Rep* rep = toJS(string); - return CFStringCreateWithCharacters(alloc, reinterpret_cast(rep->data()), rep->size()); + return CFStringCreateWithCharacters(alloc, reinterpret_cast(string->characters()), string->length()); }