X-Git-Url: https://git.saurik.com/apple/javascriptcore.git/blobdiff_plain/93a3786624b2768d89bfa27e46598dc64e2fb70a..ed1e77d3adeb83d26fd1dfb16dd84cabdcefd250:/runtime/StringRecursionChecker.h?ds=sidebyside diff --git a/runtime/StringRecursionChecker.h b/runtime/StringRecursionChecker.h index 07dc25a..0f1990e 100644 --- a/runtime/StringRecursionChecker.h +++ b/runtime/StringRecursionChecker.h @@ -49,10 +49,18 @@ private: inline JSValue StringRecursionChecker::performCheck() { - const StackBounds& nativeStack = wtfThreadData().stack(); - if (!nativeStack.isSafeToRecurse()) + VM& vm = m_exec->vm(); + if (!vm.isSafeToRecurse()) return throwStackOverflowError(); - bool alreadyVisited = !m_exec->vm().stringRecursionCheckVisitedObjects.add(m_thisObject).isNewEntry; + + bool alreadyVisited = false; + if (!vm.stringRecursionCheckFirstObject) + vm.stringRecursionCheckFirstObject = m_thisObject; + else if (vm.stringRecursionCheckFirstObject == m_thisObject) + alreadyVisited = true; + else + alreadyVisited = !vm.stringRecursionCheckVisitedObjects.add(m_thisObject).isNewEntry; + if (alreadyVisited) return emptyString(); // Return empty string to avoid infinite recursion. return JSValue(); // Indicate success. @@ -74,8 +82,14 @@ inline StringRecursionChecker::~StringRecursionChecker() { if (m_earlyReturnValue) return; - ASSERT(m_exec->vm().stringRecursionCheckVisitedObjects.contains(m_thisObject)); - m_exec->vm().stringRecursionCheckVisitedObjects.remove(m_thisObject); + + VM& vm = m_exec->vm(); + if (vm.stringRecursionCheckFirstObject == m_thisObject) + vm.stringRecursionCheckFirstObject = nullptr; + else { + ASSERT(vm.stringRecursionCheckVisitedObjects.contains(m_thisObject)); + vm.stringRecursionCheckVisitedObjects.remove(m_thisObject); + } } }