X-Git-Url: https://git.saurik.com/apple/javascriptcore.git/blobdiff_plain/93a3786624b2768d89bfa27e46598dc64e2fb70a..HEAD:/runtime/JSFunction.cpp?ds=sidebyside diff --git a/runtime/JSFunction.cpp b/runtime/JSFunction.cpp index 3b89f6d..1b8c407 100644 --- a/runtime/JSFunction.cpp +++ b/runtime/JSFunction.cpp @@ -1,9 +1,10 @@ /* * Copyright (C) 1999-2002 Harri Porten (porten@kde.org) * Copyright (C) 2001 Peter Kelly (pmk@post.com) - * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. + * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2015 Apple Inc. All rights reserved. * Copyright (C) 2007 Cameron Zwarich (cwzwarich@uwaterloo.ca) * Copyright (C) 2007 Maks Orlovich + * Copyright (C) 2015 Canon Inc. All rights reserved. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Library General Public @@ -25,6 +26,7 @@ #include "config.h" #include "JSFunction.h" +#include "ClonedArguments.h" #include "CodeBlock.h" #include "CommonIdentifiers.h" #include "CallFrame.h" @@ -32,89 +34,143 @@ #include "FunctionPrototype.h" #include "GetterSetter.h" #include "JSArray.h" +#include "JSBoundFunction.h" +#include "JSCInlines.h" +#include "JSFunctionInlines.h" #include "JSGlobalObject.h" #include "JSNotAnObject.h" #include "Interpreter.h" #include "ObjectConstructor.h" #include "ObjectPrototype.h" -#include "Operations.h" #include "Parser.h" #include "PropertyNameArray.h" - -using namespace WTF; -using namespace Unicode; +#include "StackVisitor.h" namespace JSC { + EncodedJSValue JSC_HOST_CALL callHostFunctionAsConstructor(ExecState* exec) { return throwVMError(exec, createNotAConstructorError(exec, exec->callee())); } -const ClassInfo JSFunction::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSFunction) }; +const ClassInfo JSFunction::s_info = { "Function", &Base::s_info, 0, CREATE_METHOD_TABLE(JSFunction) }; bool JSFunction::isHostFunctionNonInline() const { return isHostFunction(); } -JSFunction* JSFunction::create(ExecState* exec, JSGlobalObject* globalObject, int length, const String& name, NativeFunction nativeFunction, Intrinsic intrinsic, NativeFunction nativeConstructor) +JSFunction* JSFunction::create(VM& vm, FunctionExecutable* executable, JSScope* scope) +{ + JSFunction* result = createImpl(vm, executable, scope); + executable->singletonFunction()->notifyWrite(vm, result, "Allocating a function"); + return result; +} + +static inline NativeExecutable* getNativeExecutable(VM& vm, NativeFunction nativeFunction, Intrinsic intrinsic, NativeFunction nativeConstructor) { - NativeExecutable* executable; #if !ENABLE(JIT) UNUSED_PARAM(intrinsic); #else - if (intrinsic != NoIntrinsic && exec->vm().canUseJIT()) { + if (intrinsic != NoIntrinsic && vm.canUseJIT()) { ASSERT(nativeConstructor == callHostFunctionAsConstructor); - executable = exec->vm().getHostFunction(nativeFunction, intrinsic); - } else + return vm.getHostFunction(nativeFunction, intrinsic); + } #endif - executable = exec->vm().getHostFunction(nativeFunction, nativeConstructor); + return vm.getHostFunction(nativeFunction, nativeConstructor); +} - JSFunction* function = new (NotNull, allocateCell(*exec->heap())) JSFunction(exec, globalObject, globalObject->functionStructure()); +JSFunction* JSFunction::create(VM& vm, JSGlobalObject* globalObject, int length, const String& name, NativeFunction nativeFunction, Intrinsic intrinsic, NativeFunction nativeConstructor) +{ + NativeExecutable* executable = getNativeExecutable(vm, nativeFunction, intrinsic, nativeConstructor); + JSFunction* function = new (NotNull, allocateCell(vm.heap)) JSFunction(vm, globalObject, globalObject->functionStructure()); // Can't do this during initialization because getHostFunction might do a GC allocation. - function->finishCreation(exec, executable, length, name); + function->finishCreation(vm, executable, length, name); return function; } -void JSFunction::destroy(JSCell* cell) +class JSStdFunction : public JSFunction { +public: + JSStdFunction(VM& vm, JSGlobalObject* object, Structure* structure, NativeStdFunction&& function) + : JSFunction(vm, object, structure) + , stdFunction(WTF::move(function)) { } + + NativeStdFunction stdFunction; +}; + +static EncodedJSValue JSC_HOST_CALL runStdFunction(ExecState* state) +{ + JSStdFunction* jsFunction = jsCast(state->callee()); + ASSERT(jsFunction); + return jsFunction->stdFunction(state); +} + +JSFunction* JSFunction::create(VM& vm, JSGlobalObject* globalObject, int length, const String& name, NativeStdFunction&& nativeStdFunction, Intrinsic intrinsic, NativeFunction nativeConstructor) { - static_cast(cell)->JSFunction::~JSFunction(); + NativeExecutable* executable = getNativeExecutable(vm, runStdFunction, intrinsic, nativeConstructor); + JSStdFunction* function = new (NotNull, allocateCell(vm.heap)) JSStdFunction(vm, globalObject, globalObject->functionStructure(), WTF::move(nativeStdFunction)); + // Can't do this during initialization because getHostFunction might do a GC allocation. + function->finishCreation(vm, executable, length, name); + return function; } -JSFunction::JSFunction(ExecState* exec, JSGlobalObject* globalObject, Structure* structure) - : Base(exec->vm(), structure) +JSFunction::JSFunction(VM& vm, JSGlobalObject* globalObject, Structure* structure) + : Base(vm, globalObject, structure) , m_executable() - , m_scope(exec->vm(), this, globalObject) - // We initialize blind so that changes to the prototype after function creation but before - // the optimizer kicks in don't disable optimizations. Once the optimizer kicks in, the - // watchpoint will start watching and any changes will both force deoptimization and disable - // future attempts to optimize. This is necessary because we are guaranteed that the - // allocation profile is changed exactly once prior to optimizations kicking in. We could be - // smarter and count the number of times the prototype is clobbered and only optimize if it - // was clobbered exactly once, but that seems like overkill. In almost all cases it will be - // clobbered once, and if it's clobbered more than once, that will probably only occur - // before we started optimizing, anyway. - , m_allocationProfileWatchpoint(InitializedBlind) { } -void JSFunction::finishCreation(ExecState* exec, NativeExecutable* executable, int length, const String& name) +void JSFunction::finishCreation(VM& vm, NativeExecutable* executable, int length, const String& name) { - Base::finishCreation(exec->vm()); - ASSERT(inherits(&s_info)); - m_executable.set(exec->vm(), this, executable); - putDirect(exec->vm(), exec->vm().propertyNames->name, jsString(exec, name), DontDelete | ReadOnly | DontEnum); - putDirect(exec->vm(), exec->propertyNames().length, jsNumber(length), DontDelete | ReadOnly | DontEnum); + Base::finishCreation(vm); + ASSERT(inherits(info())); + m_executable.set(vm, this, executable); + putDirect(vm, vm.propertyNames->name, jsString(&vm, name), DontDelete | ReadOnly | DontEnum); + putDirect(vm, vm.propertyNames->length, jsNumber(length), DontDelete | ReadOnly | DontEnum); } -ObjectAllocationProfile* JSFunction::createAllocationProfile(ExecState* exec, size_t inlineCapacity) +JSFunction* JSFunction::createBuiltinFunction(VM& vm, FunctionExecutable* executable, JSGlobalObject* globalObject) { + JSFunction* function = create(vm, executable, globalObject); + function->putDirect(vm, vm.propertyNames->name, jsString(&vm, executable->name().string()), DontDelete | ReadOnly | DontEnum); + function->putDirect(vm, vm.propertyNames->length, jsNumber(executable->parameterCount()), DontDelete | ReadOnly | DontEnum); + return function; +} + +JSFunction* JSFunction::createBuiltinFunction(VM& vm, FunctionExecutable* executable, JSGlobalObject* globalObject, const String& name) +{ + JSFunction* function = create(vm, executable, globalObject); + function->putDirect(vm, vm.propertyNames->name, jsString(&vm, name), DontDelete | ReadOnly | DontEnum); + function->putDirect(vm, vm.propertyNames->length, jsNumber(executable->parameterCount()), DontDelete | ReadOnly | DontEnum); + return function; +} + +FunctionRareData* JSFunction::allocateAndInitializeRareData(ExecState* exec, size_t inlineCapacity) +{ + ASSERT(!m_rareData); VM& vm = exec->vm(); JSObject* prototype = jsDynamicCast(get(exec, vm.propertyNames->prototype)); if (!prototype) prototype = globalObject()->objectPrototype(); - m_allocationProfile.initialize(globalObject()->vm(), this, prototype, inlineCapacity); - return &m_allocationProfile; + FunctionRareData* rareData = FunctionRareData::create(vm, prototype, inlineCapacity); + + // A DFG compilation thread may be trying to read the rare data + // We want to ensure that it sees it properly allocated + WTF::storeStoreFence(); + + m_rareData.set(vm, this, rareData); + return m_rareData.get(); +} + +FunctionRareData* JSFunction::initializeRareData(ExecState* exec, size_t inlineCapacity) +{ + ASSERT(!!m_rareData); + VM& vm = exec->vm(); + JSObject* prototype = jsDynamicCast(get(exec, vm.propertyNames->prototype)); + if (!prototype) + prototype = globalObject()->objectPrototype(); + m_rareData->initialize(globalObject()->vm(), prototype, inlineCapacity); + return m_rareData.get(); } String JSFunction::name(ExecState* exec) @@ -140,7 +196,7 @@ const String JSFunction::calculatedDisplayName(ExecState* exec) return explicitName; const String actualName = name(exec); - if (!actualName.isEmpty() || isHostFunction()) + if (!actualName.isEmpty() || isHostOrBuiltinFunction()) return actualName; return jsExecutable()->inferredName().string(); @@ -148,22 +204,20 @@ const String JSFunction::calculatedDisplayName(ExecState* exec) const SourceCode* JSFunction::sourceCode() const { - if (isHostFunction()) + if (isHostOrBuiltinFunction()) return 0; return &jsExecutable()->source(); } - + void JSFunction::visitChildren(JSCell* cell, SlotVisitor& visitor) { JSFunction* thisObject = jsCast(cell); - ASSERT_GC_OBJECT_INHERITS(thisObject, &s_info); - COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag); - ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren()); + ASSERT_GC_OBJECT_INHERITS(thisObject, info()); Base::visitChildren(thisObject, visitor); - visitor.append(&thisObject->m_scope); visitor.append(&thisObject->m_executable); - thisObject->m_allocationProfile.visitAggregate(visitor); + if (thisObject->m_rareData) + visitor.append(&thisObject->m_rareData); } CallType JSFunction::getCallData(JSCell* cell, CallData& callData) @@ -178,83 +232,168 @@ CallType JSFunction::getCallData(JSCell* cell, CallData& callData) return CallTypeJS; } -JSValue JSFunction::argumentsGetter(ExecState* exec, JSValue slotBase, PropertyName) +class RetrieveArgumentsFunctor { +public: + RetrieveArgumentsFunctor(JSFunction* functionObj) + : m_targetCallee(jsDynamicCast(functionObj)) + , m_result(jsNull()) + { + } + + JSValue result() const { return m_result; } + + StackVisitor::Status operator()(StackVisitor& visitor) + { + JSObject* callee = visitor->callee(); + if (callee != m_targetCallee) + return StackVisitor::Continue; + + m_result = JSValue(visitor->createArguments()); + return StackVisitor::Done; + } + +private: + JSObject* m_targetCallee; + JSValue m_result; +}; + +static JSValue retrieveArguments(ExecState* exec, JSFunction* functionObj) +{ + RetrieveArgumentsFunctor functor(functionObj); + exec->iterate(functor); + return functor.result(); +} + +EncodedJSValue JSFunction::argumentsGetter(ExecState* exec, JSObject* slotBase, EncodedJSValue, PropertyName) { JSFunction* thisObj = jsCast(slotBase); ASSERT(!thisObj->isHostFunction()); - return exec->interpreter()->retrieveArgumentsFromVMCode(exec, thisObj); + + return JSValue::encode(retrieveArguments(exec, thisObj)); +} + +class RetrieveCallerFunctionFunctor { +public: + RetrieveCallerFunctionFunctor(JSFunction* functionObj) + : m_targetCallee(jsDynamicCast(functionObj)) + , m_hasFoundFrame(false) + , m_hasSkippedToCallerFrame(false) + , m_result(jsNull()) + { + } + + JSValue result() const { return m_result; } + + StackVisitor::Status operator()(StackVisitor& visitor) + { + JSObject* callee = visitor->callee(); + + if (callee && callee->inherits(JSBoundFunction::info())) + return StackVisitor::Continue; + + if (!m_hasFoundFrame && (callee != m_targetCallee)) + return StackVisitor::Continue; + + m_hasFoundFrame = true; + if (!m_hasSkippedToCallerFrame) { + m_hasSkippedToCallerFrame = true; + return StackVisitor::Continue; + } + + if (callee) + m_result = callee; + return StackVisitor::Done; + } + +private: + JSObject* m_targetCallee; + bool m_hasFoundFrame; + bool m_hasSkippedToCallerFrame; + JSValue m_result; +}; + +static JSValue retrieveCallerFunction(ExecState* exec, JSFunction* functionObj) +{ + RetrieveCallerFunctionFunctor functor(functionObj); + exec->iterate(functor); + return functor.result(); } -JSValue JSFunction::callerGetter(ExecState* exec, JSValue slotBase, PropertyName) +EncodedJSValue JSFunction::callerGetter(ExecState* exec, JSObject* slotBase, EncodedJSValue, PropertyName) { JSFunction* thisObj = jsCast(slotBase); ASSERT(!thisObj->isHostFunction()); - JSValue caller = exec->interpreter()->retrieveCallerFromVMCode(exec, thisObj); + JSValue caller = retrieveCallerFunction(exec, thisObj); // See ES5.1 15.3.5.4 - Function.caller may not be used to retrieve a strict caller. - if (!caller.isObject() || !asObject(caller)->inherits(&JSFunction::s_info)) - return caller; + if (!caller.isObject() || !asObject(caller)->inherits(JSFunction::info())) { + // It isn't a JSFunction, but if it is a JSCallee from a program or call eval, return null. + if (jsDynamicCast(caller)) + return JSValue::encode(jsNull()); + return JSValue::encode(caller); + } JSFunction* function = jsCast(caller); - if (function->isHostFunction() || !function->jsExecutable()->isStrictMode()) - return caller; - return throwTypeError(exec, ASCIILiteral("Function.caller used to retrieve strict caller")); + if (function->isHostOrBuiltinFunction() || !function->jsExecutable()->isStrictMode()) + return JSValue::encode(caller); + return JSValue::encode(throwTypeError(exec, ASCIILiteral("Function.caller used to retrieve strict caller"))); } -JSValue JSFunction::lengthGetter(ExecState*, JSValue slotBase, PropertyName) +EncodedJSValue JSFunction::lengthGetter(ExecState*, JSObject* slotBase, EncodedJSValue, PropertyName) { JSFunction* thisObj = jsCast(slotBase); ASSERT(!thisObj->isHostFunction()); - return jsNumber(thisObj->jsExecutable()->parameterCount()); + return JSValue::encode(jsNumber(thisObj->jsExecutable()->parameterCount())); } -JSValue JSFunction::nameGetter(ExecState*, JSValue slotBase, PropertyName) +EncodedJSValue JSFunction::nameGetter(ExecState*, JSObject* slotBase, EncodedJSValue, PropertyName) { JSFunction* thisObj = jsCast(slotBase); ASSERT(!thisObj->isHostFunction()); - return thisObj->jsExecutable()->nameValue(); + return JSValue::encode(thisObj->jsExecutable()->nameValue()); } -bool JSFunction::getOwnPropertySlot(JSCell* cell, ExecState* exec, PropertyName propertyName, PropertySlot& slot) +bool JSFunction::getOwnPropertySlot(JSObject* object, ExecState* exec, PropertyName propertyName, PropertySlot& slot) { - JSFunction* thisObject = jsCast(cell); - if (thisObject->isHostFunction()) + JSFunction* thisObject = jsCast(object); + if (thisObject->isHostOrBuiltinFunction()) return Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); if (propertyName == exec->propertyNames().prototype) { VM& vm = exec->vm(); - PropertyOffset offset = thisObject->getDirectOffset(vm, propertyName); + unsigned attributes; + PropertyOffset offset = thisObject->getDirectOffset(vm, propertyName, attributes); if (!isValidOffset(offset)) { JSObject* prototype = constructEmptyObject(exec); prototype->putDirect(vm, exec->propertyNames().constructor, thisObject, DontEnum); thisObject->putDirect(vm, exec->propertyNames().prototype, prototype, DontDelete | DontEnum); - offset = thisObject->getDirectOffset(vm, exec->propertyNames().prototype); + offset = thisObject->getDirectOffset(vm, exec->propertyNames().prototype, attributes); ASSERT(isValidOffset(offset)); } - slot.setValue(thisObject, thisObject->getDirect(offset), offset); + slot.setValue(thisObject, attributes, thisObject->getDirect(offset), offset); } if (propertyName == exec->propertyNames().arguments) { if (thisObject->jsExecutable()->isStrictMode()) { bool result = Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); if (!result) { - thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); + thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec->vm()), DontDelete | DontEnum | Accessor); result = Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); ASSERT(result); } return result; } - slot.setCacheableCustom(thisObject, argumentsGetter); + slot.setCacheableCustom(thisObject, ReadOnly | DontEnum | DontDelete, argumentsGetter); return true; } if (propertyName == exec->propertyNames().length) { - slot.setCacheableCustom(thisObject, lengthGetter); + slot.setCacheableCustom(thisObject, ReadOnly | DontEnum | DontDelete, lengthGetter); return true; } if (propertyName == exec->propertyNames().name) { - slot.setCacheableCustom(thisObject, nameGetter); + slot.setCacheableCustom(thisObject, ReadOnly | DontEnum | DontDelete, nameGetter); return true; } @@ -262,84 +401,32 @@ bool JSFunction::getOwnPropertySlot(JSCell* cell, ExecState* exec, PropertyName if (thisObject->jsExecutable()->isStrictMode()) { bool result = Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); if (!result) { - thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); + thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec->vm()), DontDelete | DontEnum | Accessor); result = Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); ASSERT(result); } return result; } - slot.setCacheableCustom(thisObject, callerGetter); + slot.setCacheableCustom(thisObject, ReadOnly | DontEnum | DontDelete, callerGetter); return true; } return Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); } -bool JSFunction::getOwnPropertyDescriptor(JSObject* object, ExecState* exec, PropertyName propertyName, PropertyDescriptor& descriptor) -{ - JSFunction* thisObject = jsCast(object); - if (thisObject->isHostFunction()) - return Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - - if (propertyName == exec->propertyNames().prototype) { - PropertySlot slot; - thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, propertyName, slot); - return Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - } - - if (propertyName == exec->propertyNames().arguments) { - if (thisObject->jsExecutable()->isStrictMode()) { - bool result = Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - if (!result) { - thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); - result = Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - ASSERT(result); - } - return result; - } - descriptor.setDescriptor(exec->interpreter()->retrieveArgumentsFromVMCode(exec, thisObject), ReadOnly | DontEnum | DontDelete); - return true; - } - - if (propertyName == exec->propertyNames().length) { - descriptor.setDescriptor(jsNumber(thisObject->jsExecutable()->parameterCount()), ReadOnly | DontEnum | DontDelete); - return true; - } - - if (propertyName == exec->propertyNames().name) { - descriptor.setDescriptor(thisObject->jsExecutable()->nameValue(), ReadOnly | DontEnum | DontDelete); - return true; - } - - if (propertyName == exec->propertyNames().caller) { - if (thisObject->jsExecutable()->isStrictMode()) { - bool result = Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - if (!result) { - thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); - result = Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - ASSERT(result); - } - return result; - } - descriptor.setDescriptor(exec->interpreter()->retrieveCallerFromVMCode(exec, thisObject), ReadOnly | DontEnum | DontDelete); - return true; - } - - return Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); -} - void JSFunction::getOwnNonIndexPropertyNames(JSObject* object, ExecState* exec, PropertyNameArray& propertyNames, EnumerationMode mode) { JSFunction* thisObject = jsCast(object); - if (!thisObject->isHostFunction() && (mode == IncludeDontEnumProperties)) { + if (!thisObject->isHostOrBuiltinFunction() && mode.includeDontEnumProperties()) { + VM& vm = exec->vm(); // Make sure prototype has been reified. - PropertySlot slot; - thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, exec->propertyNames().prototype, slot); + PropertySlot slot(thisObject); + thisObject->methodTable(vm)->getOwnPropertySlot(thisObject, exec, vm.propertyNames->prototype, slot); - propertyNames.add(exec->propertyNames().arguments); - propertyNames.add(exec->propertyNames().caller); - propertyNames.add(exec->propertyNames().length); - propertyNames.add(exec->propertyNames().name); + propertyNames.add(vm.propertyNames->arguments); + propertyNames.add(vm.propertyNames->caller); + propertyNames.add(vm.propertyNames->length); + propertyNames.add(vm.propertyNames->name); } Base::getOwnNonIndexPropertyNames(thisObject, exec, propertyNames, mode); } @@ -347,19 +434,19 @@ void JSFunction::getOwnNonIndexPropertyNames(JSObject* object, ExecState* exec, void JSFunction::put(JSCell* cell, ExecState* exec, PropertyName propertyName, JSValue value, PutPropertySlot& slot) { JSFunction* thisObject = jsCast(cell); - if (thisObject->isHostFunction()) { + if (thisObject->isHostOrBuiltinFunction()) { Base::put(thisObject, exec, propertyName, value, slot); return; } if (propertyName == exec->propertyNames().prototype) { // Make sure prototype has been reified, such that it can only be overwritten // following the rules set out in ECMA-262 8.12.9. - PropertySlot slot; - thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, propertyName, slot); - thisObject->m_allocationProfile.clear(); - thisObject->m_allocationProfileWatchpoint.notifyWrite(); - // Don't allow this to be cached, since a [[Put]] must clear m_allocationProfile. - PutPropertySlot dontCache; + PropertySlot slot(thisObject); + thisObject->methodTable(exec->vm())->getOwnPropertySlot(thisObject, exec, propertyName, slot); + if (thisObject->m_rareData) + thisObject->m_rareData->clear("Store to prototype property of a function"); + // Don't allow this to be cached, since a [[Put]] must clear m_rareData. + PutPropertySlot dontCache(thisObject); Base::put(thisObject, exec, propertyName, value, dontCache); return; } @@ -382,7 +469,7 @@ bool JSFunction::deleteProperty(JSCell* cell, ExecState* exec, PropertyName prop { JSFunction* thisObject = jsCast(cell); // For non-host functions, don't let these properties by deleted - except by DefineOwnProperty. - if (!thisObject->isHostFunction() && !exec->vm().isInDefineOwnProperty() + if (!thisObject->isHostOrBuiltinFunction() && !exec->vm().isInDefineOwnProperty() && (propertyName == exec->propertyNames().arguments || propertyName == exec->propertyNames().length || propertyName == exec->propertyNames().name @@ -392,37 +479,39 @@ bool JSFunction::deleteProperty(JSCell* cell, ExecState* exec, PropertyName prop return Base::deleteProperty(thisObject, exec, propertyName); } -bool JSFunction::defineOwnProperty(JSObject* object, ExecState* exec, PropertyName propertyName, PropertyDescriptor& descriptor, bool throwException) +bool JSFunction::defineOwnProperty(JSObject* object, ExecState* exec, PropertyName propertyName, const PropertyDescriptor& descriptor, bool throwException) { JSFunction* thisObject = jsCast(object); - if (thisObject->isHostFunction()) + if (thisObject->isHostOrBuiltinFunction()) return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); if (propertyName == exec->propertyNames().prototype) { // Make sure prototype has been reified, such that it can only be overwritten // following the rules set out in ECMA-262 8.12.9. - PropertySlot slot; - thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, propertyName, slot); - thisObject->m_allocationProfile.clear(); - thisObject->m_allocationProfileWatchpoint.notifyWrite(); + PropertySlot slot(thisObject); + thisObject->methodTable(exec->vm())->getOwnPropertySlot(thisObject, exec, propertyName, slot); + if (thisObject->m_rareData) + thisObject->m_rareData->clear("Store to prototype property of a function"); return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); } bool valueCheck; if (propertyName == exec->propertyNames().arguments) { if (thisObject->jsExecutable()->isStrictMode()) { - if (!Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor)) - thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); + PropertySlot slot(thisObject); + if (!Base::getOwnPropertySlot(thisObject, exec, propertyName, slot)) + thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec->vm()), DontDelete | DontEnum | Accessor); return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); } - valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), exec->interpreter()->retrieveArgumentsFromVMCode(exec, thisObject)); + valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), retrieveArguments(exec, thisObject)); } else if (propertyName == exec->propertyNames().caller) { if (thisObject->jsExecutable()->isStrictMode()) { - if (!Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor)) - thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); + PropertySlot slot(thisObject); + if (!Base::getOwnPropertySlot(thisObject, exec, propertyName, slot)) + thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec->vm()), DontDelete | DontEnum | Accessor); return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); } - valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), exec->interpreter()->retrieveCallerFromVMCode(exec, thisObject)); + valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), retrieveCallerFunction(exec, thisObject)); } else if (propertyName == exec->propertyNames().length) valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), jsNumber(thisObject->jsExecutable()->parameterCount())); else if (propertyName == exec->propertyNames().name) @@ -432,27 +521,27 @@ bool JSFunction::defineOwnProperty(JSObject* object, ExecState* exec, PropertyNa if (descriptor.configurablePresent() && descriptor.configurable()) { if (throwException) - throwError(exec, createTypeError(exec, ASCIILiteral("Attempting to configurable attribute of unconfigurable property."))); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change configurable attribute of unconfigurable property."))); return false; } if (descriptor.enumerablePresent() && descriptor.enumerable()) { if (throwException) - throwError(exec, createTypeError(exec, ASCIILiteral("Attempting to change enumerable attribute of unconfigurable property."))); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change enumerable attribute of unconfigurable property."))); return false; } if (descriptor.isAccessorDescriptor()) { if (throwException) - throwError(exec, createTypeError(exec, ASCIILiteral("Attempting to change access mechanism for an unconfigurable property."))); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change access mechanism for an unconfigurable property."))); return false; } if (descriptor.writablePresent() && descriptor.writable()) { if (throwException) - throwError(exec, createTypeError(exec, ASCIILiteral("Attempting to change writable attribute of unconfigurable property."))); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change writable attribute of unconfigurable property."))); return false; } if (!valueCheck) { if (throwException) - throwError(exec, createTypeError(exec, ASCIILiteral("Attempting to change value of a readonly property."))); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change value of a readonly property."))); return false; } return true; @@ -462,6 +551,10 @@ bool JSFunction::defineOwnProperty(JSObject* object, ExecState* exec, PropertyNa ConstructType JSFunction::getConstructData(JSCell* cell, ConstructData& constructData) { JSFunction* thisObject = jsCast(cell); + + if (thisObject->isBuiltinFunction()) + return ConstructTypeNone; + if (thisObject->isHostFunction()) { constructData.native.function = thisObject->nativeConstructor(); return ConstructTypeHost;