X-Git-Url: https://git.saurik.com/apple/javascriptcore.git/blobdiff_plain/6fe7ccc865dc7d7541b93c5bcaf6368d2c98a174..ef99ff287df9046eb88937225e0554eabb00e33c:/runtime/JSFunction.cpp diff --git a/runtime/JSFunction.cpp b/runtime/JSFunction.cpp index 243946b..0f47ac9 100644 --- a/runtime/JSFunction.cpp +++ b/runtime/JSFunction.cpp @@ -25,6 +25,7 @@ #include "config.h" #include "JSFunction.h" +#include "Arguments.h" #include "CodeBlock.h" #include "CommonIdentifiers.h" #include "CallFrame.h" @@ -32,26 +33,26 @@ #include "FunctionPrototype.h" #include "GetterSetter.h" #include "JSArray.h" +#include "JSBoundFunction.h" +#include "JSFunctionInlines.h" #include "JSGlobalObject.h" +#include "JSNameScope.h" #include "JSNotAnObject.h" #include "Interpreter.h" +#include "ObjectConstructor.h" #include "ObjectPrototype.h" +#include "JSCInlines.h" #include "Parser.h" #include "PropertyNameArray.h" -#include "ScopeChainMark.h" - -using namespace WTF; -using namespace Unicode; +#include "StackVisitor.h" namespace JSC { + EncodedJSValue JSC_HOST_CALL callHostFunctionAsConstructor(ExecState* exec) { return throwVMError(exec, createNotAConstructorError(exec, exec->callee())); } -ASSERT_CLASS_FITS_IN_CELL(JSFunction); -ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSFunction); - const ClassInfo JSFunction::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSFunction) }; bool JSFunction::isHostFunctionNonInline() const @@ -59,106 +60,131 @@ bool JSFunction::isHostFunctionNonInline() const return isHostFunction(); } -JSFunction* JSFunction::create(ExecState* exec, JSGlobalObject* globalObject, int length, const Identifier& name, NativeFunction nativeFunction, Intrinsic intrinsic, NativeFunction nativeConstructor) +JSFunction* JSFunction::create(VM& vm, JSGlobalObject* globalObject, int length, const String& name, NativeFunction nativeFunction, Intrinsic intrinsic, NativeFunction nativeConstructor) { NativeExecutable* executable; #if !ENABLE(JIT) UNUSED_PARAM(intrinsic); #else - if (intrinsic != NoIntrinsic && exec->globalData().canUseJIT()) { + if (intrinsic != NoIntrinsic && vm.canUseJIT()) { ASSERT(nativeConstructor == callHostFunctionAsConstructor); - executable = exec->globalData().getHostFunction(nativeFunction, intrinsic); + executable = vm.getHostFunction(nativeFunction, intrinsic); } else #endif - executable = exec->globalData().getHostFunction(nativeFunction, nativeConstructor); + executable = vm.getHostFunction(nativeFunction, nativeConstructor); - JSFunction* function = new (NotNull, allocateCell(*exec->heap())) JSFunction(exec, globalObject, globalObject->functionStructure()); + JSFunction* function = new (NotNull, allocateCell(vm.heap)) JSFunction(vm, globalObject, globalObject->functionStructure()); // Can't do this during initialization because getHostFunction might do a GC allocation. - function->finishCreation(exec, executable, length, name); + function->finishCreation(vm, executable, length, name); return function; } -JSFunction::JSFunction(ExecState* exec, JSGlobalObject* globalObject, Structure* structure) - : Base(exec->globalData(), structure) +void JSFunction::destroy(JSCell* cell) +{ + static_cast(cell)->JSFunction::~JSFunction(); +} + +JSFunction::JSFunction(VM& vm, JSGlobalObject* globalObject, Structure* structure) + : Base(vm, structure) , m_executable() - , m_scopeChain(exec->globalData(), this, globalObject->globalScopeChain()) + , m_scope(vm, this, globalObject) + // We initialize blind so that changes to the prototype after function creation but before + // the optimizer kicks in don't disable optimizations. Once the optimizer kicks in, the + // watchpoint will start watching and any changes will both force deoptimization and disable + // future attempts to optimize. This is necessary because we are guaranteed that the + // allocation profile is changed exactly once prior to optimizations kicking in. We could be + // smarter and count the number of times the prototype is clobbered and only optimize if it + // was clobbered exactly once, but that seems like overkill. In almost all cases it will be + // clobbered once, and if it's clobbered more than once, that will probably only occur + // before we started optimizing, anyway. + , m_allocationProfileWatchpoint(ClearWatchpoint) { } -JSFunction::JSFunction(ExecState* exec, FunctionExecutable* executable, ScopeChainNode* scopeChainNode) - : Base(exec->globalData(), scopeChainNode->globalObject->functionStructure()) - , m_executable(exec->globalData(), this, executable) - , m_scopeChain(exec->globalData(), this, scopeChainNode) +void JSFunction::finishCreation(VM& vm, NativeExecutable* executable, int length, const String& name) { + Base::finishCreation(vm); + ASSERT(inherits(info())); + m_executable.set(vm, this, executable); + putDirect(vm, vm.propertyNames->name, jsString(&vm, name), DontDelete | ReadOnly | DontEnum); + putDirect(vm, vm.propertyNames->length, jsNumber(length), DontDelete | ReadOnly | DontEnum); } -void JSFunction::finishCreation(ExecState* exec, NativeExecutable* executable, int length, const Identifier& name) +void JSFunction::addNameScopeIfNeeded(VM& vm) { - Base::finishCreation(exec->globalData()); - ASSERT(inherits(&s_info)); - m_executable.set(exec->globalData(), this, executable); - putDirect(exec->globalData(), exec->globalData().propertyNames->name, jsString(exec, name.isNull() ? "" : name.ustring()), DontDelete | ReadOnly | DontEnum); - putDirect(exec->globalData(), exec->propertyNames().length, jsNumber(length), DontDelete | ReadOnly | DontEnum); + FunctionExecutable* executable = jsCast(m_executable.get()); + if (!functionNameIsInScope(executable->name(), executable->functionMode())) + return; + if (!functionNameScopeIsDynamic(executable->usesEval(), executable->isStrictMode())) + return; + m_scope.set(vm, this, JSNameScope::create(vm, m_scope->globalObject(), executable->name(), this, ReadOnly | DontDelete, m_scope.get())); } -void JSFunction::finishCreation(ExecState* exec, FunctionExecutable* executable, ScopeChainNode* scopeChainNode) +JSFunction* JSFunction::createBuiltinFunction(VM& vm, FunctionExecutable* executable, JSGlobalObject* globalObject) { - Base::finishCreation(exec->globalData()); - ASSERT(inherits(&s_info)); + JSFunction* function = create(vm, executable, globalObject); + function->putDirect(vm, vm.propertyNames->name, jsString(&vm, executable->name().string()), DontDelete | ReadOnly | DontEnum); + function->putDirect(vm, vm.propertyNames->length, jsNumber(executable->parameterCount()), DontDelete | ReadOnly | DontEnum); + return function; +} - // Switching the structure here is only safe if we currently have the function structure! - ASSERT(structure() == scopeChainNode->globalObject->functionStructure()); - setStructure(exec->globalData(), scopeChainNode->globalObject->namedFunctionStructure()); - putDirectOffset(exec->globalData(), scopeChainNode->globalObject->functionNameOffset(), executable->nameValue()); +ObjectAllocationProfile* JSFunction::createAllocationProfile(ExecState* exec, size_t inlineCapacity) +{ + VM& vm = exec->vm(); + JSObject* prototype = jsDynamicCast(get(exec, vm.propertyNames->prototype)); + if (!prototype) + prototype = globalObject()->objectPrototype(); + m_allocationProfile.initialize(globalObject()->vm(), this, prototype, inlineCapacity); + return &m_allocationProfile; } -const UString& JSFunction::name(ExecState* exec) +String JSFunction::name(ExecState* exec) { - return asString(getDirect(exec->globalData(), exec->globalData().propertyNames->name))->tryGetValue(); + return get(exec, exec->vm().propertyNames->name).toWTFString(exec); } -const UString JSFunction::displayName(ExecState* exec) +String JSFunction::displayName(ExecState* exec) { - JSValue displayName = getDirect(exec->globalData(), exec->globalData().propertyNames->displayName); + JSValue displayName = getDirect(exec->vm(), exec->vm().propertyNames->displayName); if (displayName && isJSString(displayName)) return asString(displayName)->tryGetValue(); - return UString(); + return String(); } -const UString JSFunction::calculatedDisplayName(ExecState* exec) +const String JSFunction::calculatedDisplayName(ExecState* exec) { - const UString explicitName = displayName(exec); + const String explicitName = displayName(exec); if (!explicitName.isEmpty()) return explicitName; - const UString actualName = name(exec); - if (!actualName.isEmpty() || isHostFunction()) + const String actualName = name(exec); + if (!actualName.isEmpty() || isHostOrBuiltinFunction()) return actualName; - return jsExecutable()->inferredName().ustring(); + return jsExecutable()->inferredName().string(); } const SourceCode* JSFunction::sourceCode() const { - if (isHostFunction()) + if (isHostOrBuiltinFunction()) return 0; return &jsExecutable()->source(); } - + void JSFunction::visitChildren(JSCell* cell, SlotVisitor& visitor) { JSFunction* thisObject = jsCast(cell); - ASSERT_GC_OBJECT_INHERITS(thisObject, &s_info); + ASSERT_GC_OBJECT_INHERITS(thisObject, info()); COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag); ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren()); Base::visitChildren(thisObject, visitor); - visitor.append(&thisObject->m_scopeChain); - if (thisObject->m_executable) - visitor.append(&thisObject->m_executable); + visitor.append(&thisObject->m_scope); + visitor.append(&thisObject->m_executable); + thisObject->m_allocationProfile.visitAggregate(visitor); } CallType JSFunction::getCallData(JSCell* cell, CallData& callData) @@ -169,74 +195,168 @@ CallType JSFunction::getCallData(JSCell* cell, CallData& callData) return CallTypeHost; } callData.js.functionExecutable = thisObject->jsExecutable(); - callData.js.scopeChain = thisObject->scope(); + callData.js.scope = thisObject->scope(); return CallTypeJS; } -JSValue JSFunction::argumentsGetter(ExecState* exec, JSValue slotBase, const Identifier&) +class RetrieveArgumentsFunctor { +public: + RetrieveArgumentsFunctor(JSFunction* functionObj) + : m_targetCallee(jsDynamicCast(functionObj)) + , m_result(jsNull()) + { + } + + JSValue result() const { return m_result; } + + StackVisitor::Status operator()(StackVisitor& visitor) + { + JSObject* callee = visitor->callee(); + if (callee != m_targetCallee) + return StackVisitor::Continue; + + m_result = JSValue(visitor->createArguments()); + return StackVisitor::Done; + } + +private: + JSObject* m_targetCallee; + JSValue m_result; +}; + +static JSValue retrieveArguments(ExecState* exec, JSFunction* functionObj) +{ + RetrieveArgumentsFunctor functor(functionObj); + exec->iterate(functor); + return functor.result(); +} + +EncodedJSValue JSFunction::argumentsGetter(ExecState* exec, JSObject* slotBase, EncodedJSValue, PropertyName) { JSFunction* thisObj = jsCast(slotBase); ASSERT(!thisObj->isHostFunction()); - return exec->interpreter()->retrieveArgumentsFromVMCode(exec, thisObj); + + return JSValue::encode(retrieveArguments(exec, thisObj)); } -JSValue JSFunction::callerGetter(ExecState* exec, JSValue slotBase, const Identifier&) +class RetrieveCallerFunctionFunctor { +public: + RetrieveCallerFunctionFunctor(JSFunction* functionObj) + : m_targetCallee(jsDynamicCast(functionObj)) + , m_hasFoundFrame(false) + , m_hasSkippedToCallerFrame(false) + , m_result(jsNull()) + { + } + + JSValue result() const { return m_result; } + + StackVisitor::Status operator()(StackVisitor& visitor) + { + JSObject* callee = visitor->callee(); + + if (callee && callee->inherits(JSBoundFunction::info())) + return StackVisitor::Continue; + + if (!m_hasFoundFrame && (callee != m_targetCallee)) + return StackVisitor::Continue; + + m_hasFoundFrame = true; + if (!m_hasSkippedToCallerFrame) { + m_hasSkippedToCallerFrame = true; + return StackVisitor::Continue; + } + + if (callee) + m_result = callee; + return StackVisitor::Done; + } + +private: + JSObject* m_targetCallee; + bool m_hasFoundFrame; + bool m_hasSkippedToCallerFrame; + JSValue m_result; +}; + +static JSValue retrieveCallerFunction(ExecState* exec, JSFunction* functionObj) +{ + RetrieveCallerFunctionFunctor functor(functionObj); + exec->iterate(functor); + return functor.result(); +} + +EncodedJSValue JSFunction::callerGetter(ExecState* exec, JSObject* slotBase, EncodedJSValue, PropertyName) { JSFunction* thisObj = jsCast(slotBase); ASSERT(!thisObj->isHostFunction()); - JSValue caller = exec->interpreter()->retrieveCallerFromVMCode(exec, thisObj); + JSValue caller = retrieveCallerFunction(exec, thisObj); // See ES5.1 15.3.5.4 - Function.caller may not be used to retrieve a strict caller. - if (!caller.isObject() || !asObject(caller)->inherits(&JSFunction::s_info)) - return caller; + if (!caller.isObject() || !asObject(caller)->inherits(JSFunction::info())) + return JSValue::encode(caller); JSFunction* function = jsCast(caller); - if (function->isHostFunction() || !function->jsExecutable()->isStrictMode()) - return caller; - return throwTypeError(exec, "Function.caller used to retrieve strict caller"); + if (function->isHostOrBuiltinFunction() || !function->jsExecutable()->isStrictMode()) + return JSValue::encode(caller); + return JSValue::encode(throwTypeError(exec, ASCIILiteral("Function.caller used to retrieve strict caller"))); } -JSValue JSFunction::lengthGetter(ExecState*, JSValue slotBase, const Identifier&) +EncodedJSValue JSFunction::lengthGetter(ExecState*, JSObject* slotBase, EncodedJSValue, PropertyName) { JSFunction* thisObj = jsCast(slotBase); ASSERT(!thisObj->isHostFunction()); - return jsNumber(thisObj->jsExecutable()->parameterCount()); + return JSValue::encode(jsNumber(thisObj->jsExecutable()->parameterCount())); } -bool JSFunction::getOwnPropertySlot(JSCell* cell, ExecState* exec, const Identifier& propertyName, PropertySlot& slot) +EncodedJSValue JSFunction::nameGetter(ExecState*, JSObject* slotBase, EncodedJSValue, PropertyName) { - JSFunction* thisObject = jsCast(cell); - if (thisObject->isHostFunction()) + JSFunction* thisObj = jsCast(slotBase); + ASSERT(!thisObj->isHostFunction()); + return JSValue::encode(thisObj->jsExecutable()->nameValue()); +} + +bool JSFunction::getOwnPropertySlot(JSObject* object, ExecState* exec, PropertyName propertyName, PropertySlot& slot) +{ + JSFunction* thisObject = jsCast(object); + if (thisObject->isHostOrBuiltinFunction()) return Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); if (propertyName == exec->propertyNames().prototype) { - WriteBarrierBase* location = thisObject->getDirectLocation(exec->globalData(), propertyName); - - if (!location) { - JSObject* prototype = constructEmptyObject(exec, thisObject->globalObject()->emptyObjectStructure()); - prototype->putDirect(exec->globalData(), exec->propertyNames().constructor, thisObject, DontEnum); - thisObject->putDirect(exec->globalData(), exec->propertyNames().prototype, prototype, DontDelete | DontEnum); - location = thisObject->getDirectLocation(exec->globalData(), exec->propertyNames().prototype); + VM& vm = exec->vm(); + unsigned attributes; + PropertyOffset offset = thisObject->getDirectOffset(vm, propertyName, attributes); + if (!isValidOffset(offset)) { + JSObject* prototype = constructEmptyObject(exec); + prototype->putDirect(vm, exec->propertyNames().constructor, thisObject, DontEnum); + thisObject->putDirect(vm, exec->propertyNames().prototype, prototype, DontDelete | DontEnum); + offset = thisObject->getDirectOffset(vm, exec->propertyNames().prototype, attributes); + ASSERT(isValidOffset(offset)); } - slot.setValue(thisObject, location->get(), thisObject->offsetForLocation(location)); + slot.setValue(thisObject, attributes, thisObject->getDirect(offset), offset); } if (propertyName == exec->propertyNames().arguments) { if (thisObject->jsExecutable()->isStrictMode()) { bool result = Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); if (!result) { - thisObject->putDirectAccessor(exec->globalData(), propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); + thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec->vm()), DontDelete | DontEnum | Accessor); result = Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); ASSERT(result); } return result; } - slot.setCacheableCustom(thisObject, argumentsGetter); + slot.setCacheableCustom(thisObject, ReadOnly | DontEnum | DontDelete, argumentsGetter); return true; } if (propertyName == exec->propertyNames().length) { - slot.setCacheableCustom(thisObject, lengthGetter); + slot.setCacheableCustom(thisObject, ReadOnly | DontEnum | DontDelete, lengthGetter); + return true; + } + + if (propertyName == exec->propertyNames().name) { + slot.setCacheableCustom(thisObject, ReadOnly | DontEnum | DontDelete, nameGetter); return true; } @@ -244,94 +364,54 @@ bool JSFunction::getOwnPropertySlot(JSCell* cell, ExecState* exec, const Identif if (thisObject->jsExecutable()->isStrictMode()) { bool result = Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); if (!result) { - thisObject->putDirectAccessor(exec->globalData(), propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); + thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec->vm()), DontDelete | DontEnum | Accessor); result = Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); ASSERT(result); } return result; } - slot.setCacheableCustom(thisObject, callerGetter); + slot.setCacheableCustom(thisObject, ReadOnly | DontEnum | DontDelete, callerGetter); return true; } return Base::getOwnPropertySlot(thisObject, exec, propertyName, slot); } -bool JSFunction::getOwnPropertyDescriptor(JSObject* object, ExecState* exec, const Identifier& propertyName, PropertyDescriptor& descriptor) -{ - JSFunction* thisObject = jsCast(object); - if (thisObject->isHostFunction()) - return Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - - if (propertyName == exec->propertyNames().prototype) { - PropertySlot slot; - thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, propertyName, slot); - return Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - } - - if (propertyName == exec->propertyNames().arguments) { - if (thisObject->jsExecutable()->isStrictMode()) { - bool result = Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - if (!result) { - thisObject->putDirectAccessor(exec->globalData(), propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); - result = Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - ASSERT(result); - } - return result; - } - descriptor.setDescriptor(exec->interpreter()->retrieveArgumentsFromVMCode(exec, thisObject), ReadOnly | DontEnum | DontDelete); - return true; - } - - if (propertyName == exec->propertyNames().length) { - descriptor.setDescriptor(jsNumber(thisObject->jsExecutable()->parameterCount()), ReadOnly | DontEnum | DontDelete); - return true; - } - - if (propertyName == exec->propertyNames().caller) { - if (thisObject->jsExecutable()->isStrictMode()) { - bool result = Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - if (!result) { - thisObject->putDirectAccessor(exec->globalData(), propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); - result = Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); - ASSERT(result); - } - return result; - } - descriptor.setDescriptor(exec->interpreter()->retrieveCallerFromVMCode(exec, thisObject), ReadOnly | DontEnum | DontDelete); - return true; - } - - return Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor); -} - -void JSFunction::getOwnPropertyNames(JSObject* object, ExecState* exec, PropertyNameArray& propertyNames, EnumerationMode mode) +void JSFunction::getOwnNonIndexPropertyNames(JSObject* object, ExecState* exec, PropertyNameArray& propertyNames, EnumerationMode mode) { JSFunction* thisObject = jsCast(object); - if (!thisObject->isHostFunction() && (mode == IncludeDontEnumProperties)) { + if (!thisObject->isHostOrBuiltinFunction() && (mode == IncludeDontEnumProperties)) { + VM& vm = exec->vm(); // Make sure prototype has been reified. - PropertySlot slot; - thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, exec->propertyNames().prototype, slot); + PropertySlot slot(thisObject); + thisObject->methodTable(vm)->getOwnPropertySlot(thisObject, exec, vm.propertyNames->prototype, slot); - propertyNames.add(exec->propertyNames().arguments); - propertyNames.add(exec->propertyNames().caller); - propertyNames.add(exec->propertyNames().length); + propertyNames.add(vm.propertyNames->arguments); + propertyNames.add(vm.propertyNames->caller); + propertyNames.add(vm.propertyNames->length); + propertyNames.add(vm.propertyNames->name); } - Base::getOwnPropertyNames(thisObject, exec, propertyNames, mode); + Base::getOwnNonIndexPropertyNames(thisObject, exec, propertyNames, mode); } -void JSFunction::put(JSCell* cell, ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot) +void JSFunction::put(JSCell* cell, ExecState* exec, PropertyName propertyName, JSValue value, PutPropertySlot& slot) { JSFunction* thisObject = jsCast(cell); - if (thisObject->isHostFunction()) { + if (thisObject->isHostOrBuiltinFunction()) { Base::put(thisObject, exec, propertyName, value, slot); return; } if (propertyName == exec->propertyNames().prototype) { // Make sure prototype has been reified, such that it can only be overwritten // following the rules set out in ECMA-262 8.12.9. - PropertySlot slot; - thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, propertyName, slot); + PropertySlot slot(thisObject); + thisObject->methodTable(exec->vm())->getOwnPropertySlot(thisObject, exec, propertyName, slot); + thisObject->m_allocationProfile.clear(); + thisObject->m_allocationProfileWatchpoint.fireAll(); + // Don't allow this to be cached, since a [[Put]] must clear m_allocationProfile. + PutPropertySlot dontCache(thisObject); + Base::put(thisObject, exec, propertyName, value, dontCache); + return; } if (thisObject->jsExecutable()->isStrictMode() && (propertyName == exec->propertyNames().arguments || propertyName == exec->propertyNames().caller)) { // This will trigger the property to be reified, if this is not already the case! @@ -340,7 +420,7 @@ void JSFunction::put(JSCell* cell, ExecState* exec, const Identifier& propertyNa Base::put(thisObject, exec, propertyName, value, slot); return; } - if (propertyName == exec->propertyNames().arguments || propertyName == exec->propertyNames().length || propertyName == exec->propertyNames().caller) { + if (propertyName == exec->propertyNames().arguments || propertyName == exec->propertyNames().length || propertyName == exec->propertyNames().name || propertyName == exec->propertyNames().caller) { if (slot.isStrictMode()) throwTypeError(exec, StrictModeReadonlyPropertyWriteError); return; @@ -348,76 +428,83 @@ void JSFunction::put(JSCell* cell, ExecState* exec, const Identifier& propertyNa Base::put(thisObject, exec, propertyName, value, slot); } -bool JSFunction::deleteProperty(JSCell* cell, ExecState* exec, const Identifier& propertyName) +bool JSFunction::deleteProperty(JSCell* cell, ExecState* exec, PropertyName propertyName) { JSFunction* thisObject = jsCast(cell); // For non-host functions, don't let these properties by deleted - except by DefineOwnProperty. - if (!thisObject->isHostFunction() && !exec->globalData().isInDefineOwnProperty() + if (!thisObject->isHostOrBuiltinFunction() && !exec->vm().isInDefineOwnProperty() && (propertyName == exec->propertyNames().arguments || propertyName == exec->propertyNames().length + || propertyName == exec->propertyNames().name || propertyName == exec->propertyNames().prototype || propertyName == exec->propertyNames().caller)) return false; return Base::deleteProperty(thisObject, exec, propertyName); } -bool JSFunction::defineOwnProperty(JSObject* object, ExecState* exec, const Identifier& propertyName, PropertyDescriptor& descriptor, bool throwException) +bool JSFunction::defineOwnProperty(JSObject* object, ExecState* exec, PropertyName propertyName, const PropertyDescriptor& descriptor, bool throwException) { JSFunction* thisObject = jsCast(object); - if (thisObject->isHostFunction()) + if (thisObject->isHostOrBuiltinFunction()) return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); if (propertyName == exec->propertyNames().prototype) { // Make sure prototype has been reified, such that it can only be overwritten // following the rules set out in ECMA-262 8.12.9. - PropertySlot slot; - thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, propertyName, slot); + PropertySlot slot(thisObject); + thisObject->methodTable(exec->vm())->getOwnPropertySlot(thisObject, exec, propertyName, slot); + thisObject->m_allocationProfile.clear(); + thisObject->m_allocationProfileWatchpoint.fireAll(); return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); } bool valueCheck; if (propertyName == exec->propertyNames().arguments) { if (thisObject->jsExecutable()->isStrictMode()) { - if (!Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor)) - thisObject->putDirectAccessor(exec->globalData(), propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); + PropertySlot slot(thisObject); + if (!Base::getOwnPropertySlot(thisObject, exec, propertyName, slot)) + thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec->vm()), DontDelete | DontEnum | Accessor); return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); } - valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), exec->interpreter()->retrieveArgumentsFromVMCode(exec, thisObject)); + valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), retrieveArguments(exec, thisObject)); } else if (propertyName == exec->propertyNames().caller) { if (thisObject->jsExecutable()->isStrictMode()) { - if (!Base::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor)) - thisObject->putDirectAccessor(exec->globalData(), propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec), DontDelete | DontEnum | Accessor); + PropertySlot slot(thisObject); + if (!Base::getOwnPropertySlot(thisObject, exec, propertyName, slot)) + thisObject->putDirectAccessor(exec, propertyName, thisObject->globalObject()->throwTypeErrorGetterSetter(exec->vm()), DontDelete | DontEnum | Accessor); return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); } - valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), exec->interpreter()->retrieveCallerFromVMCode(exec, thisObject)); + valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), retrieveCallerFunction(exec, thisObject)); } else if (propertyName == exec->propertyNames().length) valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), jsNumber(thisObject->jsExecutable()->parameterCount())); + else if (propertyName == exec->propertyNames().name) + valueCheck = !descriptor.value() || sameValue(exec, descriptor.value(), thisObject->jsExecutable()->nameValue()); else return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException); if (descriptor.configurablePresent() && descriptor.configurable()) { if (throwException) - throwError(exec, createTypeError(exec, "Attempting to configurable attribute of unconfigurable property.")); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to configurable attribute of unconfigurable property."))); return false; } if (descriptor.enumerablePresent() && descriptor.enumerable()) { if (throwException) - throwError(exec, createTypeError(exec, "Attempting to change enumerable attribute of unconfigurable property.")); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change enumerable attribute of unconfigurable property."))); return false; } if (descriptor.isAccessorDescriptor()) { if (throwException) - throwError(exec, createTypeError(exec, "Attempting to change access mechanism for an unconfigurable property.")); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change access mechanism for an unconfigurable property."))); return false; } if (descriptor.writablePresent() && descriptor.writable()) { if (throwException) - throwError(exec, createTypeError(exec, "Attempting to change writable attribute of unconfigurable property.")); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change writable attribute of unconfigurable property."))); return false; } if (!valueCheck) { if (throwException) - throwError(exec, createTypeError(exec, "Attempting to change value of a readonly property.")); + exec->vm().throwException(exec, createTypeError(exec, ASCIILiteral("Attempting to change value of a readonly property."))); return false; } return true; @@ -432,18 +519,17 @@ ConstructType JSFunction::getConstructData(JSCell* cell, ConstructData& construc return ConstructTypeHost; } constructData.js.functionExecutable = thisObject->jsExecutable(); - constructData.js.scopeChain = thisObject->scope(); + constructData.js.scope = thisObject->scope(); return ConstructTypeJS; } - -UString getCalculatedDisplayName(CallFrame* callFrame, JSObject* object) +String getCalculatedDisplayName(CallFrame* callFrame, JSObject* object) { if (JSFunction* function = jsDynamicCast(object)) return function->calculatedDisplayName(callFrame); if (InternalFunction* function = jsDynamicCast(object)) return function->calculatedDisplayName(callFrame); - return callFrame->globalData().propertyNames->emptyIdentifier.ustring(); + return ""; } } // namespace JSC