X-Git-Url: https://git.saurik.com/apple/javascriptcore.git/blobdiff_plain/14957cd040308e3eeec43d26bae5d76da13fcd85..12899fa232562c774004a3a9d7d3149944dec712:/runtime/JSONObject.cpp diff --git a/runtime/JSONObject.cpp b/runtime/JSONObject.cpp index 8d261a2..91b412e 100644 --- a/runtime/JSONObject.cpp +++ b/runtime/JSONObject.cpp @@ -35,14 +35,15 @@ #include "Local.h" #include "LocalScope.h" #include "Lookup.h" +#include "ObjectConstructor.h" +#include "Operations.h" #include "PropertyNameArray.h" -#include "UStringBuilder.h" -#include "UStringConcatenate.h" #include +#include namespace JSC { -ASSERT_CLASS_FITS_IN_CELL(JSONObject); +ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSONObject); static EncodedJSValue JSC_HOST_CALL JSONProtoFuncParse(ExecState*); static EncodedJSValue JSC_HOST_CALL JSONProtoFuncStringify(ExecState*); @@ -54,8 +55,13 @@ static EncodedJSValue JSC_HOST_CALL JSONProtoFuncStringify(ExecState*); namespace JSC { JSONObject::JSONObject(JSGlobalObject* globalObject, Structure* structure) - : JSObjectWithGlobalObject(globalObject, structure) + : JSNonFinalObject(globalObject->vm(), structure) { +} + +void JSONObject::finishCreation(JSGlobalObject* globalObject) +{ + Base::finishCreation(globalObject->vm()); ASSERT(inherits(&s_info)); } @@ -84,11 +90,11 @@ public: private: class Holder { public: - Holder(JSGlobalData&, JSObject*); + Holder(VM&, JSObject*); JSObject* object() const { return m_object.get(); } - bool appendNextProperty(Stringifier&, UStringBuilder&); + bool appendNextProperty(Stringifier&, StringBuilder&); private: Local m_object; @@ -101,17 +107,17 @@ private: friend class Holder; - static void appendQuotedString(UStringBuilder&, const UString&); + static void appendQuotedString(StringBuilder&, const String&); JSValue toJSON(JSValue, const PropertyNameForFunctionCall&); enum StringifyResult { StringifyFailed, StringifySucceeded, StringifyFailedDueToUndefinedValue }; - StringifyResult appendStringifiedValue(UStringBuilder&, JSValue, JSObject* holder, const PropertyNameForFunctionCall&); + StringifyResult appendStringifiedValue(StringBuilder&, JSValue, JSObject* holder, const PropertyNameForFunctionCall&); bool willIndent() const; void indent(); void unindent(); - void startNewLine(UStringBuilder&) const; + void startNewLine(StringBuilder&) const; ExecState* const m_exec; const Local m_replacer; @@ -119,11 +125,11 @@ private: PropertyNameArray m_arrayReplacerPropertyNames; CallType m_replacerCallType; CallData m_replacerCallData; - const UString m_gap; + const String m_gap; - Vector m_holderStack; - UString m_repeatedGap; - UString m_indent; + Vector m_holderStack; + String m_repeatedGap; + String m_indent; }; // ------------------------------ helper functions -------------------------------- @@ -136,20 +142,20 @@ static inline JSValue unwrapBoxedPrimitive(ExecState* exec, JSValue value) if (object->inherits(&NumberObject::s_info)) return jsNumber(object->toNumber(exec)); if (object->inherits(&StringObject::s_info)) - return jsString(exec, object->toString(exec)); + return object->toString(exec); if (object->inherits(&BooleanObject::s_info)) return object->toPrimitive(exec); return value; } -static inline UString gap(ExecState* exec, JSValue space) +static inline String gap(ExecState* exec, JSValue space) { const unsigned maxGapLength = 10; space = unwrapBoxedPrimitive(exec, space); // If the space value is a number, create a gap string with that number of spaces. - double spaceCount; - if (space.getNumber(spaceCount)) { + if (space.isNumber()) { + double spaceCount = space.asNumber(); int count; if (spaceCount > maxGapLength) count = maxGapLength; @@ -160,11 +166,11 @@ static inline UString gap(ExecState* exec, JSValue space) UChar spaces[maxGapLength]; for (int i = 0; i < count; ++i) spaces[i] = ' '; - return UString(spaces, count); + return String(spaces, count); } // If the space value is a string, use it as the gap string, otherwise use no gap string. - UString spaces = space.getString(exec); + String spaces = space.getString(exec); if (spaces.length() > maxGapLength) { spaces = spaces.substringSharingImpl(0, maxGapLength); } @@ -188,7 +194,7 @@ JSValue PropertyNameForFunctionCall::value(ExecState* exec) const { if (!m_value) { if (m_identifier) - m_value = jsString(exec, m_identifier->ustring()); + m_value = jsString(exec, m_identifier->string()); else m_value = jsNumber(m_number); } @@ -211,64 +217,46 @@ Stringifier::Stringifier(ExecState* exec, const Local& replacer, const if (m_replacer.asObject()->inherits(&JSArray::s_info)) { m_usingArrayReplacer = true; Handle array = m_replacer.asObject(); - unsigned length = array->get(exec, exec->globalData().propertyNames->length).toUInt32(exec); + unsigned length = array->get(exec, exec->vm().propertyNames->length).toUInt32(exec); for (unsigned i = 0; i < length; ++i) { JSValue name = array->get(exec, i); if (exec->hadException()) break; - UString propertyName; - if (name.getString(exec, propertyName)) { - m_arrayReplacerPropertyNames.add(Identifier(exec, propertyName)); - continue; - } - - double value = 0; - if (name.getNumber(value)) { - m_arrayReplacerPropertyNames.add(Identifier::from(exec, value)); - continue; - } - if (name.isObject()) { if (!asObject(name)->inherits(&NumberObject::s_info) && !asObject(name)->inherits(&StringObject::s_info)) continue; - propertyName = name.toString(exec); - if (exec->hadException()) - break; - m_arrayReplacerPropertyNames.add(Identifier(exec, propertyName)); } + + m_arrayReplacerPropertyNames.add(Identifier(exec, name.toString(exec)->value(exec))); } return; } - m_replacerCallType = m_replacer.asObject()->getCallData(m_replacerCallData); + m_replacerCallType = m_replacer.asObject()->methodTable()->getCallData(m_replacer.asObject().get(), m_replacerCallData); } Local Stringifier::stringify(Handle value) { JSObject* object = constructEmptyObject(m_exec); if (m_exec->hadException()) - return Local(m_exec->globalData(), jsNull()); + return Local(m_exec->vm(), jsNull()); - PropertyNameForFunctionCall emptyPropertyName(m_exec->globalData().propertyNames->emptyIdentifier); - object->putDirect(m_exec->globalData(), m_exec->globalData().propertyNames->emptyIdentifier, value.get()); + PropertyNameForFunctionCall emptyPropertyName(m_exec->vm().propertyNames->emptyIdentifier); + object->putDirect(m_exec->vm(), m_exec->vm().propertyNames->emptyIdentifier, value.get()); - UStringBuilder result; + StringBuilder result; if (appendStringifiedValue(result, value.get(), object, emptyPropertyName) != StringifySucceeded) - return Local(m_exec->globalData(), jsUndefined()); + return Local(m_exec->vm(), jsUndefined()); if (m_exec->hadException()) - return Local(m_exec->globalData(), jsNull()); + return Local(m_exec->vm(), jsNull()); - return Local(m_exec->globalData(), jsString(m_exec, result.toUString())); + return Local(m_exec->vm(), jsString(m_exec, result.toString())); } -void Stringifier::appendQuotedString(UStringBuilder& builder, const UString& value) +template +static void appendStringToStringBuilder(StringBuilder& builder, const CharType* data, int length) { - int length = value.length(); - - builder.append('"'); - - const UChar* data = value.characters(); for (int i = 0; i < length; ++i) { int start = i; while (i < length && (data[i] > 0x1F && data[i] != '"' && data[i] != '\\')) @@ -277,42 +265,54 @@ void Stringifier::appendQuotedString(UStringBuilder& builder, const UString& val if (i >= length) break; switch (data[i]) { - case '\t': - builder.append('\\'); - builder.append('t'); - break; - case '\r': - builder.append('\\'); - builder.append('r'); - break; - case '\n': - builder.append('\\'); - builder.append('n'); - break; - case '\f': - builder.append('\\'); - builder.append('f'); - break; - case '\b': - builder.append('\\'); - builder.append('b'); - break; - case '"': - builder.append('\\'); - builder.append('"'); - break; - case '\\': - builder.append('\\'); - builder.append('\\'); - break; - default: - static const char hexDigits[] = "0123456789abcdef"; - UChar ch = data[i]; - UChar hex[] = { '\\', 'u', hexDigits[(ch >> 12) & 0xF], hexDigits[(ch >> 8) & 0xF], hexDigits[(ch >> 4) & 0xF], hexDigits[ch & 0xF] }; - builder.append(hex, WTF_ARRAY_LENGTH(hex)); - break; + case '\t': + builder.append('\\'); + builder.append('t'); + break; + case '\r': + builder.append('\\'); + builder.append('r'); + break; + case '\n': + builder.append('\\'); + builder.append('n'); + break; + case '\f': + builder.append('\\'); + builder.append('f'); + break; + case '\b': + builder.append('\\'); + builder.append('b'); + break; + case '"': + builder.append('\\'); + builder.append('"'); + break; + case '\\': + builder.append('\\'); + builder.append('\\'); + break; + default: + static const char hexDigits[] = "0123456789abcdef"; + UChar ch = data[i]; + LChar hex[] = { '\\', 'u', static_cast(hexDigits[(ch >> 12) & 0xF]), static_cast(hexDigits[(ch >> 8) & 0xF]), static_cast(hexDigits[(ch >> 4) & 0xF]), static_cast(hexDigits[ch & 0xF]) }; + builder.append(hex, WTF_ARRAY_LENGTH(hex)); + break; } } +} + +void Stringifier::appendQuotedString(StringBuilder& builder, const String& value) +{ + int length = value.length(); + + builder.append('"'); + + if (value.is8Bit()) + appendStringToStringBuilder(builder, value.characters8(), length); + else + appendStringToStringBuilder(builder, value.characters16(), length); builder.append('"'); } @@ -320,10 +320,10 @@ void Stringifier::appendQuotedString(UStringBuilder& builder, const UString& val inline JSValue Stringifier::toJSON(JSValue value, const PropertyNameForFunctionCall& propertyName) { ASSERT(!m_exec->hadException()); - if (!value.isObject() || !asObject(value)->hasProperty(m_exec, m_exec->globalData().propertyNames->toJSON)) + if (!value.isObject() || !asObject(value)->hasProperty(m_exec, m_exec->vm().propertyNames->toJSON)) return value; - JSValue toJSONFunction = asObject(value)->get(m_exec, m_exec->globalData().propertyNames->toJSON); + JSValue toJSONFunction = asObject(value)->get(m_exec, m_exec->vm().propertyNames->toJSON); if (m_exec->hadException()) return jsNull(); @@ -332,16 +332,16 @@ inline JSValue Stringifier::toJSON(JSValue value, const PropertyNameForFunctionC JSObject* object = asObject(toJSONFunction); CallData callData; - CallType callType = object->getCallData(callData); + CallType callType = object->methodTable()->getCallData(object, callData); if (callType == CallTypeNone) return value; - JSValue list[] = { propertyName.value(m_exec) }; - ArgList args(list, WTF_ARRAY_LENGTH(list)); + MarkedArgumentBuffer args; + args.append(propertyName.value(m_exec)); return call(m_exec, object, callType, callData, value, args); } -Stringifier::StringifyResult Stringifier::appendStringifiedValue(UStringBuilder& builder, JSValue value, JSObject* holder, const PropertyNameForFunctionCall& propertyName) +Stringifier::StringifyResult Stringifier::appendStringifiedValue(StringBuilder& builder, JSValue value, JSObject* holder, const PropertyNameForFunctionCall& propertyName) { // Call the toJSON function. value = toJSON(value, propertyName); @@ -350,8 +350,9 @@ Stringifier::StringifyResult Stringifier::appendStringifiedValue(UStringBuilder& // Call the replacer function. if (m_replacerCallType != CallTypeNone) { - JSValue list[] = { propertyName.value(m_exec), value }; - ArgList args(list, WTF_ARRAY_LENGTH(list)); + MarkedArgumentBuffer args; + args.append(propertyName.value(m_exec)); + args.append(value); value = call(m_exec, m_replacer.get(), m_replacerCallType, m_replacerCallData, holder, args); if (m_exec->hadException()) return StringifyFailed; @@ -361,7 +362,7 @@ Stringifier::StringifyResult Stringifier::appendStringifiedValue(UStringBuilder& return StringifyFailedDueToUndefinedValue; if (value.isNull()) { - builder.append("null"); + builder.appendLiteral("null"); return StringifySucceeded; } @@ -371,22 +372,25 @@ Stringifier::StringifyResult Stringifier::appendStringifiedValue(UStringBuilder& return StringifyFailed; if (value.isBoolean()) { - builder.append(value.getBoolean() ? "true" : "false"); + if (value.isTrue()) + builder.appendLiteral("true"); + else + builder.appendLiteral("false"); return StringifySucceeded; } - UString stringValue; + String stringValue; if (value.getString(m_exec, stringValue)) { appendQuotedString(builder, stringValue); return StringifySucceeded; } - double numericValue; - if (value.getNumber(numericValue)) { - if (!isfinite(numericValue)) - builder.append("null"); + if (value.isNumber()) { + double number = value.asNumber(); + if (!std::isfinite(number)) + builder.appendLiteral("null"); else - builder.append(UString::number(numericValue)); + builder.append(String::numberToStringECMAScript(number)); return StringifySucceeded; } @@ -396,9 +400,9 @@ Stringifier::StringifyResult Stringifier::appendStringifiedValue(UStringBuilder& JSObject* object = asObject(value); CallData callData; - if (object->getCallData(callData) != CallTypeNone) { + if (object->methodTable()->getCallData(object, callData) != CallTypeNone) { if (holder->inherits(&JSArray::s_info)) { - builder.append("null"); + builder.appendLiteral("null"); return StringifySucceeded; } return StringifyFailedDueToUndefinedValue; @@ -407,30 +411,19 @@ Stringifier::StringifyResult Stringifier::appendStringifiedValue(UStringBuilder& // Handle cycle detection, and put the holder on the stack. for (unsigned i = 0; i < m_holderStack.size(); i++) { if (m_holderStack[i].object() == object) { - throwError(m_exec, createTypeError(m_exec, "JSON.stringify cannot serialize cyclic structures.")); + throwError(m_exec, createTypeError(m_exec, ASCIILiteral("JSON.stringify cannot serialize cyclic structures."))); return StringifyFailed; } } bool holderStackWasEmpty = m_holderStack.isEmpty(); - m_holderStack.append(Holder(m_exec->globalData(), object)); + m_holderStack.append(Holder(m_exec->vm(), object)); if (!holderStackWasEmpty) return StringifySucceeded; - // If this is the outermost call, then loop to handle everything on the holder stack. - TimeoutChecker localTimeoutChecker(m_exec->globalData().timeoutChecker); - localTimeoutChecker.reset(); - unsigned tickCount = localTimeoutChecker.ticksUntilNextCheck(); do { while (m_holderStack.last().appendNextProperty(*this, builder)) { if (m_exec->hadException()) return StringifyFailed; - if (!--tickCount) { - if (localTimeoutChecker.didTimeOut(m_exec)) { - throwError(m_exec, createInterruptedExecutionException(&m_exec->globalData())); - return StringifyFailed; - } - tickCount = localTimeoutChecker.ticksUntilNextCheck(); - } } m_holderStack.removeLast(); } while (!m_holderStack.isEmpty()); @@ -447,7 +440,7 @@ inline void Stringifier::indent() // Use a single shared string, m_repeatedGap, so we don't keep allocating new ones as we indent and unindent. unsigned newSize = m_indent.length() + m_gap.length(); if (newSize > m_repeatedGap.length()) - m_repeatedGap = makeUString(m_repeatedGap, m_gap); + m_repeatedGap = makeString(m_repeatedGap, m_gap); ASSERT(newSize <= m_repeatedGap.length()); m_indent = m_repeatedGap.substringSharingImpl(0, newSize); } @@ -458,7 +451,7 @@ inline void Stringifier::unindent() m_indent = m_repeatedGap.substringSharingImpl(0, m_indent.length() - m_gap.length()); } -inline void Stringifier::startNewLine(UStringBuilder& builder) const +inline void Stringifier::startNewLine(StringBuilder& builder) const { if (m_gap.isEmpty()) return; @@ -466,14 +459,17 @@ inline void Stringifier::startNewLine(UStringBuilder& builder) const builder.append(m_indent); } -inline Stringifier::Holder::Holder(JSGlobalData& globalData, JSObject* object) - : m_object(globalData, object) +inline Stringifier::Holder::Holder(VM& vm, JSObject* object) + : m_object(vm, object) , m_isArray(object->inherits(&JSArray::s_info)) , m_index(0) +#ifndef NDEBUG + , m_size(0) +#endif { } -bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, UStringBuilder& builder) +bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, StringBuilder& builder) { ASSERT(m_index <= m_size); @@ -482,15 +478,15 @@ bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, UStringBu // First time through, initialize. if (!m_index) { if (m_isArray) { - m_isJSArray = isJSArray(&exec->globalData(), m_object.get()); - m_size = m_object->get(exec, exec->globalData().propertyNames->length).toUInt32(exec); + m_isJSArray = isJSArray(m_object.get()); + m_size = m_object->get(exec, exec->vm().propertyNames->length).toUInt32(exec); builder.append('['); } else { if (stringifier.m_usingArrayReplacer) m_propertyNames = stringifier.m_arrayReplacerPropertyNames.data(); else { PropertyNameArray objectPropertyNames(exec); - m_object->getOwnPropertyNames(exec, objectPropertyNames); + m_object->methodTable()->getOwnPropertyNames(m_object.get(), exec, objectPropertyNames, ExcludeDontEnumProperties); m_propertyNames = objectPropertyNames.releaseData(); } m_size = m_propertyNames->propertyNameVector().size(); @@ -515,11 +511,11 @@ bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, UStringBu if (m_isArray) { // Get the value. JSValue value; - if (m_isJSArray && asArray(m_object.get())->canGetIndex(index)) - value = asArray(m_object.get())->getIndex(index); + if (m_isJSArray && asArray(m_object.get())->canGetIndexQuickly(index)) + value = asArray(m_object.get())->getIndexQuickly(index); else { PropertySlot slot(m_object.get()); - if (!m_object->getOwnPropertySlot(exec, index, slot)) + if (!m_object->methodTable()->getOwnPropertySlotByIndex(m_object.get(), exec, index, slot)) slot.setUndefined(); if (exec->hadException()) return false; @@ -537,7 +533,7 @@ bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, UStringBu // Get the value. PropertySlot slot(m_object.get()); Identifier& propertyName = m_propertyNames->propertyNameVector()[index]; - if (!m_object->getOwnPropertySlot(exec, propertyName, slot)) + if (!m_object->methodTable()->getOwnPropertySlot(m_object.get(), exec, propertyName, slot)) return true; JSValue value = slot.getValue(exec, propertyName); if (exec->hadException()) @@ -551,7 +547,7 @@ bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, UStringBu stringifier.startNewLine(builder); // Append the property name. - appendQuotedString(builder, propertyName.ustring()); + appendQuotedString(builder, propertyName.string()); builder.append(':'); if (stringifier.willIndent()) builder.append(' '); @@ -566,7 +562,7 @@ bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, UStringBu switch (stringifyResult) { case StringifyFailed: - builder.append("null"); + builder.appendLiteral("null"); break; case StringifySucceeded: break; @@ -583,7 +579,7 @@ bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, UStringBu // ------------------------------ JSONObject -------------------------------- -const ClassInfo JSONObject::s_info = { "JSON", &JSObjectWithGlobalObject::s_info, 0, ExecState::jsonTable }; +const ClassInfo JSONObject::s_info = { "JSON", &JSNonFinalObject::s_info, 0, ExecState::jsonTable, CREATE_METHOD_TABLE(JSONObject) }; /* Source for JSONObject.lut.h @begin jsonTable @@ -594,21 +590,21 @@ const ClassInfo JSONObject::s_info = { "JSON", &JSObjectWithGlobalObject::s_info // ECMA 15.8 -bool JSONObject::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot) +bool JSONObject::getOwnPropertySlot(JSCell* cell, ExecState* exec, PropertyName propertyName, PropertySlot& slot) { - return getStaticFunctionSlot(exec, ExecState::jsonTable(exec), this, propertyName, slot); + return getStaticFunctionSlot(exec, ExecState::jsonTable(exec), jsCast(cell), propertyName, slot); } -bool JSONObject::getOwnPropertyDescriptor(ExecState* exec, const Identifier& propertyName, PropertyDescriptor& descriptor) +bool JSONObject::getOwnPropertyDescriptor(JSObject* object, ExecState* exec, PropertyName propertyName, PropertyDescriptor& descriptor) { - return getStaticFunctionDescriptor(exec, ExecState::jsonTable(exec), this, propertyName, descriptor); + return getStaticFunctionDescriptor(exec, ExecState::jsonTable(exec), jsCast(object), propertyName, descriptor); } class Walker { public: Walker(ExecState* exec, Handle function, CallType callType, CallData callData) : m_exec(exec) - , m_function(exec->globalData(), function) + , m_function(exec->vm(), function) , m_callType(callType) , m_callData(callData) { @@ -617,9 +613,10 @@ public: private: JSValue callReviver(JSObject* thisObj, JSValue property, JSValue unfiltered) { - JSValue args[] = { property, unfiltered }; - ArgList argList(args, 2); - return call(m_exec, m_function.get(), m_callType, m_callData, thisObj, argList); + MarkedArgumentBuffer args; + args.append(property); + args.append(unfiltered); + return call(m_exec, m_function.get(), m_callType, m_callData, thisObj, args); } friend class Holder; @@ -630,32 +627,28 @@ private: CallData m_callData; }; -// We clamp recursion well beyond anything reasonable, but we also have a timeout check -// to guard against "infinite" execution by inserting arbitrarily large objects. +// We clamp recursion well beyond anything reasonable. static const unsigned maximumFilterRecursion = 40000; enum WalkerState { StateUnknown, ArrayStartState, ArrayStartVisitMember, ArrayEndVisitMember, ObjectStartState, ObjectStartVisitMember, ObjectEndVisitMember }; NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) { - Vector propertyStack; - Vector indexStack; - LocalStack objectStack(m_exec->globalData()); - LocalStack arrayStack(m_exec->globalData()); + Vector propertyStack; + Vector indexStack; + LocalStack objectStack(m_exec->vm()); + LocalStack arrayStack(m_exec->vm()); - Vector stateStack; + Vector stateStack; WalkerState state = StateUnknown; JSValue inValue = unfiltered; JSValue outValue = jsNull(); - TimeoutChecker localTimeoutChecker(m_exec->globalData().timeoutChecker); - localTimeoutChecker.reset(); - unsigned tickCount = localTimeoutChecker.ticksUntilNextCheck(); while (1) { switch (state) { arrayStartState: case ArrayStartState: { ASSERT(inValue.isObject()); - ASSERT(isJSArray(&m_exec->globalData(), asObject(inValue)) || asObject(inValue)->inherits(&JSArray::s_info)); + ASSERT(isJSArray(asObject(inValue)) || asObject(inValue)->inherits(&JSArray::s_info)); if (objectStack.size() + arrayStack.size() > maximumFilterRecursion) return throwError(m_exec, createStackOverflowError(m_exec)); @@ -666,12 +659,6 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) } arrayStartVisitMember: case ArrayStartVisitMember: { - if (!--tickCount) { - if (localTimeoutChecker.didTimeOut(m_exec)) - return throwError(m_exec, createInterruptedExecutionException(&m_exec->globalData())); - tickCount = localTimeoutChecker.ticksUntilNextCheck(); - } - JSArray* array = arrayStack.peek(); uint32_t index = indexStack.last(); if (index == array->length()) { @@ -680,11 +667,11 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) indexStack.removeLast(); break; } - if (isJSArray(&m_exec->globalData(), array) && array->canGetIndex(index)) - inValue = array->getIndex(index); + if (isJSArray(array) && array->canGetIndexQuickly(index)) + inValue = array->getIndexQuickly(index); else { PropertySlot slot; - if (array->getOwnPropertySlot(m_exec, index, slot)) + if (array->methodTable()->getOwnPropertySlotByIndex(array, m_exec, index, slot)) inValue = slot.getValue(m_exec, index); else inValue = jsUndefined(); @@ -699,15 +686,11 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) } case ArrayEndVisitMember: { JSArray* array = arrayStack.peek(); - JSValue filteredValue = callReviver(array, jsString(m_exec, UString::number(indexStack.last())), outValue); + JSValue filteredValue = callReviver(array, jsString(m_exec, String::number(indexStack.last())), outValue); if (filteredValue.isUndefined()) - array->deleteProperty(m_exec, indexStack.last()); - else { - if (isJSArray(&m_exec->globalData(), array) && array->canSetIndex(indexStack.last())) - array->setIndex(m_exec->globalData(), indexStack.last(), filteredValue); - else - array->put(m_exec, indexStack.last(), filteredValue); - } + array->methodTable()->deletePropertyByIndex(array, m_exec, indexStack.last()); + else + array->putDirectIndex(m_exec, indexStack.last(), filteredValue); if (m_exec->hadException()) return jsNull(); indexStack.last()++; @@ -716,7 +699,7 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) objectStartState: case ObjectStartState: { ASSERT(inValue.isObject()); - ASSERT(!isJSArray(&m_exec->globalData(), asObject(inValue)) && !asObject(inValue)->inherits(&JSArray::s_info)); + ASSERT(!isJSArray(asObject(inValue)) && !asObject(inValue)->inherits(&JSArray::s_info)); if (objectStack.size() + arrayStack.size() > maximumFilterRecursion) return throwError(m_exec, createStackOverflowError(m_exec)); @@ -724,17 +707,11 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) objectStack.push(object); indexStack.append(0); propertyStack.append(PropertyNameArray(m_exec)); - object->getOwnPropertyNames(m_exec, propertyStack.last()); + object->methodTable()->getOwnPropertyNames(object, m_exec, propertyStack.last(), ExcludeDontEnumProperties); // fallthrough } objectStartVisitMember: case ObjectStartVisitMember: { - if (!--tickCount) { - if (localTimeoutChecker.didTimeOut(m_exec)) - return throwError(m_exec, createInterruptedExecutionException(&m_exec->globalData())); - tickCount = localTimeoutChecker.ticksUntilNextCheck(); - } - JSObject* object = objectStack.peek(); uint32_t index = indexStack.last(); PropertyNameArray& properties = propertyStack.last(); @@ -746,7 +723,7 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) break; } PropertySlot slot; - if (object->getOwnPropertySlot(m_exec, properties[index], slot)) + if (object->methodTable()->getOwnPropertySlot(object, m_exec, properties[index], slot)) inValue = slot.getValue(m_exec, properties[index]); else inValue = jsUndefined(); @@ -766,11 +743,11 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) JSObject* object = objectStack.peek(); Identifier prop = propertyStack.last()[indexStack.last()]; PutPropertySlot slot; - JSValue filteredValue = callReviver(object, jsString(m_exec, prop.ustring()), outValue); + JSValue filteredValue = callReviver(object, jsString(m_exec, prop.string()), outValue); if (filteredValue.isUndefined()) - object->deleteProperty(m_exec, prop); + object->methodTable()->deleteProperty(object, m_exec, prop); else - object->put(m_exec, prop, filteredValue, slot); + object->methodTable()->put(object, m_exec, prop, filteredValue, slot); if (m_exec->hadException()) return jsNull(); indexStack.last()++; @@ -783,7 +760,7 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) break; } JSObject* object = asObject(inValue); - if (isJSArray(&m_exec->globalData(), object) || object->inherits(&JSArray::s_info)) + if (isJSArray(object) || object->inherits(&JSArray::s_info)) goto arrayStartState; goto objectStartState; } @@ -792,16 +769,10 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) state = stateStack.last(); stateStack.removeLast(); - - if (!--tickCount) { - if (localTimeoutChecker.didTimeOut(m_exec)) - return throwError(m_exec, createInterruptedExecutionException(&m_exec->globalData())); - tickCount = localTimeoutChecker.ticksUntilNextCheck(); - } } JSObject* finalHolder = constructEmptyObject(m_exec); PutPropertySlot slot; - finalHolder->put(m_exec, m_exec->globalData().propertyNames->emptyIdentifier, outValue, slot); + finalHolder->methodTable()->put(finalHolder, m_exec, m_exec->vm().propertyNames->emptyIdentifier, outValue, slot); return callReviver(finalHolder, jsEmptyString(m_exec), outValue); } @@ -809,17 +780,24 @@ NEVER_INLINE JSValue Walker::walk(JSValue unfiltered) EncodedJSValue JSC_HOST_CALL JSONProtoFuncParse(ExecState* exec) { if (!exec->argumentCount()) - return throwVMError(exec, createError(exec, "JSON.parse requires at least one parameter")); - JSValue value = exec->argument(0); - UString source = value.toString(exec); + return throwVMError(exec, createError(exec, ASCIILiteral("JSON.parse requires at least one parameter"))); + String source = exec->argument(0).toString(exec)->value(exec); if (exec->hadException()) return JSValue::encode(jsNull()); - LocalScope scope(exec->globalData()); - LiteralParser jsonParser(exec, source.characters(), source.length(), LiteralParser::StrictJSON); - JSValue unfiltered = jsonParser.tryLiteralParse(); - if (!unfiltered) - return throwVMError(exec, createSyntaxError(exec, "Unable to parse JSON string")); + JSValue unfiltered; + LocalScope scope(exec->vm()); + if (source.is8Bit()) { + LiteralParser jsonParser(exec, source.characters8(), source.length(), StrictJSON); + unfiltered = jsonParser.tryLiteralParse(); + if (!unfiltered) + return throwVMError(exec, createSyntaxError(exec, jsonParser.getErrorMessage())); + } else { + LiteralParser jsonParser(exec, source.characters16(), source.length(), StrictJSON); + unfiltered = jsonParser.tryLiteralParse(); + if (!unfiltered) + return throwVMError(exec, createSyntaxError(exec, jsonParser.getErrorMessage())); + } if (exec->argumentCount() < 2) return JSValue::encode(unfiltered); @@ -829,27 +807,27 @@ EncodedJSValue JSC_HOST_CALL JSONProtoFuncParse(ExecState* exec) CallType callType = getCallData(function, callData); if (callType == CallTypeNone) return JSValue::encode(unfiltered); - return JSValue::encode(Walker(exec, Local(exec->globalData(), asObject(function)), callType, callData).walk(unfiltered)); + return JSValue::encode(Walker(exec, Local(exec->vm(), asObject(function)), callType, callData).walk(unfiltered)); } // ECMA-262 v5 15.12.3 EncodedJSValue JSC_HOST_CALL JSONProtoFuncStringify(ExecState* exec) { if (!exec->argumentCount()) - return throwVMError(exec, createError(exec, "No input to stringify")); - LocalScope scope(exec->globalData()); - Local value(exec->globalData(), exec->argument(0)); - Local replacer(exec->globalData(), exec->argument(1)); - Local space(exec->globalData(), exec->argument(2)); + return throwVMError(exec, createError(exec, ASCIILiteral("No input to stringify"))); + LocalScope scope(exec->vm()); + Local value(exec->vm(), exec->argument(0)); + Local replacer(exec->vm(), exec->argument(1)); + Local space(exec->vm(), exec->argument(2)); return JSValue::encode(Stringifier(exec, replacer, space).stringify(value).get()); } -UString JSONStringify(ExecState* exec, JSValue value, unsigned indent) +String JSONStringify(ExecState* exec, JSValue value, unsigned indent) { - LocalScope scope(exec->globalData()); - Local result = Stringifier(exec, Local(exec->globalData(), jsNull()), Local(exec->globalData(), jsNumber(indent))).stringify(Local(exec->globalData(), value)); + LocalScope scope(exec->vm()); + Local result = Stringifier(exec, Local(exec->vm(), jsNull()), Local(exec->vm(), jsNumber(indent))).stringify(Local(exec->vm(), value)); if (result.isUndefinedOrNull()) - return UString(); + return String(); return result.getString(exec); }