From 4c225b0e41aa6339725f7a533a377903d4824289 Mon Sep 17 00:00:00 2001 From: Dan Morrill Date: Tue, 3 Apr 2012 12:44:40 -0700 Subject: [PATCH 1/1] Adding a line for android-debuggable to 'dump badging' if AndroidManifest.xml is configured as such. This is to be used by e.g. Play Store to warn the developer that they are about to publish a security hole. Change-Id: Ib6f8537462cbc00ed0504435bdeee2aae0c5b69b --- Command.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Command.cpp b/Command.cpp index 198fce4..0238119 100644 --- a/Command.cpp +++ b/Command.cpp @@ -345,6 +345,7 @@ enum { LABEL_ATTR = 0x01010001, ICON_ATTR = 0x01010002, NAME_ATTR = 0x01010003, + DEBUGGABLE_ATTR = 0x0101000f, VERSION_CODE_ATTR = 0x0101021b, VERSION_NAME_ATTR = 0x0101021c, SCREEN_ORIENTATION_ATTR = 0x0101001e, @@ -824,6 +825,15 @@ int doDump(Bundle* bundle) if (testOnly != 0) { printf("testOnly='%d'\n", testOnly); } + + int32_t debuggable = getResolvedIntegerAttribute(&res, tree, DEBUGGABLE_ATTR, &error, 0); + if (error != "") { + fprintf(stderr, "ERROR getting 'android:debuggable' attribute: %s\n", error.string()); + goto bail; + } + if (debuggable != 0) { + printf("application-debuggable\n"); + } } else if (tag == "uses-sdk") { int32_t code = getIntegerAttribute(tree, MIN_SDK_VERSION_ATTR, &error); if (error != "") { -- 2.45.2