From: Dianne Hackborn <hackbod@google.com>
Date: Tue, 12 Jun 2012 20:00:15 +0000 (-0700)
Subject: am 6892f1ec: am 0f6471ac: Merge "Fix issue #6641368: can\'t launch gallery" into... 
X-Git-Url: https://git.saurik.com/android/aapt.git/commitdiff_plain/99f0611a1945bde8d4e82bde7474fd72f3efc935?hp=5b1571926646584beb8133b65a5ed90bd0f63c0e

am 6892f1ec: am 0f6471ac: Merge "Fix issue #6641368: can\'t launch gallery" into jb-dev

* commit '6892f1ec9670432f1cab71813592077bea991a8b':
  Fix issue #6641368: can't launch gallery
---

diff --git a/Command.cpp b/Command.cpp
index d428fef..0a5e590 100644
--- a/Command.cpp
+++ b/Command.cpp
@@ -1204,7 +1204,9 @@ int doDump(Bundle* bundle)
             }
 
             // If the application has requested WRITE_EXTERNAL_STORAGE, we will
-            // force them to always take READ_EXTERNAL_STORAGE as well.
+            // force them to always take READ_EXTERNAL_STORAGE as well.  We always
+            // do this (regardless of target API version) because we can't have
+            // an app with write permission but not read permission.
             if (!hasReadExternalStoragePermission && hasWriteExternalStoragePermission) {
                 printf("uses-permission:'android.permission.READ_EXTERNAL_STORAGE'\n");
                 printf("uses-implied-permission:'android.permission.READ_EXTERNAL_STORAGE'," \