From: Jean-Baptiste Queru Date: Tue, 1 May 2012 17:00:22 +0000 (-0700) Subject: resolved conflicts for merge of 13c04786 to jb-dev-plus-aosp X-Git-Url: https://git.saurik.com/android/aapt.git/commitdiff_plain/49a9bf69364a9a501259785d47b9a4ac30e341eb?hp=56918fa3750fca8d91eaa99d1d21f0cdca3dbc5e resolved conflicts for merge of 13c04786 to jb-dev-plus-aosp Change-Id: Ib7aa5a768f4606beb2a4387811cfed7c00cbc111 --- diff --git a/ResourceTable.cpp b/ResourceTable.cpp index 22b75d8..d98fe65 100644 --- a/ResourceTable.cpp +++ b/ResourceTable.cpp @@ -2749,6 +2749,12 @@ status_t ResourceTable::flatten(Bundle* bundle, const sp& dest) const bool filterable = (typeName != mipmap16); const size_t N = t != NULL ? t->getOrderedConfigs().size() : 0; + + // Until a non-NO_ENTRY value has been written for a resource, + // that resource is invalid; validResources[i] represents + // the item at t->getOrderedConfigs().itemAt(i). + Vector validResources; + validResources.insertAt(false, 0, N); // First write the typeSpec chunk, containing information about // each resource entry in this type. @@ -2885,6 +2891,7 @@ status_t ResourceTable::flatten(Bundle* bundle, const sp& dest) if (amt < 0) { return amt; } + validResources.editItemAt(ei) = true; } else { index[ei] = htodl(ResTable_type::NO_ENTRY); } @@ -2895,6 +2902,14 @@ status_t ResourceTable::flatten(Bundle* bundle, const sp& dest) (((uint8_t*)data->editData()) + typeStart); tHeader->header.size = htodl(data->getSize()-typeStart); } + + for (size_t i = 0; i < N; ++i) { + if (!validResources[i]) { + sp c = t->getOrderedConfigs().itemAt(i); + fprintf(stderr, "warning: no entries written for %s/%s\n", + String8(typeName).string(), String8(c->getName()).string()); + } + } } // Fill in the rest of the package information.