X-Git-Url: https://git.saurik.com/android/aapt.git/blobdiff_plain/49a9bf69364a9a501259785d47b9a4ac30e341eb..4f2cc28592dc79e929d6422887b9f71702ec510a:/Command.cpp?ds=sidebyside

diff --git a/Command.cpp b/Command.cpp
index d428fef..0a5e590 100644
--- a/Command.cpp
+++ b/Command.cpp
@@ -1204,7 +1204,9 @@ int doDump(Bundle* bundle)
             }
 
             // If the application has requested WRITE_EXTERNAL_STORAGE, we will
-            // force them to always take READ_EXTERNAL_STORAGE as well.
+            // force them to always take READ_EXTERNAL_STORAGE as well.  We always
+            // do this (regardless of target API version) because we can't have
+            // an app with write permission but not read permission.
             if (!hasReadExternalStoragePermission && hasWriteExternalStoragePermission) {
                 printf("uses-permission:'android.permission.READ_EXTERNAL_STORAGE'\n");
                 printf("uses-implied-permission:'android.permission.READ_EXTERNAL_STORAGE'," \